diff mbox series

[bug#41076] services: For sddm pam service include limits.conf.

Message ID 7947b43e6d9d8737f5db0d3e3a58db50@autistici.org
State Accepted
Headers show
Series [bug#41076] services: For sddm pam service include limits.conf. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Giacomo Leidi May 4, 2020, 3:08 p.m. UTC
Hello Guix,
This fixes bug #37380 for SDDM users.

Today I was setting up my system following [0] to use realtime 
scheduling with JACK and SuperCollider. After a lot of failures and a 
lot of help on IRC from rekado I found out that it wasn't me it was just 
a bug.

The bug is the same as [1] and my solution is the same as [2] but for 
SDDM. I tested my patch with the attached system configuration 
(shamelessly copied from [3]).

Thanks,

Giacomo

[0]: 
https://guix.gnu.org/manual/en/html_node/Base-Services.html#index-realtime
[1]: https://issues.guix.gnu.org/issue/37380
[2]: https://issues.guix.gnu.org/issue/37405
[3]: https://lists.gnu.org/archive/html/help-guix/2019-09/msg00065.html
(use-modules (gnu)
             (gnu services sddm)
	     (gnu services desktop)
	     (gnu services sound)
	     (gnu services xorg)
             (srfi srfi-1))
(operating-system
 (bootloader
  (bootloader-configuration
  (bootloader grub-bootloader)))
  (host-name "jack-os")
 (file-systems (cons
		(file-system
		 (type "ext4")
		 (mount-point "/")
		 (device (file-system-label "my-root")))
		%base-file-systems))
 (timezone "America/Boise")
 (users (cons (user-account
	       (name "user")
	       (comment "not root")
	       (group "users")
	       (password (crypt "ciao" "nr"))
	       (supplementary-groups '("wheel" "netdev"
				       "audio" "video")))
	      %base-user-accounts))
 (packages (cons*
	    (specification->package "ratpoison")
	    (specification->package "xterm")
	    (specification->package "icecat")
	    (specification->package "nss-certs")
	    (specification->package "qjackctl")
	    (specification->package "jack")
	    (specification->package "alsa-plugins")
	    %base-packages))
 (services
  (cons* (service sddm-service-type)
         (pam-limits-service
          (list
           (pam-limits-entry "@audio" 'both 'rtprio 99)
           (pam-limits-entry "@audio" 'both 'memlock 'unlimited)
           (pam-limits-entry "@realtime" 'both 'rtprio 99)
           (pam-limits-entry "@realtime" 'both 'memlock 'unlimited)))
       (remove (lambda (service)
              (eq? (service-kind service) gdm-service-type))
               %desktop-services)))
 (name-service-switch %mdns-host-lookup-nss))

Comments

Marius Bakke May 5, 2020, 6:02 p.m. UTC | #1
goodoldpaul@autistici.org writes:

> Hello Guix,
> This fixes bug #37380 for SDDM users.
>
> Today I was setting up my system following [0] to use realtime 
> scheduling with JACK and SuperCollider. After a lot of failures and a 
> lot of help on IRC from rekado I found out that it wasn't me it was just 
> a bug.
>
> The bug is the same as [1] and my solution is the same as [2] but for 
> SDDM. I tested my patch with the attached system configuration 
> (shamelessly copied from [3]).

Applied, thanks!
diff mbox series

Patch

From 258238606d0053c7e3df28bd57e931644d8b89f6 Mon Sep 17 00:00:00 2001
From: Giacomo Leidi <goodoldpaul@autistici.org>
Date: Mon, 4 May 2020 16:58:24 +0200
Subject: [PATCH] services: For "sddm" pam service, include "limits.conf".

* gnu/services/base.scm (pam-limits-service-type): For "sddm" pam
service, include "limits.conf".
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 0f119cc2f9..a031ccc04b 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1379,7 +1379,7 @@  information on the configuration file syntax."
                               (module "pam_limits.so")
                               (arguments '("conf=/etc/security/limits.conf")))))
              (if (member (pam-service-name pam)
-                         '("login" "su" "slim" "gdm-password"))
+                         '("login" "su" "slim" "gdm-password" "sddm"))
                  (pam-service
                   (inherit pam)
                   (session (cons pam-limits
-- 
2.26.2