diff mbox series

[bug#72006] gnu: emacs-empv: Update to 4.3.0 revision 2.

Message ID 78593d86ffd76ef7f1f5fc5f5ab8a6e820acfad4.1720525583.git.gemmaro.dev@gmail.com
State New
Headers show
Series [bug#72006] gnu: emacs-empv: Update to 4.3.0 revision 2. | expand

Commit Message

gemmaro July 9, 2024, 11:46 a.m. UTC
* gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.
[arguments]: Add a phase to set default binaries for fd and mpv.
[inputs]: Add fd and mpv.
[propagated-inputs]: Add emacs-consult.

Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
---
 gnu/packages/emacs-xyz.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)


base-commit: 6b496c071537e399710ff5ec0284f74a44b66c71
prerequisite-patch-id: 7243f4196faacbbb69b65baecf49b488e4c8a910

Comments

Nicolas Goaziou July 9, 2024, 1:10 p.m. UTC | #1
Hello,

> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.

I skipped that part. It is not necessary, since the patch doesn't modify
the commit hash.

Applied. Thank you!

Regards,
Liliana Marie Prikler July 9, 2024, 5:09 p.m. UTC | #2
Am Dienstag, dem 09.07.2024 um 20:46 +0900 schrieb gemmaro:
> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision
> 2.
You don't need to bump the revision to update a recipe.
> [arguments]: Add a phase to set default binaries for fd and mpv.
> [inputs]: Add fd and mpv.
> [propagated-inputs]: Add emacs-consult.
> 
> Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
> ---
>  gnu/packages/emacs-xyz.scm | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 45225f2051..d7b25af21c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3751,7 +3751,7 @@ (define-public emacs-emprise
>  
>  (define-public emacs-empv
>    (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
> -        (revision "1"))
> +        (revision "2"))
>      (package
>        (name "emacs-empv")
>        (version (git-version "4.3.0" revision commit))
> @@ -3766,7 +3766,16 @@ (define-public emacs-empv
>            (base32
>            
> "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
>        (build-system emacs-build-system)
> -      (propagated-inputs (list emacs-compat emacs-s))
> +      (arguments
> +       (list
> +        #:phases #~(modify-phases %standard-phases
> +                     (add-after 'unpack 'set-default-binaries
> +                       (lambda* (#:key inputs #:allow-other-keys)
> +                         (emacs-substitute-variables "empv.el"
> +                           ("empv-fd-binary" (search-input-file
> inputs "/bin/fd"))
> +                           ("empv-mpv-binary" (search-input-file
> inputs "/bin/mpv"))))))))
> +      (inputs (list fd mpv))
> +      (propagated-inputs (list emacs-compat emacs-consult emacs-s))
>        (home-page "https://github.com/isamert/empv.el")
>        (synopsis
>         "Emacs multimedia player, media library manager, YouTube
> frontend")
Otherwise LGTM.
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45225f2051..d7b25af21c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3751,7 +3751,7 @@  (define-public emacs-emprise
 
 (define-public emacs-empv
   (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
-        (revision "1"))
+        (revision "2"))
     (package
       (name "emacs-empv")
       (version (git-version "4.3.0" revision commit))
@@ -3766,7 +3766,16 @@  (define-public emacs-empv
           (base32
            "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
       (build-system emacs-build-system)
-      (propagated-inputs (list emacs-compat emacs-s))
+      (arguments
+       (list
+        #:phases #~(modify-phases %standard-phases
+                     (add-after 'unpack 'set-default-binaries
+                       (lambda* (#:key inputs #:allow-other-keys)
+                         (emacs-substitute-variables "empv.el"
+                           ("empv-fd-binary" (search-input-file inputs "/bin/fd"))
+                           ("empv-mpv-binary" (search-input-file inputs "/bin/mpv"))))))))
+      (inputs (list fd mpv))
+      (propagated-inputs (list emacs-compat emacs-consult emacs-s))
       (home-page "https://github.com/isamert/empv.el")
       (synopsis
        "Emacs multimedia player, media library manager, YouTube frontend")