diff mbox series

[bug#65644,gnome-team,9/9] gnu: gnome-shell: Update to 44.3.

Message ID 784d9cde7ead9ea237035b7f19d0c46346d4fade.1693454927.git.liliana.prikler@gmail.com
State New
Headers show
Series Update GNOME Shell to 44 | expand

Commit Message

Liliana Marie Prikler Aug. 31, 2023, 3:35 a.m. UTC 
* gnu/packages/gnome.scm (gnome-shell): Update to 44.3.
[arguments]<#:phases>: Add ‘unbreak-perf-tests’.
Adjust ‘pre-check’ accordingly.
[native-inputs]: Add python-dbus and python-dbusmock.
[inputs]: Remove caribou.  Replace gcr with gcr-4.
---
 gnu/packages/gnome.scm | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

Comments

Maxim Cournoyer Sept. 5, 2023, 2:59 a.m. UTC | #1 
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gnome.scm (gnome-shell): Update to 44.3.
> [arguments]<#:phases>: Add ‘unbreak-perf-tests’.
> Adjust ‘pre-check’ accordingly.
> [native-inputs]: Add python-dbus and python-dbusmock.
> [inputs]: Remove caribou.  Replace gcr with gcr-4.
> ---
>  gnu/packages/gnome.scm | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 5e6a6df44c..d4e78bb08d 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -9114,7 +9114,7 @@ (define-public gnome-control-center
>  (define-public gnome-shell
>    (package
>      (name "gnome-shell")
> -    (version "42.4")
> +    (version "44.3")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/" name "/"
> @@ -9122,7 +9122,7 @@ (define-public gnome-shell
>                                    name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "0kn5fclciybp2fs38wd39hdz85y91pas0ckfa02pmyx91sbz4pw7"))))
> +                "1grizh3fbks5dgizaj38300cz97ay81q0hlk1pvawkpfq9qlnsam"))))
>      (build-system meson-build-system)
>      (arguments
>       (let ((disallowed-references
> @@ -9160,6 +9160,12 @@ (define-public gnome-shell
>                  (substitute* "meson.build"
>                    (("gtk_update_icon_cache: true")
>                     "gtk_update_icon_cache: false"))))
> +            (add-after 'unpack 'unbreak-perf-tests
> +              (lambda _
> +                ;; non-fatal dbus warning otherwise causes shell to crash

Please punctuate stand-alone comments (capitalization, periods).

Otherwise LGTM.
diff mbox series

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5e6a6df44c..d4e78bb08d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9114,7 +9114,7 @@  (define-public gnome-control-center
 (define-public gnome-shell
   (package
     (name "gnome-shell")
-    (version "42.4")
+    (version "44.3")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -9122,7 +9122,7 @@  (define-public gnome-shell
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "0kn5fclciybp2fs38wd39hdz85y91pas0ckfa02pmyx91sbz4pw7"))))
+                "1grizh3fbks5dgizaj38300cz97ay81q0hlk1pvawkpfq9qlnsam"))))
     (build-system meson-build-system)
     (arguments
      (let ((disallowed-references
@@ -9160,6 +9160,12 @@  (define-public gnome-shell
                 (substitute* "meson.build"
                   (("gtk_update_icon_cache: true")
                    "gtk_update_icon_cache: false"))))
+            (add-after 'unpack 'unbreak-perf-tests
+              (lambda _
+                ;; non-fatal dbus warning otherwise causes shell to crash
+                (substitute* "tests/meson.build"
+                  (("perf_testenv\\.set\\('G_DEBUG'" all)
+                   (string-append "# " all)))))
             (add-before 'configure 'record-absolute-file-names
               (lambda* (#:key inputs #:allow-other-keys)
                 (let ((ibus-daemon (search-input-file inputs "bin/ibus-daemon"))
@@ -9176,7 +9182,13 @@  (define-public gnome-shell
                 ;; Tests require a running X server.
                 (system "Xvfb :1 &")
                 (setenv "DISPLAY" ":1")
-                (setenv "HOME" "/tmp"))) ;to avoid "fatal" warnings
+                ;; For the missing /var/lib/dbus/machine-id
+                (setenv "DBUS_FATAL_WARNINGS" "0")
+                (setenv "NO_AT_BRIDGE" "1")
+                (setenv "HOME" "/tmp")
+                (setenv "XDG_RUNTIME_DIR" (string-append (getcwd) "/runtime-dir"))
+                (mkdir (getenv "XDG_RUNTIME_DIR"))
+                (chmod (getenv "XDG_RUNTIME_DIR") #o700)))
             (add-after 'install 'wrap-programs
               (lambda* (#:key inputs #:allow-other-keys)
                 (let ((gi-typelib-path  (getenv "GI_TYPELIB_PATH"))
@@ -9242,16 +9254,17 @@  (define-public gnome-shell
            perl
            pkg-config
            python
+           python-dbus
+           python-dbusmock
            ruby-sass
            sassc
            ;; For tests
            xorg-server-for-tests))
     (inputs
      (list accountsservice
-           caribou
            docbook-xsl
            evolution-data-server
-           gcr
+           gcr-4
            gdm
            librsvg
            gjs