diff mbox series

[bug#64176,v2] gnu: Add nscde

Message ID 723fbb5d03a213c717aca6b87b182a55a991f574.1687740373.git.atai@atai.org
State New
Headers show
Series [bug#64176,v2] gnu: Add nscde | expand

Commit Message

Andy Tai June 26, 2023, 12:47 a.m. UTC 
* gnu/packages/fvwm.scm (nscde): New variable
---
 gnu/packages/fvwm.scm | 70 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 69 insertions(+), 1 deletion(-)


base-commit: 269cfe341f242c2b5f37774cb9b1e17d9aa68e2c

Comments

Ludovic Courtès July 10, 2023, 9:14 p.m. UTC | #1 
Hi,

Andy Tai <atai@atai.org> skribis:

> * gnu/packages/fvwm.scm (nscde): New variable

[...]

> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/NsCDE/NsCDE/releases/download/"
> +                    version "/NsCDE-" version ".tar.gz"))

Upon closer inspection, I noticed an unexpected size distribution:

--8<---------------cut here---------------start------------->8---
$ du -s /tmp/NsCDE-2.3/*|sort -k1 -n
0	/tmp/NsCDE-2.3/LICENSE
4	/tmp/NsCDE-2.3/autogen.sh
4	/tmp/NsCDE-2.3/Makefile.am
4	/tmp/NsCDE-2.3/TODO
8	/tmp/NsCDE-2.3/README.localization
8	/tmp/NsCDE-2.3/README.md
16	/tmp/NsCDE-2.3/INSTALL.md
20	/tmp/NsCDE-2.3/configure.ac
24	/tmp/NsCDE-2.3/patches
24	/tmp/NsCDE-2.3/ReleaseNotes.txt
28	/tmp/NsCDE-2.3/Makefile.in
32	/tmp/NsCDE-2.3/bin
32	/tmp/NsCDE-2.3/ChangeLog
36	/tmp/NsCDE-2.3/COPYING
52	/tmp/NsCDE-2.3/aclocal.m4
76	/tmp/NsCDE-2.3/pkg
140	/tmp/NsCDE-2.3/ac-aux
176	/tmp/NsCDE-2.3/po
244	/tmp/NsCDE-2.3/configure
328	/tmp/NsCDE-2.3/NsCDE.png
496	/tmp/NsCDE-2.3/src
556	/tmp/NsCDE-2.3/nscde_tools
920	/tmp/NsCDE-2.3/autom4te.cache
952	/tmp/NsCDE-2.3/lib
5860	/tmp/NsCDE-2.3/doc
14016	/tmp/NsCDE-2.3/xdg
48712	/tmp/NsCDE-2.3/data
$ du -s /tmp/NsCDE-2.3/xdg/*|sort -k1 -n
4	/tmp/NsCDE-2.3/xdg/Makefile.am
8	/tmp/NsCDE-2.3/xdg/xsessions
16	/tmp/NsCDE-2.3/xdg/Makefile.in
16	/tmp/NsCDE-2.3/xdg/menus
84	/tmp/NsCDE-2.3/xdg/applications
96	/tmp/NsCDE-2.3/xdg/desktop-directories
13788	/tmp/NsCDE-2.3/xdg/icons
$ du -s /tmp/NsCDE-2.3/data/*|sort -k1 -n
4	/tmp/NsCDE-2.3/data/Makefile.am
16	/tmp/NsCDE-2.3/data/help
20	/tmp/NsCDE-2.3/data/Makefile.in
84	/tmp/NsCDE-2.3/data/fontsets
312	/tmp/NsCDE-2.3/data/palettes
316	/tmp/NsCDE-2.3/data/defaults
408	/tmp/NsCDE-2.3/data/fvwm
1092	/tmp/NsCDE-2.3/data/fallback
1672	/tmp/NsCDE-2.3/data/config_templates
4800	/tmp/NsCDE-2.3/data/integration
4968	/tmp/NsCDE-2.3/data/icons
14968	/tmp/NsCDE-2.3/data/photos
20048	/tmp/NsCDE-2.3/data/backdrops
--8<---------------cut here---------------end--------------->8---

That is, there’s roughly 1 MiB of code for more than 50 MiB of images.

Is GPLv3 really meant to apply to those images?  It might be the intent,
but that would be a dubious choice since it’s a software license.

So I think it would be worth checking with upstream the provenance and
licensing of all the artwork here.

WDYT?

Thanks,
Ludo’.
Andy Tai July 10, 2023, 9:49 p.m. UTC | #2 
Ok, sure.   I did not check these.

On Mon, Jul 10, 2023, 2:14 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> Andy Tai <atai@atai.org> skribis:
>
> > * gnu/packages/fvwm.scm (nscde): New variable
>
> [...]
>
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "https://github.com/NsCDE/NsCDE/releases/download/"
> > +                    version "/NsCDE-" version ".tar.gz"))
>
> Upon closer inspection, I noticed an unexpected size distribution:
>
> --8<---------------cut here---------------start------------->8---
> $ du -s /tmp/NsCDE-2.3/*|sort -k1 -n
> 0       /tmp/NsCDE-2.3/LICENSE
> 4       /tmp/NsCDE-2.3/autogen.sh
> 4       /tmp/NsCDE-2.3/Makefile.am
> 4       /tmp/NsCDE-2.3/TODO
> 8       /tmp/NsCDE-2.3/README.localization
> 8       /tmp/NsCDE-2.3/README.md
> 16      /tmp/NsCDE-2.3/INSTALL.md
> 20      /tmp/NsCDE-2.3/configure.ac
> 24      /tmp/NsCDE-2.3/patches
> 24      /tmp/NsCDE-2.3/ReleaseNotes.txt
> 28      /tmp/NsCDE-2.3/Makefile.in
> 32      /tmp/NsCDE-2.3/bin
> 32      /tmp/NsCDE-2.3/ChangeLog
> 36      /tmp/NsCDE-2.3/COPYING
> 52      /tmp/NsCDE-2.3/aclocal.m4
> 76      /tmp/NsCDE-2.3/pkg
> 140     /tmp/NsCDE-2.3/ac-aux
> 176     /tmp/NsCDE-2.3/po
> 244     /tmp/NsCDE-2.3/configure
> 328     /tmp/NsCDE-2.3/NsCDE.png
> 496     /tmp/NsCDE-2.3/src
> 556     /tmp/NsCDE-2.3/nscde_tools
> 920     /tmp/NsCDE-2.3/autom4te.cache
> 952     /tmp/NsCDE-2.3/lib
> 5860    /tmp/NsCDE-2.3/doc
> 14016   /tmp/NsCDE-2.3/xdg
> 48712   /tmp/NsCDE-2.3/data
> $ du -s /tmp/NsCDE-2.3/xdg/*|sort -k1 -n
> 4       /tmp/NsCDE-2.3/xdg/Makefile.am
> 8       /tmp/NsCDE-2.3/xdg/xsessions
> 16      /tmp/NsCDE-2.3/xdg/Makefile.in
> 16      /tmp/NsCDE-2.3/xdg/menus
> 84      /tmp/NsCDE-2.3/xdg/applications
> 96      /tmp/NsCDE-2.3/xdg/desktop-directories
> 13788   /tmp/NsCDE-2.3/xdg/icons
> $ du -s /tmp/NsCDE-2.3/data/*|sort -k1 -n
> 4       /tmp/NsCDE-2.3/data/Makefile.am
> 16      /tmp/NsCDE-2.3/data/help
> 20      /tmp/NsCDE-2.3/data/Makefile.in
> 84      /tmp/NsCDE-2.3/data/fontsets
> 312     /tmp/NsCDE-2.3/data/palettes
> 316     /tmp/NsCDE-2.3/data/defaults
> 408     /tmp/NsCDE-2.3/data/fvwm
> 1092    /tmp/NsCDE-2.3/data/fallback
> 1672    /tmp/NsCDE-2.3/data/config_templates
> 4800    /tmp/NsCDE-2.3/data/integration
> 4968    /tmp/NsCDE-2.3/data/icons
> 14968   /tmp/NsCDE-2.3/data/photos
> 20048   /tmp/NsCDE-2.3/data/backdrops
> --8<---------------cut here---------------end--------------->8---
>
> That is, there’s roughly 1 MiB of code for more than 50 MiB of images.
>
> Is GPLv3 really meant to apply to those images?  It might be the intent,
> but that would be a dubious choice since it’s a software license.
>
> So I think it would be worth checking with upstream the provenance and
> licensing of all the artwork here.
>
> WDYT?
>
> Thanks,
> Ludo’.
>
Ludovic Courtès Sept. 14, 2023, 9:18 p.m. UTC | #3 
Hi,

Andy Tai <atai@atai.org> skribis:

> Ok, sure.   I did not check these.

That was in reply to:

>> That is, there’s roughly 1 MiB of code for more than 50 MiB of images.
>>
>> Is GPLv3 really meant to apply to those images?  It might be the intent,
>> but that would be a dubious choice since it’s a software license.
>>
>> So I think it would be worth checking with upstream the provenance and
>> licensing of all the artwork here.
>>
>> WDYT?

Did you have a chance to check with upstream?  What should we do?

TIA,
Ludo’.
Andy Tai Sept. 14, 2023, 9:20 p.m. UTC | #4 
OK, I will abandon the patch. Too big a size may mean not worth adding to
Guix.

On Thu, Sep 14, 2023 at 2:18 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> Andy Tai <atai@atai.org> skribis:
>
> > Ok, sure.   I did not check these.
>
> That was in reply to:
>
> >> That is, there’s roughly 1 MiB of code for more than 50 MiB of images.
> >>
> >> Is GPLv3 really meant to apply to those images?  It might be the intent,
> >> but that would be a dubious choice since it’s a software license.
> >>
> >> So I think it would be worth checking with upstream the provenance and
> >> licensing of all the artwork here.
> >>
> >> WDYT?
>
> Did you have a chance to check with upstream?  What should we do?
>
> TIA,
> Ludo’.
>
diff mbox series

Patch

diff --git a/gnu/packages/fvwm.scm b/gnu/packages/fvwm.scm
index 872810c658..6bda61b6d6 100644
--- a/gnu/packages/fvwm.scm
+++ b/gnu/packages/fvwm.scm
@@ -3,6 +3,7 @@ 
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2017 Nikita <nikita@n0.is>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2023 Andy Tai <atai@atai.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -20,17 +21,30 @@ 
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages fvwm)
-  #:use-module ((guix licenses) #:select (gpl2+))
+  #:use-module ((guix licenses) #:select (gpl2+ gpl3))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (gnu packages compton)
+  #:use-module (gnu packages dunst)
+  #:use-module (gnu packages fonts)
   #:use-module (gnu packages fribidi)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gkrellm)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
+  #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages qt)
   #:use-module (gnu packages readline)
+  #:use-module (gnu packages shells)
+  #:use-module (gnu packages stalonetray)
   #:use-module (gnu packages xml)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg))
 
 (define-public fvwm
@@ -81,3 +95,57 @@  (define-public fvwm
 window manager for the X Window system.")
     (home-page "https://www.fvwm.org/")
     (license gpl2+)))
+
+(define-public nscde
+  (package
+    (name "nscde")
+    (version "2.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/NsCDE/NsCDE/releases/download/"
+                    version "/NsCDE-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1bm607dvqfdc3ir7l1aswfsfyb2la7rgp0g3023b9v2iksaal5mr"))))
+    (build-system gnu-build-system)
+    (native-inputs (list pkg-config mksh))
+    (inputs (list gettext-minimal
+                  fvwm
+                  font-dejavu
+                  fribidi
+                  dunst
+                  gkrellm
+                  gtk+
+                  imagemagick
+                  libxpm
+                  libxext
+                  libxft
+                  libxt
+                  rofi
+                  picom
+                  python
+                  python-pyyaml
+                  python-qtpy
+                  stalonetray
+                  xclip
+                  xdpyinfo
+                  xorg-rgb
+                  xprop
+                  xrefresh
+                  xscreensaver
+                  xset
+                  xsettingsd
+                  xterm))
+    (synopsis "Modern and functional CDE desktop based on FVWM")
+    (description "NsCDE or Not so Common Desktop Environment is a retro but
+powerful UNIX desktop environment which resembles the CDE look (and partially
+feel) but with a more powerful and flexible framework beneath-the-surface,
+more suited for 21st century unix-like and GNU/Linux systems and user requirements
+than original CDE.  NsCDE is a heavyweight FVWM theme on steroids, but combined
+with a couple other free software components and custom FVWM applications and
+a lot of configuration,  NsCDE can be considered a lightweight hybrid desktop
+environment")
+    (home-page "https://github.com/NsCDE/NsCDE")
+    (license gpl3)))
+