From patchwork Tue Feb 23 18:56:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 27213 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 877BB27BC4B; Tue, 23 Feb 2021 18:57:09 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 486B627BC4A for ; Tue, 23 Feb 2021 18:57:09 +0000 (GMT) Received: from localhost ([::1]:41956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEcrs-00059D-3O for patchwork@mira.cbaines.net; Tue, 23 Feb 2021 13:57:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEcrm-000593-Jy for guix-patches@gnu.org; Tue, 23 Feb 2021 13:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEcrm-0004Ne-Cf for guix-patches@gnu.org; Tue, 23 Feb 2021 13:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEcrm-0003N8-BR for guix-patches@gnu.org; Tue, 23 Feb 2021 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46680] [PATCH] gnu: Add midicomp. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Feb 2021 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46680 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 46680@debbugs.gnu.org Received: via spool by 46680-submit@debbugs.gnu.org id=B46680.161410658412914 (code B ref 46680); Tue, 23 Feb 2021 18:57:02 +0000 Received: (at 46680) by debbugs.gnu.org; 23 Feb 2021 18:56:24 +0000 Received: from localhost ([127.0.0.1]:60503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEcrA-0003MD-5R for submit@debbugs.gnu.org; Tue, 23 Feb 2021 13:56:24 -0500 Received: from mout01.posteo.de ([185.67.36.141]:52936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEcr7-0003M0-TA for 46680@debbugs.gnu.org; Tue, 23 Feb 2021 13:56:22 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4D5AB160063 for <46680@debbugs.gnu.org>; Tue, 23 Feb 2021 19:56:15 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DlSv23LnWz9rxT; Tue, 23 Feb 2021 19:56:14 +0100 (CET) Message-ID: <721dc0ef8b515ad8f62deecb7a8549868183fcff.camel@zrythm.org> From: Alexandros Theodotou Date: Tue, 23 Feb 2021 18:56:13 +0000 In-Reply-To: <87im6iy8va.fsf@nicolasgoaziou.fr> References: <20210221102137.22967-1-alex@zrythm.org> <87im6iy8va.fsf@nicolasgoaziou.fr> User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, Thanks for the feedback, I updated the patch (attached). I saw the conversation on IRC and I believe we should take the word of the author if it's explicitly mentioned in the README. >I think there is an issue here. The repository has no LICENSE file, > and > source code files have no license header. The only reference to > AGPL3.0 > is in the README.md. I'm not sure this is sufficient. Thanks, Alex From 2434b06388935f50bb67c15fc7e1264f0e8bc9f9 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Tue, 23 Feb 2021 18:51:05 +0000 Subject: [PATCH] gnu: Add midicomp. * gnu/packages/audio.scm (midicomp): New variable. --- gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 16e0eec418..372c056d16 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -1223,6 +1223,37 @@ object library.") language and software synthesizer.") (license license:lgpl2.1+))) +(define-public midicomp + ;; The latest tagged release is 9 years old and there have been + ;; unreleased fixes, so we take the last commit. + (let ((commit "70f76963cb0cdb3cbe03ec6e7246b1fb885d3c68") + (revision "1")) + (package + (name "midicomp") + (version (git-version "0.0.8-" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/markc/midicomp") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "12zh247c6v88ssy4l8v7yirh4bl2jcc1ch7f4gdry79a82kai1gf")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f)) ; no "check" target + (synopsis "Convert SMF MIDI files to and from plain text") + (description + "midicomp can manipulate SMF (Standard MIDI File) files. It can both + read and write SMF files in 0 or format 1 and also read and write its own + plain text format. This means a SMF file can be turned into easily + parseable text, edited with any text editor or filtered through any script + language, and recompiled back into a binary SMF file.") + (home-page "https://github.com/markc/midicomp") + (license license:agpl3)))) + (define-public clalsadrv (package (name "clalsadrv") -- 2.30.1