From patchwork Mon Jun 5 12:34:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nicolas Graves X-Patchwork-Id: 50688 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 287D627BBE9; Mon, 5 Jun 2023 13:35:40 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5CC1327BBE2 for ; Mon, 5 Jun 2023 13:35:38 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q69QN-0005OC-MJ; Mon, 05 Jun 2023 08:35:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q69QM-0005Nn-Lb for guix-patches@gnu.org; Mon, 05 Jun 2023 08:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q69QM-0003LM-BT for guix-patches@gnu.org; Mon, 05 Jun 2023 08:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q69QM-0003mx-7Y for guix-patches@gnu.org; Mon, 05 Jun 2023 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62461] [PATCH v3 1/4] gnu: home-openssh-configuration: Add field add-keys-to-agent. References: <87bkkfaa2x.fsf@ngraves.fr> In-Reply-To: <87bkkfaa2x.fsf@ngraves.fr> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jun 2023 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62461 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62461@debbugs.gnu.org Cc: ngraves@ngraves.fr Received: via spool by 62461-submit@debbugs.gnu.org id=B62461.168596849814530 (code B ref 62461); Mon, 05 Jun 2023 12:35:02 +0000 Received: (at 62461) by debbugs.gnu.org; 5 Jun 2023 12:34:58 +0000 Received: from localhost ([127.0.0.1]:48372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q69QI-0003mD-0Q for submit@debbugs.gnu.org; Mon, 05 Jun 2023 08:34:58 -0400 Received: from 2.mo583.mail-out.ovh.net ([178.33.109.111]:34307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q69QE-0003le-6v for 62461@debbugs.gnu.org; Mon, 05 Jun 2023 08:34:55 -0400 Received: from director8.ghost.mail-out.ovh.net (unknown [10.109.146.240]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 3EC1027F08 for <62461@debbugs.gnu.org>; Mon, 5 Jun 2023 12:34:52 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-zv2bm (unknown [10.110.103.36]) by director8.ghost.mail-out.ovh.net (Postfix) with ESMTPS id C2B761FEC7; Mon, 5 Jun 2023 12:34:51 +0000 (UTC) Received: from ngraves.fr ([37.59.142.96]) by ghost-submission-6684bf9d7b-zv2bm with ESMTPSA id 7f95KWvWfWQOGQAAzuo5lw (envelope-from ); Mon, 05 Jun 2023 12:34:51 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-96R001e830973b-8155-400c-8fd3-f2263fd004a0, 24BD45A8C995C08D5395E1BF3FBF1E19C8C2E420) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.140.142 Date: Mon, 5 Jun 2023 14:34:45 +0200 Message-Id: <6e0836e1ad23b625b912f2aa0893c2c0b1f4e37c.1685968477.git.ngraves@ngraves.fr> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Ovh-Tracer-Id: 15450724424086971106 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelledgheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeetveehffevvdfgtddthedvhfeguefggeffteetueeliedvhffhjeegudehleegheenucfkphepuddvjedrtddrtddruddpkedurdeijedrudegtddrudegvddpfeejrdehledrudegvddrleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeivdegieduseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeefpdhmohguvgepshhmthhpohhuth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches X-Patchwork-Original-From: Nicolas Graves via Guix-patches via From: Nicolas Graves Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches --- doc/guix.texi | 14 ++++++++++++ gnu/home/services/ssh.scm | 48 +++++++++++++++++++++++++++++++-------- 2 files changed, 53 insertions(+), 9 deletions(-) base-commit: eed55a6544d5bda2245ec853e5fa4b28e1865bea prerequisite-patch-id: a057b35ab55298bad50caab186b3e692a25230e1 prerequisite-patch-id: fb9054f780e6f97b92f00fdbe56058d1188ccf0a prerequisite-patch-id: ca2f2591980b80c5cf27846e59e323bdc5a06b00 prerequisite-patch-id: ae5ad13b181ebb3c31d529af50622e3b78641442 prerequisite-patch-id: 34ed6acb0a1e5f79b5f6d18a6d4ef70cd97bf7ad prerequisite-patch-id: 10d52b209b6e9c771050eef67ce566e79ab55c49 prerequisite-patch-id: e78e2a6daf59564caf5d2affe04ea7dde07f76c6 prerequisite-patch-id: 6aad4df7b83bfd5c2da38d9c2f80fba749f607b5 prerequisite-patch-id: da6a2d63ebb0ba1abb0b7c569d353724d900f95f prerequisite-patch-id: 6279cff75e76e262f6ec82518db1fdf4c1810303 prerequisite-patch-id: 44453fcf2f2c38212a47d45d43ddcfa98167fabe prerequisite-patch-id: 641eae2fa3842045ebe6072ad78214002f818221 prerequisite-patch-id: c19de9ee8c57210cbffc79945e69a858639f39bf prerequisite-patch-id: 9833a747398a641803e203f8293382f55ad24ed1 prerequisite-patch-id: 94d5340918e3626726b6d32d93bf47425751898f prerequisite-patch-id: e18164416e2c070b0b71f770c90d4c04af2635c1 prerequisite-patch-id: 31e98ea035053a965e87ad0164030cf909922d9e prerequisite-patch-id: a1cf1f5c4a0ff2804fac986a69ffbc0328300afe prerequisite-patch-id: 2a54e276f79fb57113a0be11e1ea2c07fdc2727d prerequisite-patch-id: a463de1ba17ecb39588dfbd46c3bc5f9e0fb1b1c prerequisite-patch-id: 3188de66dfc4bcb71f90601822428701528f4a98 prerequisite-patch-id: 6c93f771a1eca0747fd92a770fe750e2f15d8e52 prerequisite-patch-id: 12b76e9c2751da73ed64c9489b15f74ff17568cf prerequisite-patch-id: eb618ab7b10483d917c308a38792af98baa517e2 prerequisite-patch-id: a471a4b7839bfb0ee9a3fd53ed962d729d38bd94 prerequisite-patch-id: 5e58202cc87a257c78033dafa62ffae4383e3718 prerequisite-patch-id: cd7f69695aa47b7e1b1160841fe842a3acd160e7 prerequisite-patch-id: b542cf4087eeee1ee3f7fc03b7c39896417bc7b5 prerequisite-patch-id: 843773f53ca319821185f9f9bc43ad905f081ee7 prerequisite-patch-id: a2dfb2fba1e1a3c8e270823022b6f462d27f17c8 diff --git a/doc/guix.texi b/doc/guix.texi index f620d0eb35..d5f81f6fcd 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -43102,6 +43102,20 @@ Secure Shell running on this machine, then it @emph{may} take this file into account: this is what @command{sshd} does by default, but be aware that it can also be configured to ignore it. + +@item @code{add-keys-to-agent} (default: @code{``no''}) +This string specifies whether keys should be automatically added to a +running ssh-agent. If this option is set to @code{``yes''} and a key is +loaded from a file, the key and its passphrase are added to the agent +with the default lifetime, as if by @code{ssh-add}. If this option is +set to @code{``ask''}, @code{ssh} will require confirmation. If this +option is set to @code{``confirm''}, each use of the key must be +confirmed. If this option is set to @code{``no''}, no keys are added to +the agent. Alternately, this option may be specified as a time interval +to specify the key's lifetime in @code{ssh-agent}, after which it will +automatically be removed. The argument must be @code{``no''}, +@code{``yes''}, @code{``confirm''} (optionally followed by a time +interval), @code{``ask''} or a time interval. @end table @end deftp diff --git a/gnu/home/services/ssh.scm b/gnu/home/services/ssh.scm index 628dc743ae..2de78eb1c4 100644 --- a/gnu/home/services/ssh.scm +++ b/gnu/home/services/ssh.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2022 Ludovic Courtès ;;; Copyright © 2023 Janneke Nieuwenhuizen +;;; Copyright © 2023 Nicolas Graves ;;; ;;; This file is part of GNU Guix. ;;; @@ -42,6 +43,7 @@ (define-module (gnu home services ssh) home-openssh-configuration-authorized-keys home-openssh-configuration-known-hosts home-openssh-configuration-hosts + home-openssh-configuration-add-keys-to-agent home-ssh-agent-configuration openssh-host @@ -248,17 +250,45 @@ (define (serialize-openssh-host config) (define-record-type* home-openssh-configuration make-home-openssh-configuration home-openssh-configuration? - (authorized-keys home-openssh-configuration-authorized-keys ;list of file-like - (default #f)) - (known-hosts home-openssh-configuration-known-hosts ;unspec | list of file-like - (default *unspecified*)) - (hosts home-openssh-configuration-hosts ;list of - (default '()))) + (authorized-keys home-openssh-configuration-authorized-keys ;list of file-like + (default #f)) + (known-hosts home-openssh-configuration-known-hosts ;unspec | list of file-like + (default *unspecified*)) + (hosts home-openssh-configuration-hosts ;list of + (default '())) + (add-keys-to-agent home-openssh-configuration-add-keys-to-agent ;string with limited values + (default "no"))) + +(define (serialize-add-keys-to-agent value) + (define (valid-time-string? str) + (and (> (string-length str) 0) + (equal? + str + (match:substring + (string-match "\ +[0-9]+|([0-9]+[Ww])?([0-9]+[Dd])?([0-9]+[Hh])?([0-9]+[Mm])?([0-9]+[Ss])?" + str))))) + + (string-append "AddKeysToAgent " + (cond ((member value '("yes" "no" "confirm" "ask")) value) + ((valid-time-string? value) value) + ((and (string-prefix? "confirm" value) + (valid-time-string? + (cdr (string-split value #\ )))) value) + ;; The 'else' branch is unreachable. + (else + (raise + (formatted-message + (G_ "~s: invalid 'add-keys-to-agent' value") + value)))))) (define (openssh-configuration->string config) - (string-join (map serialize-openssh-host - (home-openssh-configuration-hosts config)) - "\n")) + (string-join + (cons* (serialize-add-keys-to-agent + (home-openssh-configuration-add-keys-to-agent config)) + (map serialize-openssh-host + (home-openssh-configuration-hosts config))) + "\n")) (define* (file-join name files #:optional (delimiter " ")) "Return a file in the store called @var{name} that is the concatenation