mbox

[bug#46053,0/2] Add Ren'py build system

Message ID 6bf051d15833939d09f190d11cdbbf7954fdc3c0.camel@student.tugraz.at
Headers show

Message

Leo Prikler Jan. 23, 2021, 1:40 p.m. UTC 
Hi Guix,

a proper Ren'py build system had been on my TODO list ever since I've
packaged it back in 2019, but I've so far been too lazy to actually
create one.  While I'm happy to announce, that this is no longer the
case, there are still a number of things, that can be improved in our
Ren'py package and build system.

This series contains two patches.  The first adds the build system, the
second a package example for "The Question".  Since "The Question" is
already an output of Ren'py, I don't see much value in this patch other
than for explanatory purposes, so I don't think I'll commit that one. 
Instead, I'll probably redefine Ren'py once the first patch is merged.
I'm building this series on top of #45736, so things might be a bit
different on master, but I hope it works out regardless.

Regards,
Leo

Comments

Nicolas Goaziou Jan. 24, 2021, 8:49 a.m. UTC | #1 
Hello,

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> a proper Ren'py build system had been on my TODO list ever since I've
> packaged it back in 2019, but I've so far been too lazy to actually
> create one.  While I'm happy to announce, that this is no longer the
> case, there are still a number of things, that can be improved in our
> Ren'py package and build system.

That's nice. It should also be documented in the manual.

It would be nice to have a "write a build system" in the cookbook (or
the manual?) at some point.

> This series contains two patches.  The first adds the build system, the
> second a package example for "The Question".  Since "The Question" is
> already an output of Ren'py, I don't see much value in this patch other
> than for explanatory purposes, so I don't think I'll commit that one. 
> Instead, I'll probably redefine Ren'py once the first patch is merged.
> I'm building this series on top of #45736, so things might be a bit
> different on master, but I hope it works out regardless.

LGTM, in addition to #45736.

Regards,
Leo Prikler Feb. 7, 2021, 2:29 p.m. UTC | #2 
Hello,

Am Sonntag, den 24.01.2021, 09:49 +0100 schrieb Nicolas Goaziou:
> LGTM, in addition to #45736.
I've now pushed both this (well, v2 of it) and #45736.

> It should also be documented in the manual.
Documentation is present in v2, which I've pushed.  I hope it's
sufficient.

Regards,
Leo.