diff mbox series

[bug#69570,1/1] gnu: cl-osc: update to 0.9.

Message ID 6ab4f387544ba7f88d2f1c8e1d961dace85165b9.1709657761.git.nik@fo.am
State New
Headers show
Series [bug#69570,1/1] gnu: cl-osc: update to 0.9. | expand

Commit Message

nik gaffney March 5, 2024, 5:14 p.m. UTC 
* gnu/packages/lisp-xyz.scm (sbcl-osc): Update to 0.9.

Change-Id: Iba92207d845101a1c6e57d3676e7bd177127c192
---
 gnu/packages/lisp-xyz.scm | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)


base-commit: b6dec0108f99d75066bad15aaa124b84bb0261f3

Comments

Paul A. Patience March 7, 2024, 9:26 a.m. UTC | #1 
Hello,

Just a quick comment on style.

The CL package style is slowly migrating from

  (file-name (git-file-name name version)

to

  (file-name (git-file-name "cl-NAME" version))

so your change to file-name is undesirable.

Best regards,
Paul
nik gaffney March 7, 2024, 1:31 p.m. UTC | #2 
> Just a quick comment on style.
> 
> The CL package style is slowly migrating from
> 
>   (file-name (git-file-name name version)
> 
> to
> 
>   (file-name (git-file-name "cl-NAME" version))
> 
> so your change to file-name is undesirable.

No problem. I wasn't aware of the convention, so please change as desirable.
Guillaume Le Vaillant March 8, 2024, 9:22 a.m. UTC | #3 
Patch applied as 867eb0cfb9cce30b49b309c71f02be4cd5f51c28 with a few
modifications.
Thanks.
diff mbox series

Patch

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 6ee8ef22d2..330fbb94eb 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -43,6 +43,7 @@ 
 ;;; Copyright © 2023 Raven Hallsby <karl@hallsby.com>
 ;;; Copyright © 2024 Michal Atlas <michal_atlas+git@posteo.net>
 ;;; Copyright © 2024 Carlo Zancanaro <carlo@zancanaro.id.au>
+;;; Copyright © 2024 nik gaffney <nik@fo.am>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25694,29 +25695,26 @@  (define-public ecl-cl-collider
   (sbcl-package->ecl-package sbcl-cl-collider))
 
 (define-public sbcl-osc
-  (let ((commit "9f0a9d3da310a3a0f654f48af0203816f3f371ad")
+  (let ((commit "f647738ccc22925ed740a8ca9132fda76a05baeb")
         (revision "0"))
     (package
      (name "sbcl-osc")
-     (version (git-version "0.7" revision commit))
+     (version (git-version "0.9" revision commit))
      (source
        (origin
          (method git-fetch)
          (uri (git-reference
                (url "https://github.com/zzkt/osc")
                (commit commit)))
-         (file-name (git-file-name "cl-osc" version))
+         (file-name (git-file-name "osc" version))
          (sha256
-          (base32 "0gh29zcl9pmy3xlmwzpf9www2z06ah6b4jk06sj2cvxbc15nblqa"))))
+          (base32 "1x4cavspaxcr604g0hwak1ncy4m9cqq03ji4v56g2h1443n7h48a"))))
      (build-system asdf-build-system/sbcl)
-     (inputs (list sbcl-usocket))
+     (inputs (list sbcl-ieee-floats))
      (synopsis "Implementation of the Open Sound Control protocol")
-     (description "This package provides a common lisp implementation
-of the Open Sound Control Protocol aka OSC.  The code should be close
-to the ansi standard, and does not rely on any external code/ffi/etc+
-to do the basic encoding and decoding of packets.")
+     (description  "This is a lisp implementation of the Open Sound Control protocol (or more accurately “data transport specification” or “encoding”). The code should be close to ANSI standard common lisp and provides self contained code for encoding and decoding of OSC data, messages, and bundles.")
      (home-page "https://github.com/zzkt/osc/")
-     (license (list license:gpl3 license:llgpl)))))
+     (license (list license:gpl3+)))))
 
 (define-public cl-osc
   (sbcl-package->cl-source-package sbcl-osc))