From patchwork Sun Apr 27 21:05:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rutherther X-Patchwork-Id: 42089 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1CA1727BC49; Sun, 27 Apr 2025 22:14:45 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E9FB227BC4A for ; Sun, 27 Apr 2025 22:14:42 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u99KG-0008LA-Vw; Sun, 27 Apr 2025 17:14:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u99KF-0008Kt-IJ for guix-patches@gnu.org; Sun, 27 Apr 2025 17:14:11 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u99KE-0000fS-Eo; Sun, 27 Apr 2025 17:14:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=UQ2aQfL+2vLBqL82bcq+/Wl9lVwRtNYakmTPLdAlQXc=; b=oZLQyhND5myjwgY4oz7kb1e2QPauIIT9deVTA0AYaTxfau7mRqkaKzZjcBnJyWIwj09SjAoonO3ZLXUqO/J35Sycjdq+gTYdNhALZRN/VHSqGGxd8CECAgCn5nociozQ4FKqk4qDr2pcKtPW4bFLpwAb9KYDFZBhzZkhXztOHHSobTwCUp3GNsPRzXcEJvLYHF3DvMWfGxvgahyiMJ9oeQFmQswTVwx8siDMm2bl4wN7+fMn0TwsPbpvuV0nLlFlukkUsj3lsprozfgZdVQR19tGd1NdReeF33/eifnloULa8f8EcavB42PFwMxaFpadTZLQdbfyTDG5ntAoRdKQJA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1u99K5-00055A-V0; Sun, 27 Apr 2025 17:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if no icons Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, liliana.prikler@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Sun, 27 Apr 2025 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78100 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 78100@debbugs.gnu.org Cc: Rutherther , Christopher Baines , Josselin Poiret , Ludovic =?utf-8?b?Q291cnTDg8Kocw==?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice , Liliana Marie Prikler , X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?b?Q291cnTDg8Kocw==?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice , Liliana Marie Prikler , Received: via spool by submit@debbugs.gnu.org id=B.174578838419391 (code B ref -1); Sun, 27 Apr 2025 21:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2025 21:13:04 +0000 Received: from localhost ([127.0.0.1]:45314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u99J9-00052h-Hn for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u99J6-000520-VL for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u99Ix-0008DJ-Ep for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1u99Iv-0000YB-UJ for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id 30bbc8ef (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 27 Apr 2025 21:12:43 +0000 (UTC) Date: Sun, 27 Apr 2025 23:05:25 +0200 Message-ID: <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1745788363; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=GoNckcE0Sw72NR4lZYw1IDc+WRCNDaJHGipu7aWBnMc=; b=XsiZaisedEbyf/E+WOaya7J3NHvjsRoDZXJfKar9jnj772MftnYhRimtLMOuxuhs/7eqq xeVK91unKUxmKwz3s0+yurKyJmV/irq7WvW2ZdkL28KuS7fJVhDiUZ772N20C6iQsikXcxd vnZerItUsHvcSaWpP7lngBEKVX9K340= Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::; envelope-from=rutherther@ditigal.xyz; helo=mail.ditigal.xyz X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Rutherther X-ACL-Warn: , Rutherther via Guix-patches X-Patchwork-Original-From: Rutherther via Guix-patches via From: Rutherther Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches When there are no icon themes, but gtk+ is referenced in the manifest, the output won't be produced in the gtk-icon-themes derivation. This will lead to an error. The problem has been reported by lilyp on IRC. I can't find any packages in Guix that use gtk+ in inputs and don't have any icons, but this low-effort package replicates the issue: ``` (package (inherit bash) (inputs (modify-inputs (package-inputs bash) (append gtk+)))) ``` * guix/profiles.scm (gtk-icon-themes): Produce output when no icon cache is created. Change-Id: I2aa5ab0023c9c584182c67f79102fb66b46a3a7d --- guix/profiles.scm | 3 +++ 1 file changed, 3 insertions(+) base-commit: 4e79ec48af8173f0f2a86fa2c8f971dc8234b941 diff --git a/guix/profiles.scm b/guix/profiles.scm index 64d669c353..086280329e 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -1379,6 +1379,9 @@ (define* (gtk-icon-themes manifest #:optional system) (srfi srfi-26) (ice-9 ftw)) + ;; Ensure output is produced when no cache files are created. + (mkdir-p #$output) + (let* ((destdir (string-append #$output "/share/icons")) (icondirs (filter file-exists? (map (cut string-append <> "/share/icons")