Message ID | 696e1a46af20d62029c36f5e2ad2c2ff22c0485f.1702995464.git.hako@ultrarare.space |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0191227BBE9; Tue, 19 Dec 2023 14:23:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5EA1927BBE2 for <patchwork@mira.cbaines.net>; Tue, 19 Dec 2023 14:23:17 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1rFazu-0005rv-I1; Tue, 19 Dec 2023 09:23:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rFazt-0005rf-Cr for guix-patches@gnu.org; Tue, 19 Dec 2023 09:23:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rFazt-0008UW-5C for guix-patches@gnu.org; Tue, 19 Dec 2023 09:23:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rFazu-0007ZD-JD; Tue, 19 Dec 2023 09:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0. Resent-From: Hilton Chain <hako@ultrarare.space> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: leo@famulari.name, me@tobias.gr, guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2023 14:23:02 +0000 Resent-Message-ID: <handler.67903.B.170299572629018@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67903 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67903@debbugs.gnu.org Cc: Hilton Chain <hako@ultrarare.space>, Leo Famulari <leo@famulari.name>, Tobias Geerinckx-Rice <me@tobias.gr> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Leo Famulari <leo@famulari.name>, Tobias Geerinckx-Rice <me@tobias.gr> Received: via spool by submit@debbugs.gnu.org id=B.170299572629018 (code B ref -1); Tue, 19 Dec 2023 14:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2023 14:22:06 +0000 Received: from localhost ([127.0.0.1]:35096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rFayz-0007Xx-Qv for submit@debbugs.gnu.org; Tue, 19 Dec 2023 09:22:06 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hako@ultrarare.space>) id 1rFayx-0007XT-FM for submit@debbugs.gnu.org; Tue, 19 Dec 2023 09:22:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <hako@ultrarare.space>) id 1rFaym-0005f1-Lk for guix-patches@gnu.org; Tue, 19 Dec 2023 09:21:53 -0500 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <hako@ultrarare.space>) id 1rFayl-0008Q3-3k for guix-patches@gnu.org; Tue, 19 Dec 2023 09:21:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1702995441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YEIZWYIsARwG7Plm6U4Y/XJBHr5tzIk7Oxu/O79ohhk=; b=Znl380gP499tHHqVU3+WDbsDhiqFORWgbwKdkOyfBS+9VgyHSImppsuRk1fa8/p227+0a4 BnvzRdh2p15P5DfbLpqjujatWIS/0WnUqTZ5A6VVv/WnZn/cRnp++V6x2rgPgEZWR0vIYe CQlpDXsxd9CesgTk0H+mqjMhYAtZvjHfLMP1AqQX4EPGQcDVpZ4fkINM3V5NVEs6P0gbI1 Ik2wAo1Y9RXSHoEaD4cfNHhwEYCH6+cOvhnwJ7sLpRjL4Dsr1dz5ALfDPl5npTg3DkJukf WJnxcBaYCKVt1sSQqCRR1eODD8UCjap5xLCdrhPsO/IYEBAJgcR5jQcuosKJxQ== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Date: Tue, 19 Dec 2023 22:21:36 +0800 Message-ID: <696e1a46af20d62029c36f5e2ad2c2ff22c0485f.1702995464.git.hako@ultrarare.space> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: + Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Hilton Chain <hako@ultrarare.space> X-ACL-Warn: , Hilton Chain via Guix-patches <guix-patches@gnu.org> From: Hilton Chain via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#67903] gnu: libcgroup: Update to 3.1.0.
|
|
Commit Message
Hilton Chain
Dec. 19, 2023, 2:21 p.m. UTC
* gnu/packages/linux.scm (libcgroup): Update to 3.1.0. [arguments]<#:configure-flags>: Disable systemd. Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 --- gnu/packages/linux.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
Comments
> 在 2023年12月19日,22:51,Hilton Chain via Guix-patches via <guix-patches@gnu.org> 写道: > > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0. > [arguments]<#:configure-flags>: Disable systemd. > > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 > --- > gnu/packages/linux.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 3ca756dead..c4c366e21f 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -8798,7 +8798,7 @@ (define-public fbgrab > (define-public libcgroup > (package > (name "libcgroup") > - (version "2.0.2") > + (version "3.1.0") > (home-page "https://github.com/libcgroup/libcgroup") > (source > (origin > @@ -8806,14 +8806,15 @@ (define-public libcgroup > (uri (string-append home-page "/releases/download/v" > version "/" name "-" version ".tar.gz")) Can we switch to git-fetch? And don’t use home-page in source. > (sha256 > - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) > + (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp")))) > (build-system gnu-build-system) > (arguments > ;; Tests are virtualized with lxc, it is not very feasible > ;; to make them executable under guix build. Also, note that > ;; origin is using source tarball release which is prepared > ;; after testing. > - `(#:tests? #f)) > + `(#:tests? #f > + #:configure-flags '("--disable-systemd"))) Maybe use gexp. > (native-inputs > (list bison flex)) > (inputs > > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66 > -- > 2.41.0 Other LGTM > > > >
Hi, On Sun, 24 Dec 2023 13:27:13 +0800, 郑俊杰 wrote: > > > > > 在 2023年12月19日,22:51,Hilton Chain via Guix-patches via <guix-patches@gnu.org> 写道: > > > > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0. > > [arguments]<#:configure-flags>: Disable systemd. > > > > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 > > --- > > gnu/packages/linux.scm | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > > index 3ca756dead..c4c366e21f 100644 > > --- a/gnu/packages/linux.scm > > +++ b/gnu/packages/linux.scm > > @@ -8798,7 +8798,7 @@ (define-public fbgrab > > (define-public libcgroup > > (package > > (name "libcgroup") > > - (version "2.0.2") > > + (version "3.1.0") > > (home-page "https://github.com/libcgroup/libcgroup") > > (source > > (origin > > @@ -8806,14 +8806,15 @@ (define-public libcgroup > > (uri (string-append home-page "/releases/download/v" > > version "/" name "-" version ".tar.gz")) > > Can we switch to git-fetch? Is there any good reason? > And don’t use home-page in source. No problem. > > (sha256 > > - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) > > + (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp")))) > > (build-system gnu-build-system) > > (arguments > > ;; Tests are virtualized with lxc, it is not very feasible > > ;; to make them executable under guix build. Also, note that > > ;; origin is using source tarball release which is prepared > > ;; after testing. > > - `(#:tests? #f)) > > + `(#:tests? #f > > + #:configure-flags '("--disable-systemd"))) > > Maybe use gexp. Will add in a later commit. > > (native-inputs > > (list bison flex)) > > (inputs > > > > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66 > > -- > > 2.41.0 > > Other LGTM Thanks for the review!
Hilton Chain <hako@ultrarare.space> writes: > Hi, > > On Sun, 24 Dec 2023 13:27:13 +0800, > 郑俊杰 wrote: >> >> >> >> > 在 2023年12月19日,22:51,Hilton Chain via Guix-patches via <guix-patches@gnu.org> 写道: >> > >> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0. >> > [arguments]<#:configure-flags>: Disable systemd. >> > >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 >> > --- >> > gnu/packages/linux.scm | 7 ++++--- >> > 1 file changed, 4 insertions(+), 3 deletions(-) >> > >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm >> > index 3ca756dead..c4c366e21f 100644 >> > --- a/gnu/packages/linux.scm >> > +++ b/gnu/packages/linux.scm >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab >> > (define-public libcgroup >> > (package >> > (name "libcgroup") >> > - (version "2.0.2") >> > + (version "3.1.0") >> > (home-page "https://github.com/libcgroup/libcgroup") >> > (source >> > (origin >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup >> > (uri (string-append home-page "/releases/download/v" >> > version "/" name "-" version ".tar.gz")) >> >> Can we switch to git-fetch? > > Is there any good reason? if use git-fetch, allow `guix build libcgroup --with-{branch,commit,git-url} ...` work. > >> And don’t use home-page in source. > > No problem. > >> > (sha256 >> > - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) >> > + (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp")))) >> > (build-system gnu-build-system) >> > (arguments >> > ;; Tests are virtualized with lxc, it is not very feasible >> > ;; to make them executable under guix build. Also, note that >> > ;; origin is using source tarball release which is prepared >> > ;; after testing. >> > - `(#:tests? #f)) >> > + `(#:tests? #f >> > + #:configure-flags '("--disable-systemd"))) >> >> Maybe use gexp. > > Will add in a later commit. > >> > (native-inputs >> > (list bison flex)) >> > (inputs >> > >> > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66 >> > -- >> > 2.41.0 >> >> Other LGTM > > Thanks for the review!
Hi, On Fri, 05 Jan 2024 13:45:36 +0800, Zheng Junjie wrote: > > Hilton Chain <hako@ultrarare.space> writes: > > > > On Sun, 24 Dec 2023 13:27:13 +0800, > > 郑俊杰 wrote: > >> > >> > 在 2023年12月19日,22:51,Hilton Chain 写道: > >> > > >> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0. > >> > [arguments]<#:configure-flags>: Disable systemd. > >> > > >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 > >> > --- > >> > gnu/packages/linux.scm | 7 ++++--- > >> > 1 file changed, 4 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > >> > index 3ca756dead..c4c366e21f 100644 > >> > --- a/gnu/packages/linux.scm > >> > +++ b/gnu/packages/linux.scm > >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab > >> > (define-public libcgroup > >> > (package > >> > (name "libcgroup") > >> > - (version "2.0.2") > >> > + (version "3.1.0") > >> > (home-page "https://github.com/libcgroup/libcgroup") > >> > (source > >> > (origin > >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup > >> > (uri (string-append home-page "/releases/download/v" > >> > version "/" name "-" version ".tar.gz")) > >> > >> Can we switch to git-fetch? > > > > Is there any good reason? > > if use git-fetch, allow `guix build libcgroup > --with-{branch,commit,git-url} ...` work. Yes, that makes sense, but we still have ‘--with-version’, right? It seems that libcgroup's release tarball is created by ‘make dist’ and for this specific case these options are of less use, I'd prefer not switching to git-fetch. Thanks
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 3ca756dead..c4c366e21f 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8798,7 +8798,7 @@ (define-public fbgrab (define-public libcgroup (package (name "libcgroup") - (version "2.0.2") + (version "3.1.0") (home-page "https://github.com/libcgroup/libcgroup") (source (origin @@ -8806,14 +8806,15 @@ (define-public libcgroup (uri (string-append home-page "/releases/download/v" version "/" name "-" version ".tar.gz")) (sha256 - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) + (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp")))) (build-system gnu-build-system) (arguments ;; Tests are virtualized with lxc, it is not very feasible ;; to make them executable under guix build. Also, note that ;; origin is using source tarball release which is prepared ;; after testing. - `(#:tests? #f)) + `(#:tests? #f + #:configure-flags '("--disable-systemd"))) (native-inputs (list bison flex)) (inputs