diff mbox series

[bug#65694] gnu: capypdf: Update to 0.5.0.

Message ID 648551d4a8f57360a49eaf6b90bd02efff186bcc.1693637587.git.liliana.prikler@gmail.com
State New
Headers show
Series [bug#65694] gnu: capypdf: Update to 0.5.0. | expand

Commit Message

Liliana Marie Prikler Sept. 2, 2023, 6:52 a.m. UTC 
* gnu/packages/pdf.scm (capypdf): Update to 0.5.0.
[arguments]<#:configure-flags>: Add “-Dcpp_std=c++23”
<#:phases>: Drop ‘add-missing-header’.
---
 gnu/packages/pdf.scm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)


base-commit: 9179775b0535ddf038d45f1355f759c4d6dc40dc

Comments

Maxim Cournoyer Sept. 5, 2023, 11:50 a.m. UTC | #1 
Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/pdf.scm (capypdf): Update to 0.5.0.
> [arguments]<#:configure-flags>: Add “-Dcpp_std=c++23”
> <#:phases>: Drop ‘add-missing-header’.
> ---
>  gnu/packages/pdf.scm | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index e270bdf27f..b71add6f25 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -117,7 +117,7 @@ (define-module (gnu packages pdf)
>  (define-public capypdf
>    (package
>      (name "capypdf")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -125,18 +125,14 @@ (define-public capypdf
>                      (commit version)))
>                (file-name (git-file-name name version))
>                (sha256
> -               (base32 "1kn46n3j5fygivmd6ldnv8vdwfv48ffaizq61yy4z9w2jm6fgxim"))))
> +               (base32 "1mb3i0jq04gg5cm1l07mn9kal5s748miql97j6fpaf1x1j2lcrsx"))))
>      (build-system meson-build-system)
>      (arguments
>       (list #:meson meson/newer
> +           #:configure-flags #~(list "-Dcpp_std=c++23")

The build fails otherwise?

LGTM otherwise!
Liliana Marie Prikler Sept. 5, 2023, 5:02 p.m. UTC | #2 
Am Dienstag, dem 05.09.2023 um 07:50 -0400 schrieb Maxim Cournoyer:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > * gnu/packages/pdf.scm (capypdf): Update to 0.5.0.
> > [arguments]<#:configure-flags>: Add “-Dcpp_std=c++23”
> > <#:phases>: Drop ‘add-missing-header’.
> > ---
> >  gnu/packages/pdf.scm | 10 +++-------
> >  1 file changed, 3 insertions(+), 7 deletions(-)
> > 
> > diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> > index e270bdf27f..b71add6f25 100644
> > --- a/gnu/packages/pdf.scm
> > +++ b/gnu/packages/pdf.scm
> > @@ -117,7 +117,7 @@ (define-module (gnu packages pdf)
> >  (define-public capypdf
> >    (package
> >      (name "capypdf")
> > -    (version "0.4.0")
> > +    (version "0.5.0")
> >      (source (origin
> >                (method git-fetch)
> >                (uri (git-reference
> > @@ -125,18 +125,14 @@ (define-public capypdf
> >                      (commit version)))
> >                (file-name (git-file-name name version))
> >                (sha256
> > -               (base32
> > "1kn46n3j5fygivmd6ldnv8vdwfv48ffaizq61yy4z9w2jm6fgxim"))))
> > +               (base32
> > "1mb3i0jq04gg5cm1l07mn9kal5s748miql97j6fpaf1x1j2lcrsx"))))
> >      (build-system meson-build-system)
> >      (arguments
> >       (list #:meson meson/newer
> > +           #:configure-flags #~(list "-Dcpp_std=c++23")
> 
> The build fails otherwise?
Yes, the file contains a very non-standard value for cpp_std, and it's
meant only for the big non free C++ compiler.

Cheers
Maxim Cournoyer Sept. 6, 2023, 1:07 a.m. UTC | #3 
Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

[...]

>> >      (build-system meson-build-system)
>> >      (arguments
>> >       (list #:meson meson/newer
>> > +           #:configure-flags #~(list "-Dcpp_std=c++23")
>> 
>> The build fails otherwise?
> Yes, the file contains a very non-standard value for cpp_std, and it's
> meant only for the big non free C++ compiler.

Got it.
Liliana Marie Prikler Sept. 9, 2023, 8:25 a.m. UTC | #4 
Am Dienstag, dem 05.09.2023 um 21:07 -0400 schrieb Maxim Cournoyer:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> [...]
> 
> > > >      (build-system meson-build-system)
> > > >      (arguments
> > > >       (list #:meson meson/newer
> > > > +           #:configure-flags #~(list "-Dcpp_std=c++23")
> > > 
> > > The build fails otherwise?
> > Yes, the file contains a very non-standard value for cpp_std, and
> > it's meant only for the big non free C++ compiler.
> 
> Got it.
Pushed now.
diff mbox series

Patch

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index e270bdf27f..b71add6f25 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -117,7 +117,7 @@  (define-module (gnu packages pdf)
 (define-public capypdf
   (package
     (name "capypdf")
-    (version "0.4.0")
+    (version "0.5.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -125,18 +125,14 @@  (define-public capypdf
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256
-               (base32 "1kn46n3j5fygivmd6ldnv8vdwfv48ffaizq61yy4z9w2jm6fgxim"))))
+               (base32 "1mb3i0jq04gg5cm1l07mn9kal5s748miql97j6fpaf1x1j2lcrsx"))))
     (build-system meson-build-system)
     (arguments
      (list #:meson meson/newer
+           #:configure-flags #~(list "-Dcpp_std=c++23")
            #:test-options '(list "plainc")
            #:phases
            #~(modify-phases %standard-phases
-               (add-after 'unpack 'add-missing-header
-                 (lambda _
-                   (substitute* "src/pdfgen.cpp"
-                     (("#include <cassert>" all)
-                      (string-append all "\n#include <unistd.h>")))))
                (add-after 'unpack 'fix-glib-application-flags
                  (lambda _
                    ;; XXX: remove when bumping glib