From patchwork Fri Nov 17 12:16:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sharlatan Hellseher X-Patchwork-Id: 56582 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8A98827BBEA; Fri, 17 Nov 2023 10:23:17 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 05E2227BBE2 for ; Fri, 17 Nov 2023 10:23:17 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3vyr-0001G8-C5; Fri, 17 Nov 2023 05:21:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vyO-0000xX-3I for guix-patches@gnu.org; Fri, 17 Nov 2023 05:21:18 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3vyL-00057I-Bt; Fri, 17 Nov 2023 05:21:14 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3vyL-0001IR-Fp; Fri, 17 Nov 2023 05:21:13 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67237] [PATCH 26/32] gnu: parfive: Improve package style. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: lars@6xq.net, marius@gnu.org, me@bonfacemunyoki.com, jgart@dismail.de, guix-patches@gnu.org Resent-Date: Fri, 17 Nov 2023 10:21:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67237@debbugs.gnu.org Cc: Sharlatan Hellseher , Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , jgart X-Debbugs-Original-Xcc: Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , jgart Received: via spool by 67237-submit@debbugs.gnu.org id=B67237.17002164534644 (code B ref 67237); Fri, 17 Nov 2023 10:21:13 +0000 Received: (at 67237) by debbugs.gnu.org; 17 Nov 2023 10:20:53 +0000 Received: from localhost ([127.0.0.1]:45236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3vy1-0001Ck-51 for submit@debbugs.gnu.org; Fri, 17 Nov 2023 05:20:53 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:57719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3vxm-00019V-B2 for 67237@debbugs.gnu.org; Fri, 17 Nov 2023 05:20:38 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-407da05f05aso13216245e9.3 for <67237@debbugs.gnu.org>; Fri, 17 Nov 2023 02:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700216432; x=1700821232; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/TmEhjOnFAPYs4IuafYAtVSB73WbAy9TsfDtKrJhAas=; b=PF3WO4bHAWKbPYg0xA6VxF1oEQvrYAc1SbRYpRlse0+KkFcip9z6ZC66EUgsyQyQan Sb7LAFm01bseUsrgLb2tGA51efARaBvwItbQyNZDaxNw9yLmgE0qxDtYL/5kBS6+6cOM BdftJR5EI52Hw9WfkzjNFjdvKkry2u0u/mSkl8hJUMg52+XkEjApJ7/8z1ieyV7sXbn+ 5prJo4TGm6jzpmcxVaJ2pZP+Lkhx/+rsZtmu480ZSH91dbYwapfUU1cRsiOJIBqleYLp q40TKYeG+fJguE2GMq5IgBl/weGo9q0qiKiVjF8xJHkeKiu/t2h09hEdrLureGB5UwMv eDFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700216432; x=1700821232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/TmEhjOnFAPYs4IuafYAtVSB73WbAy9TsfDtKrJhAas=; b=LgVZ/2mAXmJpqnbelotsTRzw04/71I5k+M19ZkP19ALbreIY+OF958aDXoI/BAvkOC XtPeULt1hASQ1tkNvWOJFTsNYFBn0v2dIO4uf+Uw3FiZbp7D57fsDSVhoOOTbmsjNau5 SViXRbNX4Le0229MC/gSzl6f3Gg54sDjImvO6FTr965QEd2zF41RNyCkTSLbJLFuW7tu spku3JAtNA1RukySh01EivsG6l5rI2RkJ2QWaKrABtJZraM9A9ZBStVMwiTUnUNlUfV3 0Qi1/jiKPHIm7bGaf/nZM89+IoXo+3rSjUWS5nJhyzQICfKnUmDDsN4YtL+7n55rkxo8 fGRw== X-Gm-Message-State: AOJu0YzzeTjp2MaMvKmHFoIhKlHrHBrUlgUDZ4D6mbjL4OfpURGta4YH kvjNfVTh6g6poIXe8CD64EPWnGibghWA6w== X-Google-Smtp-Source: AGHT+IHKPxYq5mNMcNP3w2H+sR1Cf1lAaGYk9GpWXplbU8Jsocvw6n5VeKiLhGWUj+PmaqFrMtzg+A== X-Received: by 2002:a05:6000:178f:b0:32d:a0d3:d681 with SMTP id e15-20020a056000178f00b0032da0d3d681mr14859885wrg.43.1700216432479; Fri, 17 Nov 2023 02:20:32 -0800 (PST) Received: from localhost.localdomain (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id t4-20020a5d4604000000b0032fbd0c7d04sm1858856wrq.55.2023.11.17.02.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 02:20:32 -0800 (PST) From: Sharlatan Hellseher Date: Fri, 17 Nov 2023 12:16:15 +0000 Message-ID: <63f1240d08da23fccd765d07eb775fb38abcaf7e.1700222319.git.sharlatanus@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/python-web.scm (parfive): Update package style. [build-system]: Swap to python-build-system. [arguments]{phases}: Remove 'disable-test-requiring-network phase. Use standard 'check phase. {test-flags}: Disable tests requiring network access. Change-Id: I5d233079f629398232f134c41fad6ea516c44c7f --- gnu/packages/python-web.scm | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm index 4b6f20745c..cc95643f07 100644 --- a/gnu/packages/python-web.scm +++ b/gnu/packages/python-web.scm @@ -1204,18 +1204,15 @@ (define-public parfive (sha256 (base32 "0pf8rzfwxpkn84xzb4v8m1fy3k7kjlh8f9ln4y5xqlnbqpwi30lh")))) - (build-system python-build-system) + (build-system pyproject-build-system) (arguments - (list #:phases #~(modify-phases %standard-phases - (add-before 'check 'disable-test-requiring-network - (lambda _ - (substitute* "parfive/tests/test_downloader.py" - (("def test_ftp") - "def __off_test_ftp")))) - (replace 'check - (lambda* (#:key tests? #:allow-other-keys) - (when tests? - (invoke "python" "-m" "pytest" "-vvv" "parfive"))))))) + (list + #:test-flags + ;; Disable tests requiring network access. + #~(list "-k" (string-append "not test_ftp" + " and not test_download_unique" + " and not test_custom_user_agent" + " and not test_multipart")))) (propagated-inputs (list python-aiofiles python-aioftp python-aiohttp python-tqdm)) (native-inputs (list python-pytest