diff mbox series

[bug#51356] gnu: ocaml4.07-merlin: Remove package.

Message ID 619a20ac865fe8b8c8b3362c07e7a6c42f19f1c4.1635010352.git.julien@lepiller.eu
State Accepted
Headers show
Series [bug#51356] gnu: ocaml4.07-merlin: Remove package. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Julien Lepiller Oct. 23, 2021, 5:33 p.m. UTC 
* gnu/packages/ocaml.scm (ocaml4.07-merlin): Remove package.
---
 gnu/packages/ocaml.scm | 28 ----------------------------
 1 file changed, 28 deletions(-)

Comments

Simon Tournier Nov. 15, 2021, 1:12 p.m. UTC | #1 
Hi Julien,

On Sat, 23 Oct 2021 at 19:33, Julien Lepiller <julien@lepiller.eu> wrote:
> * gnu/packages/ocaml.scm (ocaml4.07-merlin): Remove package.
> ---
>  gnu/packages/ocaml.scm | 28 ----------------------------
>  1 file changed, 28 deletions(-)

LGTM. :-)


Cheers,
simon
Julien Lepiller Nov. 19, 2021, 3:06 a.m. UTC | #2 
Pushed to master as 188e3e2e6878346b0bdc8b46084f458abe86826c.
diff mbox series

Patch

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index f0c46a9b4b..f640acca35 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -4650,34 +4650,6 @@  (define-public ocaml-merlin
 Atom.")
     (license license:expat)))
 
-;; ocaml-merlin 3.4.2 can not be built with old version of dune used in
-;; package-with-ocaml4.07
-(define-public ocaml4.07-merlin
-  (package-with-ocaml4.07
-   (package
-     (inherit ocaml-merlin)
-     (name "ocaml-merlin")
-     (version "3.2.2")
-     (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-              (url "https://github.com/ocaml/merlin")
-              (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "15ssgmwdxylbwhld9p1cq8x6kadxyhll5bfyf11dddj6cldna3hb"))))
-     (build-system dune-build-system)
-     (inputs
-      `(("ocaml-yojson" ,ocaml-yojson)))
-     (native-inputs
-      `(("ocaml-findlib" ,ocaml-findlib)))
-     (arguments
-      `(#:package "merlin"
-        ;; Errors in tests in version 3.2.2
-        #:tests? #f)))))
-
 (define-public ocaml4.07-gsl
   (package
     (name "ocaml4.07-gsl")