diff mbox series

[bug#61438] gnu: icedove: Update to 102.7.2.

Message ID 6007385f62e99e8fb82ae0fb93e24e5cec1b70a1.1676150175.git.dev@jpoiret.xyz
State New
Headers show
Series [bug#61438] gnu: icedove: Update to 102.7.2. | expand

Commit Message

Josselin Poiret Feb. 11, 2023, 9:16 p.m. UTC
* gnu/packages/gnuzilla.scm (%icedove-build-id, icedove-version,
thunderbird-source): Update to 102.7.2 build 20230207000000.
---
This fixes OAuth2 login not working with Microsoft servers.

 gnu/packages/gnuzilla.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: b367f28ed2ac8212d3c8b826b9655a0b2e879f18

Comments

Morgan Smith Feb. 12, 2023, 4:56 a.m. UTC | #1
I would just like to chime in that I am affected by this bug and I
appreciate that you took the time to do this.  Hopefully this patch can
be applied soon as I don't want to build icedove on my machine.

Thanks,

Morgan
Josselin Poiret Feb. 12, 2023, 10:27 a.m. UTC | #2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Morgan,

Note that, because every new patchset is built by QA to check if they
work, this icedove version is available from the bordeaux substitutes
server.  You can test it without building it, either directly with a
local check-out or using `guix time-machine/pull
- --url=https://git.guix-patches.cbaines.net/git/guix-patches
- --with-branch=issue-61438`.

Best,
- -- 
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmPovxIQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcaiqFpC/4kS+30FWfhXwS0DAI6ARynU3U4LiGgexvZ
MyrdOY10AN4YuM1ju8coBSIOR6BF26ZnK1WKqCRVenumJ8ZnBifDhhJKHYj+p5Oa
s3iwAbBOdaJ0v44stXNFQucLQLRGOY8XwyMN2ivFmBY5Kc14B8oTLMow6dbhz3hh
IX2K5c9Rd0vmcKQuco5TtLwlzH9LYpQc8FHEN8VBdU8YMf4vB7A2pmZ9b3goXEpJ
gPXto14GDtJvhkoYd1JPgUDMLStwhKdVdRj0496JakvcnatpAmDql3KwKKDLPO6m
GzqX2W0aXL8bWTIQ05oW1BYCKEpZ2rlc8vc1Pgl5pqyi1Lr4Ml3HeQ+Oo+5sa3nZ
fLFSzsFHNOlkWmG8KO6Z8uJ654qoOL4E8cGLJymMVLcElOEIIWV5a9A8v5klo5H4
hDhFH0vUkR6a0+zYAs87ILJSB1jw9z8UVrbOiBqda/+fS72ogRsx1WaHbNtqLkMy
x5lhihNciOcq6/hcyPf8dxMYwe7TYeM=
=oEfN
-----END PGP SIGNATURE-----
Josselin Poiret Feb. 12, 2023, 11:57 a.m. UTC | #3
My bad, misconfigured my mua, shouldn't happen again :) 

Josselin Poiret <dev@jpoiret.xyz> writes:

> Hi Morgan,
>
> Note that, because every new patchset is built by QA to check if they
> work, this icedove version is available from the bordeaux substitutes
> server.  You can test it without building it, either directly with a
> local check-out or using `guix time-machine/pull
> - --url=https://git.guix-patches.cbaines.net/git/guix-patches
> - --with-branch=issue-61438`.
>
> Best,
> - -- 
> Josselin Poiret
Morgan Smith Feb. 12, 2023, 6:09 p.m. UTC | #4
Hi Josselin,

That is really cool!  Thanks for showing me our QA.  After installing
icedove like you suggested, it works great for me!  I approve this
patch.

However, I noticed that the debug log for icedove shows that it fails to
find libotr.  This is true for our current version of icedove as well.
While we're updating it anyways, should we add libotr to the inputs?

Thanks,

Morgan
Josselin Poiret Feb. 12, 2023, 9:30 p.m. UTC | #5
Hi Morgan, 

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> However, I noticed that the debug log for icedove shows that it fails to
> find libotr.  This is true for our current version of icedove as well.
> While we're updating it anyways, should we add libotr to the inputs?

I have no idea if there are users that rely on Thunderbird for their OTR
communications.  I agree it would be a welcome improvement, just like
using our own gpg by default instead of the new RNP library which
doesn't support smartcards.  This is left as future work for now though
:)

Best,
Christopher Baines Feb. 13, 2023, 6:59 p.m. UTC | #6
Josselin Poiret via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/gnuzilla.scm (%icedove-build-id, icedove-version,
> thunderbird-source): Update to 102.7.2 build 20230207000000.
> ---
> This fixes OAuth2 login not working with Microsoft servers.
>
>  gnu/packages/gnuzilla.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

This looks good to me, I've pushed to master as
af1c817c84dfb074862451de04db3c8b9b534d9f.

Thanks,

Chris
diff mbox series

Patch

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 0b39774a2e..150481f1dc 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1097,8 +1097,8 @@  (define (runpaths-of-input label)
        (cpe-name . "firefox_esr")
        (cpe-version . ,(first (string-split version #\-)))))))
 
-(define %icedove-build-id "20230119000000") ;must be of the form YYYYMMDDhhmmss
-(define %icedove-version "102.7.0")
+(define %icedove-build-id "20230207000000") ;must be of the form YYYYMMDDhhmmss
+(define %icedove-version "102.7.2")
 
 ;; Provides the "comm" folder which is inserted into the icecat source.
 ;; Avoids the duplication of Icecat's source tarball.
@@ -1107,11 +1107,11 @@  (define thunderbird-source
     (method hg-fetch)
     (uri (hg-reference
           (url "https://hg.mozilla.org/releases/comm-esr102")
-          (changeset "a786f143946e93a3059e6fe290bb954840ab9778")))
+          (changeset "0f6deed0752b618055c34e06c268af3da9d1548d")))
     (file-name (string-append "thunderbird-" %icedove-version "-checkout"))
     (sha256
      (base32
-      "02pz9yhpp3lswjmvj30vbx05mbi31bnzzfwyw5v996zg5wz2fpyv"))))
+      "071q0pcfvfpzx741ly1sl8anlmzx02h17w4ylfnrkwrpaclq3p6p"))))
 
 (define-public icedove
   (package