diff mbox series

[bug#52336,1/2] gnu: register notcurses.scm in local.mk

Message ID 5ccbd4e534f4f6fcfb3f8c8814ad59e51377cb7a.1638817174.git.blake@nonconstructivism.com
State Accepted
Headers show
Series [bug#52336,1/2] gnu: register notcurses.scm in local.mk | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Blake Shaw Dec. 6, 2021, 7 p.m. UTC 
---
 gnu/local.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Leo Famulari Dec. 6, 2021, 7:24 p.m. UTC | #1 
On Tue, Dec 07, 2021 at 02:00:01AM +0700, Blake Shaw via Guix-patches via wrote:
> ---
>  gnu/local.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index b91d6eaa62..54e6dd422d 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -422,6 +422,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ninja.scm			\
>    %D%/packages/node.scm				\
>    %D%/packages/node-xyz.scm			\
> +  %D%/packages/notcurses.scm			\

Thanks! Remember, this should be done in the same commit as adding the
new file itself. Otherwise, the build of Guix would be broken in between
the two commits.
Blake Shaw Dec. 21, 2021, 8:37 p.m. UTC | #2 
Leo Famulari <leo@famulari.name> writes:

> Thanks! Remember, this should be done in the same commit as adding the
> new file itself. Otherwise, the build of Guix would be broken in between
> the two commits.

sorry Leo did you need me to rebase these commits before the package can
be merged?
Leo Famulari Dec. 21, 2021, 8:51 p.m. UTC | #3 
On Wed, Dec 22, 2021 at 03:37:10AM +0700, Blake Shaw wrote:
> sorry Leo did you need me to rebase these commits before the package can
> be merged?

Can you clarify what this patch is for?

It looks like ticket #52336 only registers a package module in
'gnu/local.mk', but the actual patch adding the module is missing:

https://issues.guix.gnu.org/52336

I sent my earlier message assuming that there would also be a commit
adding notcurses.scm itself.
Leo Famulari Dec. 21, 2021, 11:23 p.m. UTC | #4 
On Tue, Dec 21, 2021 at 03:51:34PM -0500, Leo Famulari wrote:
> It looks like ticket #52336 only registers a package module in
> 'gnu/local.mk', but the actual patch adding the module is missing:
> 
> https://issues.guix.gnu.org/52336

Oh, I see. The other patch is #52335. I've merged the two tickets now.
diff mbox series

Patch

diff --git a/gnu/local.mk b/gnu/local.mk
index b91d6eaa62..54e6dd422d 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -422,6 +422,7 @@  GNU_SYSTEM_MODULES =				\
   %D%/packages/ninja.scm			\
   %D%/packages/node.scm				\
   %D%/packages/node-xyz.scm			\
+  %D%/packages/notcurses.scm			\
   %D%/packages/noweb.scm			\
   %D%/packages/nss.scm				\
   %D%/packages/ntp.scm				\