From patchwork Thu Jan 7 09:16:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: raid5atemyhomework X-Patchwork-Id: 26257 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A206C27BC0D; Thu, 7 Jan 2021 09:17:09 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1E4AD27BC0E for ; Thu, 7 Jan 2021 09:17:09 +0000 (GMT) Received: from localhost ([::1]:56942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxRPo-0004BV-6I for patchwork@mira.cbaines.net; Thu, 07 Jan 2021 04:17:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxRPi-0004B6-FP for guix-patches@gnu.org; Thu, 07 Jan 2021 04:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxRPi-0008Nm-7x for guix-patches@gnu.org; Thu, 07 Jan 2021 04:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxRPi-0004Ho-4K for guix-patches@gnu.org; Thu, 07 Jan 2021 04:17:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#42193] kernel-module-configuration-service for configuring kernel parameters Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Jan 2021 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42193 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "45592@debbugs.gnu.org" <45592@debbugs.gnu.org>, "42193@debbugs.gnu.org" <42193@debbugs.gnu.org> Received: via spool by 42193-submit@debbugs.gnu.org id=B42193.161001099516426 (code B ref 42193); Thu, 07 Jan 2021 09:17:02 +0000 Received: (at 42193) by debbugs.gnu.org; 7 Jan 2021 09:16:35 +0000 Received: from localhost ([127.0.0.1]:46377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxRPH-0004Gq-2z for submit@debbugs.gnu.org; Thu, 07 Jan 2021 04:16:35 -0500 Received: from mail-40140.protonmail.ch ([185.70.40.140]:36183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxRPF-0004GZ-5W; Thu, 07 Jan 2021 04:16:33 -0500 Date: Thu, 07 Jan 2021 09:16:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610010986; bh=Sjf1gv2XIyvANAEM+TFjH8y+Xffq3Hdy5iG7FZnG178=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=C+5RGqytNAAMzl4wyqDXDpclAslJkT4CU7VwYP+4VwTIBo/pdohh6QYDcjHjc/s3d 0MPXmT9T7qwTC4/kBnsaj6Gvnmutb31WpYsidjL96gRbHACy694RRdFy5DPxKb5hRI uhlT4JJ7EmgKC+Ca0IR9F2WIPbt83NvdRwVzr8b8= Message-ID: <5bC3wYco2_hQFFuoBgIXEzu8nw1EJSACCaM1vnewD14AEQqQ-y32uoIWX1a5rJJxVvsSmWxI05fY0IKIjem5TyznqxZahm8v1F_fkEF7AeE=@protonmail.com> In-Reply-To: <7kahfDckMJIQd8o2gH_zQ-G9ORP_P0w-VD44R2OJHNP6rJHss8przoTyObTYxx_UEI5CERTD3OlGORnTCBmZA2VMASWpF2Ea0Hx1ZAbUh-I=@protonmail.com> References: <6wemXB-PfHUqbuVr5-XRf0-tY4cKGGtKiUqrZPrIZYXoBw17L3xRuZrGOJQfTo5PKfFNCM8KyRTllidoc7asPE2x98BTiJSPVR7OSjxCuw8=@protonmail.com> <20210106204134.38e83db4@scratchpost.org> <7kahfDckMJIQd8o2gH_zQ-G9ORP_P0w-VD44R2OJHNP6rJHss8przoTyObTYxx_UEI5CERTD3OlGORnTCBmZA2VMASWpF2Ea0Hx1ZAbUh-I=@protonmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brice Waegeneire Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: raid5atemyhomework , raid5atemyhomework via Guix-patches X-Patchwork-Original-From: raid5atemyhomework via Guix-patches via From: raid5atemyhomework X-getmail-retrieved-from-mailbox: Patches Hi Danny and Brice, Cross-posting to 42193 as well. > > > See also https://issues.guix.info/issue/42193 for an earlier attempt (which > > > is already very far--but it has a bug somewhere). I think what 42193 WIP 2/6 is missing is this hunk from my own 45592 PATCH 1/4: ```diff +++ b/gnu/system.scm@@ -625,26 +616,10 @@ possible (that is if there's a LINUX keyword argument in the build system)." "Return the basic entries of the 'system' directory of OS for use as the value of the SYSTEM-SERVICE-TYPE service." (let* ((locale (operating-system-locale-directory os)) - (kernel (operating-system-kernel os)) (hurd (operating-system-hurd os)) - (modules (operating-system-kernel-loadable-modules os)) - (kernel (if hurd - kernel - (profile - (content (packages->manifest - (cons kernel - (map (lambda (module) - (if (package? module) - (package-for-kernel kernel - module) - module)) - modules)))) - (hooks (list linux-module-database))))) (initrd (and (not hurd) (operating-system-initrd-file os))) (params (operating-system-boot-parameters-file os))) - `(("kernel" ,kernel) - ,@(if hurd `(("hurd" ,hurd)) '()) - ("parameters" ,params) + `(("parameters" ,params) ,@(if initrd `(("initrd" ,initrd)) '()) ("locale" ,locale)))) ;used by libc ``` I hope we can progress this towards a workable ZFS-on-Guix. Thanks raid5atemyhomework diff --git a/gnu/system.scm b/gnu/system.scm index c284a18379..5c530f176e 100644 --- a/gnu/system.scm