diff mbox series

[bug#63512] gnu: emacs-ement: Update to 0.9.1.

Message ID 5561ecbc606e4e5a807d273111f2b29df532f9f7.1684130176.git.jgart@dismail.de
State New
Headers show
Series [bug#63512] gnu: emacs-ement: Update to 0.9.1. | expand

Commit Message

jgart May 15, 2023, 5:56 a.m. UTC 
* gnu/packages/emacs-xyz.scm (emacs-ement): Update to 0.9.1.
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: c5fa9dd0e96493307cc76ea098a6bca9b076e012

Comments

Andrew Tropin May 15, 2023, 7:24 a.m. UTC | #1 
On 2023-05-15 00:56, jgart@dismail.de wrote:

> * gnu/packages/emacs-xyz.scm (emacs-ement): Update to 0.9.1.
> ---
>  gnu/packages/emacs-xyz.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f69967287d..cad9819a5e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -19195,7 +19195,7 @@ (define-public emacs-plz
>  (define-public emacs-ement
>    (package
>      (name "emacs-ement")
> -    (version "0.8.3")
> +    (version "0.9.1")
>      (source
>       (origin
>         (method git-fetch)
> @@ -19204,7 +19204,7 @@ (define-public emacs-ement
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "17s3sl0dijgmhnaryw08g6vn6za46xz6a709rsfrdis8v1knqd7z"))))
> +        (base32 "126h4cb0iy8k7w0amn0xizq2mbk9ga8yjc6kz1qn0k73d6kqwxn6"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:emacs emacs))              ;need libxml support
>
> base-commit: c5fa9dd0e96493307cc76ea098a6bca9b076e012

Hi jgart,

Thank you for the patch, applied!
jgart May 16, 2023, 12:46 a.m. UTC | #2 
Hi Andrew,

Thanks for merging that.

The update also fixes an annoying edge case bug I was experiencing from the upstream release version packaged in Guix which is documented here:

https://github.com/alphapapa/ement.el/issues/147

TLDR: ement would freeze up because Emacs does not support Microsoft ICO files at all and someone uploaded an ICO file for their matrix room avatar ;()

The fix was to warn when encountering an ico file in a matrix room and leave the room's avatar slot set to nil in the respective ement API code.

This ICO file in this one matrix room literally would freeze up Emacs completely because it didn't know how to handle it and would lock up.

all best,

jgart
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f69967287d..cad9819a5e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19195,7 +19195,7 @@  (define-public emacs-plz
 (define-public emacs-ement
   (package
     (name "emacs-ement")
-    (version "0.8.3")
+    (version "0.9.1")
     (source
      (origin
        (method git-fetch)
@@ -19204,7 +19204,7 @@  (define-public emacs-ement
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "17s3sl0dijgmhnaryw08g6vn6za46xz6a709rsfrdis8v1knqd7z"))))
+        (base32 "126h4cb0iy8k7w0amn0xizq2mbk9ga8yjc6kz1qn0k73d6kqwxn6"))))
     (build-system emacs-build-system)
     (arguments
      (list #:emacs emacs))              ;need libxml support