From patchwork Fri Feb 9 20:02:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul A. Patience" X-Patchwork-Id: 59972 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BAAAB27BBEA; Fri, 9 Feb 2024 20:03:00 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E695E27BBE2 for ; Fri, 9 Feb 2024 20:02:59 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYX5F-00082l-5S; Fri, 09 Feb 2024 15:02:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYX5D-00082Z-08 for guix-patches@gnu.org; Fri, 09 Feb 2024 15:02:47 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYX5C-0008Qx-Gk for guix-patches@gnu.org; Fri, 09 Feb 2024 15:02:46 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYX5R-0003Oz-L9 for guix-patches@gnu.org; Fri, 09 Feb 2024 15:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69006] [PATCH 2/2] gnu: reproc: Improve package style. Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Feb 2024 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69006 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69006@debbugs.gnu.org Cc: "Paul A. Patience" Received: via spool by 69006-submit@debbugs.gnu.org id=B69006.170750896113024 (code B ref 69006); Fri, 09 Feb 2024 20:03:01 +0000 Received: (at 69006) by debbugs.gnu.org; 9 Feb 2024 20:02:41 +0000 Received: from localhost ([127.0.0.1]:34367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYX57-0003Nz-Ht for submit@debbugs.gnu.org; Fri, 09 Feb 2024 15:02:41 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:42417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYX56-0003Ne-8Y for 69006@debbugs.gnu.org; Fri, 09 Feb 2024 15:02:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1707508938; x=1707768138; bh=d9vEI5x0ycNEjecHcTmBFRNzOLDPrH0Dlor8Aj3q8lk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=avqk5FOAb/ws9o8aLWU/YoR89mSAG/zWtkllzlP3N47A7n4gL2MHg7R06MtD0A8H4 CTT169T72Cy6kX35UEz8NKTGyRNdkt9iFrfvkzMxJ0Ags8QvUXT/mir4KJIr/NR2xg SabicPfyu/Vm8DZJOcmB8RpyE0YQpVrmx/5YO2xdKhzeiMY6jgdXN4F+Q1rdd9vY7w 5UWY5bE/ixTmyN7fjkaayvsKvpit3hw05IyF3fcOnsigqBV75Uwj2EE/1e/G7+Eg3e ddQ2eRjO2sPzap9AkVP5cssnHQHj0AsgAbktucerTWwPO725bs0JQtsR/0EArHYSAV ov0s/LAqrUuow== Date: Fri, 09 Feb 2024 20:02:12 +0000 From: "Paul A. Patience" Message-ID: <54ce21a63b314e2bf13023b2df6f7e82e225f1bc.1707506182.git.paul@apatience.com> In-Reply-To: <0ff996d504ed3a3ff0eb1fdb1fb061e4a018baad.1707506182.git.paul@apatience.com> References: <0ff996d504ed3a3ff0eb1fdb1fb061e4a018baad.1707506182.git.paul@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/cpp.scm (reproc)[arguments]: Use G-expressions. <#:configure-flags>: Remove unnecessary comment and enable CMake variable with ON rather than 1. Change-Id: Ic5e6747e7978a40d1aab66b4c3634342736c0bcf --- gnu/packages/cpp.scm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm index 785b001629..4523ce2b04 100644 --- a/gnu/packages/cpp.scm +++ b/gnu/packages/cpp.scm @@ -1055,11 +1055,9 @@ (define-public reproc (base32 "09xnf8hmld1fk8j33zwlz1qcxnjdx1ncbg62csic9va4m1wc2v1d")))) (build-system cmake-build-system) (arguments - ;; No tests. - `(#:tests? #f - ;; Build the shared library instead of a static one. - #:configure-flags `("-DBUILD_SHARED_LIBS=1" - "-DREPROC++=ON"))) + (list #:tests? #f ; No tests. + #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON" + "-DREPROC++=ON"))) (native-inputs (list pkg-config)) (synopsis "Process IO library")