diff mbox series

[bug#38538] gnu: Add gnome-shell-extension-hide-app-icon

Message ID 5045109122d5968f363a1206e01eab6f3fdf12b7.camel@student.tugraz.at
State Accepted
Headers show
Series [bug#38538] gnu: Add gnome-shell-extension-hide-app-icon | expand

Commit Message

Leo Prikler Dec. 22, 2019, 3:33 p.m. UTC
Am Freitag, den 20.12.2019, 09:02 +0200 schrieb Efraim Flashner:
> In any case, I've pushed the patch with glib:bin in native-inputs and
> glib in propagated-inputs.
I just got around to checking and it appears the rewritten install
phase breaks the package.  I've attached a fix in 0001, and also split
up my depropagation patch for the other packages.

Regards,
Leo

Comments

Efraim Flashner Dec. 23, 2019, 7:41 a.m. UTC | #1
On Sun, Dec 22, 2019 at 04:33:48PM +0100, Leo Prikler wrote:
> Am Freitag, den 20.12.2019, 09:02 +0200 schrieb Efraim Flashner:
> > In any case, I've pushed the patch with glib:bin in native-inputs and
> > glib in propagated-inputs.
> I just got around to checking and it appears the rewritten install
> phase breaks the package.  I've attached a fix in 0001, and also split
> up my depropagation patch for the other packages.
> 
> Regards,
> Leo

Oh no! I'm glad you caught it. The included install phase was way too
complicated for what it was supposed to do.

I've gone ahead and pushed these too. Thanks!
diff mbox series

Patch

From 0b8dc9d4b8463c3f68d72c506e49c4706ae64144 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 22 Dec 2019 16:12:32 +0100
Subject: [PATCH 3/3] gnu: gnome-shell-extensions: Depropagate glib:bin.

* gnu/packages/gnome.scm (gnome-shell-extensions):
[propagated-inputs]: Move glib:bin from here...
[native-inputs]: ... to here.
---
 gnu/packages/gnome.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 2f772ee1b0..95da97e95d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7570,11 +7570,11 @@  GNOME Shell appearance and extension, etc.")
     (arguments
      '(#:configure-flags '("-Dextension_set=all")))
     (native-inputs
-     `(("intltool" ,intltool)
+     `(("glib:bin" ,glib "bin")
+       ("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("glib" ,glib)
-       ("glib" ,glib "bin")))
+     `(("glib" ,glib)))
     (synopsis "Extensions for GNOME Shell")
     (description "GNOME Shell extensions modify and extend GNOME Shell
 functionality and behavior.")
-- 
2.24.1