diff mbox series

[bug#61825] etc: Default to variables in tempel's git-reference... et al.

Message ID 4ea107af9cb1e87412d22d44b44f2134394cc951.camel@gmail.com
State New
Headers show
Series [bug#61825] etc: Default to variables in tempel's git-reference... et al. | expand

Commit Message

Liliana Marie Prikler Feb. 26, 2023, 8:56 p.m. UTC 
Since we encourage using variables rather than magic hashes in the commit
fields, e.g. (commit version) and (commit commit), the default for
tempel to use quoted strings is rather off.  Thus, let the placeholder reflect
actual usage.

* etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use field name
as placeholder and don't quote value.
(svn-reference..., bzr-reference...)[revision]: Likewise.
(hg-reference...)[changeset]: Likewise.
---
 etc/snippets/tempel/scheme-mode | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Liliana Marie Prikler March 5, 2023, 9:03 a.m. UTC | #1 
Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
Prikler:
> Since we encourage using variables rather than magic hashes in the
> commit fields, e.g. (commit version) and (commit commit), the default
> for tempel to use quoted strings is rather off.  Thus, let the
> placeholder reflect actual usage.
> 
> * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> field name
> as placeholder and don't quote value.
> (svn-reference..., bzr-reference...)[revision]: Likewise.
> (hg-reference...)[changeset]: Likewise.
Pushed.
Liliana Marie Prikler June 18, 2023, 7 a.m. UTC | #2 
Am Sonntag, dem 05.03.2023 um 10:03 +0100 schrieb Liliana Marie
Prikler:
> Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
> Prikler:
> > Since we encourage using variables rather than magic hashes in the
> > commit fields, e.g. (commit version) and (commit commit), the
> > default
> > for tempel to use quoted strings is rather off.  Thus, let the
> > placeholder reflect actual usage.
> > 
> > * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> > field name
> > as placeholder and don't quote value.
> > (svn-reference..., bzr-reference...)[revision]: Likewise.
> > (hg-reference...)[changeset]: Likewise.
> Pushed.
Forgot to mark as done.
diff mbox series

Patch

diff --git a/etc/snippets/tempel/scheme-mode b/etc/snippets/tempel/scheme-mode
index 54cb8e40a9..ef73a1e595 100644
--- a/etc/snippets/tempel/scheme-mode
+++ b/etc/snippets/tempel/scheme-mode
@@ -56,12 +56,12 @@  scheme-mode
 (git-reference...
  "(git-reference"
  n> "(url \"" p "\")"
- n> "(commit \"" p "\"))")
+ n> "(commit " (p "commit") "))")
 
 (svn-reference...
  "(svn-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (cvs-reference...
  "(cvs-reference"
@@ -72,12 +72,12 @@  scheme-mode
 (hg-reference...
  "(hg-reference"
  n> "(url \"" p "\")"
- n> "(changeset \"" p "\"))")
+ n> "(changeset " (p "changeset") "))")
 
 (bzr-reference...
  "(bzr-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (:phases\ "#:phases (modify-phases %standard-phases"
           n> p ")")