From patchwork Mon Apr 8 17:54:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahmad Draidi X-Patchwork-Id: 62855 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 32DDE27BBE9; Mon, 8 Apr 2024 18:57:06 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2997127BBE2 for ; Mon, 8 Apr 2024 18:57:04 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rttDq-0005gU-NQ; Mon, 08 Apr 2024 13:55:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rttDo-0005dq-Bp for guix-patches@gnu.org; Mon, 08 Apr 2024 13:55:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rttDn-0004qP-RW for guix-patches@gnu.org; Mon, 08 Apr 2024 13:55:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rttDv-0001Mb-A7 for guix-patches@gnu.org; Mon, 08 Apr 2024 13:56:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70285] [PATCH 3/3] services: cuirass: Remove use-substitutes? configuration option. Resent-From: Ahmad Draidi Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Apr 2024 17:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70285@debbugs.gnu.org Cc: Ahmad Draidi Received: via spool by 70285-submit@debbugs.gnu.org id=B70285.17125989425147 (code B ref 70285); Mon, 08 Apr 2024 17:56:03 +0000 Received: (at 70285) by debbugs.gnu.org; 8 Apr 2024 17:55:42 +0000 Received: from localhost ([127.0.0.1]:47584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rttDZ-0001Kw-73 for submit@debbugs.gnu.org; Mon, 08 Apr 2024 13:55:41 -0400 Received: from rainycloud.ext.redscript.org ([2402:28c0:4:1081::1]:54730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rttDW-0001KI-F4 for 70285@debbugs.gnu.org; Mon, 08 Apr 2024 13:55:38 -0400 Received: from localhost.localdomain (bba-86-99-90-22.alshamil.net.ae [86.99.90.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rainycloud.ext.redscript.org (Postfix) with ESMTPSA id AD6E57ADE; Mon, 8 Apr 2024 17:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-rsa; t=1712598925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fdEz3Ji0fFlrgKTaJSEZsGpIqFgMc8Eg57EarzTL3EU=; b=iERAYOT6dL6/stHEyqv6bKgy2LeE7+svNyRYKFovAZPh8lYma8LK1x72ayxVwsJ84ekMaH l9oLcWBZ8dLE0uj0XXCuQIGP+6Uncc2mvJbLUXhTn/m4Gs3qMJDCke95GQVizMMb7tNtDp hgt6xYXOZZCMCWc9mzeB2Ugpq9BDq3OKq7MS7UCJXMKLEYepoR6knBpclmkHfaQUILwxkU V4yTEv4x0b5PzI/M1su4cP4uUVLj8mDw8G57joZB3zAhjgE7Td6NOVd4FpperW2M1EzAyS 7Vpc8hGOWdTi/bnIDE/vlwfWuVQsnMm2ohZXluQ1h5faqVn4nt/x+FCb+YNS9BCgJNQ1ud 9VHW5poZVt/a/y2fkK8CY/LpuLah2IF4n6ZAg7oOrSTlORCz4EgjAf5LYoMkUe7Du7/Dh2 573N2iODjFT3aNHW9FPLxdyrqgdV6bj0HK4XXANjq10RG4j7OiybndvS9lQmXbe4CgSCy7 cc9X7pdp8QJmZ1JV0KxpL3K4WXPb8Gg0ENUs2cPaVnGw3GTgmD7i8B5hg07k07t0nCVu6r eFx/JyRtG3vufCiE8frZzQj4Vt95xB/E641GELZ6ILKvXvhifOutdrdO3JwoTq3iwcnQus PoMouOkG5atqaOQnzINO9jrFrrFYzYMREZsuBuQrhuCqM5jOiQY/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-ed25519; t=1712598925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fdEz3Ji0fFlrgKTaJSEZsGpIqFgMc8Eg57EarzTL3EU=; b=2H8tcLTnVSaDkcs9LKoW2TlllrInFc4aUJknsxFdl+hsuIOjsEVc5nFDiM7hxgq2GbN1/w W/O4kJoUvNRsWBBg== Date: Mon, 8 Apr 2024 21:54:14 +0400 Message-ID: <4b85490a37a0e08146f31e544b671865bb5927a0.1712576504.git.a.r.draidi@redscript.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ahmad Draidi X-ACL-Warn: , Ahmad Draidi via Guix-patches X-Patchwork-Original-From: Ahmad Draidi via Guix-patches via From: Ahmad Draidi Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches As of Cuirass commit 9a1452ee021c9f773424961cfeef47ca0b7c5c5a, this option seems to be unused and kept for back compatibility there. * gnu/services/cuirass.scm (): Remove use-substitutes? field. (cuirass-shepherd-service): Remove the option. * doc/guix.texi (Continuous Integration): Remove option documentation. Change-Id: I933550ce76eecdf918b07891aa8212fd30a7c87e --- doc/guix.texi | 4 ---- gnu/services/cuirass.scm | 4 ---- 2 files changed, 8 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 90a6135882..cc55f48aea 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -34400,10 +34400,6 @@ Continuous Integration specifications records. The specification record is described in the Cuirass manual (@pxref{Specifications,,, cuirass, Cuirass}). -@item @code{use-substitutes?} (default: @code{#f}) -This allows using substitutes to avoid building every dependencies of a job -from source. - @item @code{one-shot?} (default: @code{#f}) Only evaluate specifications and build derivations once. diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm index ac086dedb9..0684c149c1 100644 --- a/gnu/services/cuirass.scm +++ b/gnu/services/cuirass.scm @@ -117,8 +117,6 @@ (define-record-type* (default "localhost")) (specifications cuirass-configuration-specifications) ;gexp that evaluates to specification-alist - (use-substitutes? cuirass-configuration-use-substitutes? ;boolean - (default #f)) (one-shot? cuirass-configuration-one-shot? ;boolean (default #f)) (fallback? cuirass-configuration-fallback? ;boolean @@ -147,7 +145,6 @@ (define (cuirass-shepherd-service config) (config-file (scheme-file "cuirass-specs.scm" (cuirass-configuration-specifications config))) - (use-substitutes? (cuirass-configuration-use-substitutes? config)) (one-shot? (cuirass-configuration-one-shot? config)) (fallback? (cuirass-configuration-fallback? config)) (extra-options (cuirass-configuration-extra-options config)) @@ -177,7 +174,6 @@ (define (cuirass-shepherd-service config) parameters)) '()) #$@(if remote-server '("--build-remote") '()) - #$@(if use-substitutes? '("--use-substitutes") '()) #$@(if one-shot? '("--one-shot") '()) #$@(if fallback? '("--fallback") '()) #$@extra-options)