From patchwork Sat Jun 1 14:40:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Vollmert X-Patchwork-Id: 14188 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 80C9F17079; Sat, 1 Jun 2019 15:43:17 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id EA87517072 for ; Sat, 1 Jun 2019 15:43:14 +0100 (BST) Received: from localhost ([127.0.0.1]:37810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX5E2-0006to-4J for patchwork@mira.cbaines.net; Sat, 01 Jun 2019 10:43:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX5Dz-0006tS-Cf for guix-patches@gnu.org; Sat, 01 Jun 2019 10:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hX5Bu-0006aN-UV for guix-patches@gnu.org; Sat, 01 Jun 2019 10:41:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53088) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hX5Bt-0006Zv-V4 for guix-patches@gnu.org; Sat, 01 Jun 2019 10:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hX5Bt-0001rE-Rq for guix-patches@gnu.org; Sat, 01 Jun 2019 10:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests Resent-From: Robert Vollmert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jun 2019 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35944 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 35944-submit@debbugs.gnu.org id=B35944.15594000517113 (code B ref 35944); Sat, 01 Jun 2019 14:41:01 +0000 Received: (at 35944) by debbugs.gnu.org; 1 Jun 2019 14:40:51 +0000 Received: from localhost ([127.0.0.1]:38397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX5Bi-0001qe-Pl for submit@debbugs.gnu.org; Sat, 01 Jun 2019 10:40:51 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:13580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX5Bg-0001qP-Cq for 35944@debbugs.gnu.org; Sat, 01 Jun 2019 10:40:49 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 0F0004F96B; Sat, 1 Jun 2019 16:40:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id zOF0z6z2-eGq; Sat, 1 Jun 2019 16:40:33 +0200 (CEST) Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Robert Vollmert In-Reply-To: Date: Sat, 1 Jun 2019 16:40:31 +0200 Message-Id: <4BD76A21-D533-4B60-9A24-6855225D354E@vllmrt.net> References: <20190528124101.63429-1-rob@vllmrt.net> <87ftoth3d8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 35944@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches > On 1. Jun 2019, at 14:56, Robert Vollmert wrote: >> On 1. Jun 2019, at 14:55, Ludovic Courtès wrote: >> They fail because they run out of memory? > > Indeed, the OOM killer strikes. > >> What would it take to skip just these two tests instead of skipping all >> the tests? > > I’ll look into it. Below is a patch that does that. I’m now running into similar issues when compiling ghc-scientific; should OOM test failures at 2G of memory generally be considered worth fixing? As an alternative, would it be feasible to implement a --skip-tests flag for guix build? From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001 From: Robert Vollmert Date: Tue, 28 May 2019 21:10:24 +0200 Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests. Tests fail reliably for me on a system with 2GB of available RAM, in `issue93.a.hs` and `issue93.n.hs`. * gnu/packages/haskell.scm (ghc-happy): Skip test "issue93". --- gnu/packages/haskell.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm index 33c9c6484d..be9ab00bfd 100644 --- a/gnu/packages/haskell.scm +++ b/gnu/packages/haskell.scm @@ -1325,6 +1325,14 @@ postfix notation. For more information on stack based languages, see (base32 "138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y")))) (build-system haskell-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'skip-test-issue93 + (lambda _ + (substitute* "tests/Makefile" + ((" issue93.y ") " ")) + #t))))) (home-page "https://hackage.haskell.org/package/happy") (synopsis "Parser generator for Haskell") (description "Happy is a parser generator for Haskell. Given a grammar