| Message ID | 4809ad315243309fdef56f2860032e8f2573c6ec.1681742871.git.jlicht@fsfe.org |
|---|---|
| State | New |
| Headers | show |
| Series | Updating node-lts to 18.X | expand |
Am Montag, dem 17.04.2023 um 16:51 +0200 schrieb jlicht@fsfe.org: > From: Jelle Licht <jlicht@fsfe.org> > > * gnu/packages/emacs-xyz.scm (emacs-nodejs-repl)[inputs]: Replace > NODE by NODE-LTS. I think lowercase would be better. > --- > > (no changes since v1) Where is v1? > gnu/packages/emacs-xyz.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index c1748e7f36..7282c03dfe 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -12803,7 +12803,7 @@ (define-public emacs-nodejs-repl > > "0a5mmg3cmdi73giblp07ksl06xzl9nb2m3f96ny4r3rv0ar3v1bx")))) > (build-system emacs-build-system) > (inputs > - (list node)) > + (list node-lts)) LGTM, I guess. Is it expected that node-lts will see fewer rebuilds than the other node package going forward? Cheers
Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Montag, dem 17.04.2023 um 16:51 +0200 schrieb jlicht@fsfe.org: >> From: Jelle Licht <jlicht@fsfe.org> >> >> * gnu/packages/emacs-xyz.scm (emacs-nodejs-repl)[inputs]: Replace >> NODE by NODE-LTS. > I think lowercase would be better. Addressed locally, and will take into account when applying. > >> --- >> >> (no changes since v1) > Where is v1? There is no v1. This blurb is generated by patman, I do not know how to disable this. Tips very much welcome. Since I started using patman, I've listed changes in each cover letter instead, as that's much easier to manage. >> gnu/packages/emacs-xyz.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index c1748e7f36..7282c03dfe 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -12803,7 +12803,7 @@ (define-public emacs-nodejs-repl >> >> "0a5mmg3cmdi73giblp07ksl06xzl9nb2m3f96ny4r3rv0ar3v1bx")))) >> (build-system emacs-build-system) >> (inputs >> - (list node)) >> + (list node-lts)) > LGTM, I guess. Is it expected that node-lts will see fewer rebuilds > than the other node package going forward? No, if anything the hope is that there will be more going on with the node-lts package :-). Our current "node" package should not be used, as it's an ancient (and unsupported) version. Restructuring the node/node-lts/node-bootstrap triad (and making sure older versions are not exposed to users) will be my next node-related venture. > Cheers Thanks for the review! - Jelle
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c1748e7f36..7282c03dfe 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -12803,7 +12803,7 @@ (define-public emacs-nodejs-repl "0a5mmg3cmdi73giblp07ksl06xzl9nb2m3f96ny4r3rv0ar3v1bx")))) (build-system emacs-build-system) (inputs - (list node)) + (list node-lts)) (native-inputs (list emacs-ert-expectations)) (arguments
From: Jelle Licht <jlicht@fsfe.org> * gnu/packages/emacs-xyz.scm (emacs-nodejs-repl)[inputs]: Replace NODE by NODE-LTS. --- (no changes since v1) gnu/packages/emacs-xyz.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)