diff mbox series

[bug#49184] : Strings in (guix diagnostics) are not translated

Message ID 476731ec1dba1e224a5e872283d949b331d8e628.camel@telenet.be
State Accepted
Headers show
Series [bug#49184] : Strings in (guix diagnostics) are not translated | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

M June 23, 2021, 10:25 a.m. UTC 
Hi Guix,

(guix diagnostics) has some translatable strings.
See e.g. the following code:

(define-diagnostic warning (G_ "warning: ") %warning-color) ;emit a warning
(define-diagnostic info (G_ "") %info-color)
(define-diagnostic report-error (G_ "error: ") %error-color)

These are currently not translated and don't appear on translate.fedoraproject.org.
The issue appears to be that guix/diagnostics.scm does not appear in
guix/POTFILES.in.

A patch that should fix this is attached.

Greetings,
Maxime.

Comments

Leo Prikler June 23, 2021, 2:22 p.m. UTC | #1 
Before adding guix/diagnostics.scm to the POTFILES, you should probably
drop the call (G_ "").  Last time I checked, that did not actually
return the empty string, but some metadata.

(I actually sent a similar reply through the web interface, but it was
apparently swallowed somewhere)
Ludovic Courtès June 23, 2021, 9:04 p.m. UTC | #2 
Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> These are currently not translated and don't appear on translate.fedoraproject.org.
> The issue appears to be that guix/diagnostics.scm does not appear in
> guix/POTFILES.in.

I did that not long ago (after the release, unfortunately) in
fed83e52fed3808b437361d84c29c2870cab5458.

The relevant strings are commented out in .po files though, so we’ll
need a PO update to get them.

Thanks,
Ludo’.
M June 25, 2021, 11:24 a.m. UTC | #3 
Ludovic Courtès schreef op wo 23-06-2021 om 23:04 [+0200]:
> Hi,
> 
> Maxime Devos <maximedevos@telenet.be> skribis:
> 
> > These are currently not translated and don't appear on translate.fedoraproject.org.
> > The issue appears to be that guix/diagnostics.scm does not appear in
> > guix/POTFILES.in.
> 
> I did that not long ago (after the release, unfortunately) in
> fed83e52fed3808b437361d84c29c2870cab5458.

Seems like my local git worktree is in need of a "git rebase".
Thanks!

Greetigs,
Maxime.
diff mbox series

Patch

From 2b3c51645e811ddd615fca5355618e4b0d82c4ec Mon Sep 17 00:00:00 2001
From: Maxime Devos <maximedevos@telenet.be>
Date: Fri, 18 Jun 2021 13:47:04 +0200
Subject: [PATCH] po: Add (guix diagnostics) to the list of files with I18N
 strings.

* po/guix/POTFILES.in: Add guix/diagnostics.scm.
---
 po/guix/POTFILES.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/po/guix/POTFILES.in b/po/guix/POTFILES.in
index cbbfe1e76b..34c77c74cd 100644
--- a/po/guix/POTFILES.in
+++ b/po/guix/POTFILES.in
@@ -93,6 +93,7 @@  guix/profiles.scm
 guix/git.scm
 guix/deprecation.scm
 guix/derivations.scm
+guix/diagnostics.scm
 guix/scripts/archive.scm
 guix/scripts/build.scm
 guix/scripts/environment.scm
-- 
2.32.0