| Message ID | 46b29e88905aee8c059a84ab355f87554cd3d60c.1697305618.git.Rostislav.Svoboda@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#66545] gnu: Add emacs-color-theme-sanityinc-tomorrow. | expand |
Am Samstag, dem 14.10.2023 um 19:47 +0200 schrieb Rostislav Svoboda: > * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): > New variable. > --- > gnu/packages/emacs-xyz.scm | 40 > ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index bb8c25f9b5..1d10188b9c 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -11057,6 +11057,46 @@ (define-public emacs-moe-theme-el > variants.") > (license license:gpl3+))) > > +(define-public emacs-color-theme-sanityinc-tomorrow > + (let ((commit "d34e8db507ee0c7b465ff18a8f220c33ed77cd79") > + (revision "0")) > + (package > + (name "emacs-color-theme-sanityinc-tomorrow") > + (version (git-version "0" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url > + > "https://github.com/purcell/color-theme-sanityinc-tomorrow") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > "1mfildi7rav2j42avii7z4gp4ghl04cqv8wp1vyxzl8vkyj60nkb")))) > + (build-system emacs-build-system) > + (arguments > + (list > + #:tests? #true > + #:test-command > + #~(list "emacs" "-Q" "--batch" "--eval" " > +(progn > + (setq byte-compile-error-on-warn t) > + (push default-directory load-path)) > +" > + "-f" "batch-byte-compile" > + "color-theme-sanityinc-tomorrow.el" > + "sanityinc-tomorrow-blue-theme.el" > + "sanityinc-tomorrow-bright-theme.el" > + "sanityinc-tomorrow-day-theme.el" > + "sanityinc-tomorrow-eighties-theme.el" > + "sanityinc-tomorrow-night-theme.el"))) The tests should not be byte compilation. In fact, these files should be compiled by the build phase. > + (home-page > "https://github.com/purcell/color-theme-sanityinc-tomorrow") > + (synopsis "Emacs color themes based on Chris Kempson's > 'tomorrow' themes") > + (description > + "An Emacs version of Chris Kempson's \"Tomorrow\" themes, > with much more > +extensive face definitions than the \"official\" Emacs variant.") > + (license license:gpl3+)))) > + > (define-public emacs-solarized-theme > (package > (name "emacs-solarized-theme") > > base-commit: 3d0cdf963820da665d71987c15cae6e503efc701 Cheers
> The tests should not be byte compilation. In fact, these files should be compiled by the build phase.
I see now that the emacs-build-system 'byte compiles all Emacs Lisp
files.' Then, I think the entire `(arguments ...)` can be elided. If
this is correct, I am resending the patch (see attachment). If not,
please direct me to some examples or explain in more detail how to
byte-compile the *.el file during the build phase. Thank you.
(FYI the code under #:test-command was from
https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)
Please consider reviewing the following two patches together: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow. https://issues.guix.gnu.org/issue/66545 [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized. https://issues.guix.gnu.org/issue/66550 Le sam. 14 oct. 2023 à 19:49, GNU bug Tracking System <help-debbugs@gnu.org> a écrit : > > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > As you requested using X-Debbugs-CC, your message was also forwarded to > Andrew Tropin <andrew@trop.in>, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>, Liliana Marie Prikler <liliana.prikler@gmail.com> > (after having been given a bug report number, if it did not have one). > > Your message has been sent to the package maintainer(s): > guix-patches@gnu.org > > If you wish to submit further information on this problem, please > send it to 66545@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 66545: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66545 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index bb8c25f9b5..1d10188b9c 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -11057,6 +11057,46 @@ (define-public emacs-moe-theme-el variants.") (license license:gpl3+))) +(define-public emacs-color-theme-sanityinc-tomorrow + (let ((commit "d34e8db507ee0c7b465ff18a8f220c33ed77cd79") + (revision "0")) + (package + (name "emacs-color-theme-sanityinc-tomorrow") + (version (git-version "0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url + "https://github.com/purcell/color-theme-sanityinc-tomorrow") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1mfildi7rav2j42avii7z4gp4ghl04cqv8wp1vyxzl8vkyj60nkb")))) + (build-system emacs-build-system) + (arguments + (list + #:tests? #true + #:test-command + #~(list "emacs" "-Q" "--batch" "--eval" " +(progn + (setq byte-compile-error-on-warn t) + (push default-directory load-path)) +" + "-f" "batch-byte-compile" + "color-theme-sanityinc-tomorrow.el" + "sanityinc-tomorrow-blue-theme.el" + "sanityinc-tomorrow-bright-theme.el" + "sanityinc-tomorrow-day-theme.el" + "sanityinc-tomorrow-eighties-theme.el" + "sanityinc-tomorrow-night-theme.el"))) + (home-page "https://github.com/purcell/color-theme-sanityinc-tomorrow") + (synopsis "Emacs color themes based on Chris Kempson's 'tomorrow' themes") + (description + "An Emacs version of Chris Kempson's \"Tomorrow\" themes, with much more +extensive face definitions than the \"official\" Emacs variant.") + (license license:gpl3+)))) + (define-public emacs-solarized-theme (package (name "emacs-solarized-theme")