| Message ID | 4553177.31r3eYUQgx@cherry |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#40061] Allow double-click select of URL in status | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | fail | View Laminar job |
----- Forwarded message from Tom Zander <tomz@freedommail.ch> ----- Date: Sat, 14 Mar 2020 19:32:40 +0100 From: Tom Zander <tomz@freedommail.ch> To: Leo Famulari <leo@famulari.name> Subject: Re: [bug#40061] Version two of the patch. On zaterdag 14 maart 2020 18:48:16 CET Leo Famulari wrote: > On Sat, Mar 14, 2020 at 06:16:52PM +0100, Tom Zander via Guix-patches via wrote: > > Attached is an updated version of the patch, it fixes more of the same > > issues. > > > > From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001 > > From: TomZ <tomz@freedommail.ch> > > Date: Sat, 14 Mar 2020 14:36:28 +0100 > > Subject: [PATCH] Allow double-click select of URL in status > > > > Various places while downloading or compiling guix > > prints the source URL. This change makes the URL be easier > > to be used by placing a space between the URL and the trailing > > dots. > > Thanks, this is great. I get annoyed by this constantly. > > Any other feedback? I wrote down some more silly things that I'm not sure I'll get to. Imagine the following; guix package -i guile-git The following package will be upgraded: guile-git 0.3.0 → 0.3.0 /gnu/store/h5y9c889q237a0sjzn68zflkmk3zz33f-guile-git-0.3.0 Instead of saying "upgraded" it should say "reinstalled". then: the 'info guix' chapter 2.6.1 Locales has this gem: «Note that the ‘glibc-locales’ package contains data for all the locales supported by the GNU libc and weighs in at around 110 MiB.» If you install it you'll note its well over 200MB, though. That at minimum should be updated in the info. Or more likely just stated that its large. Thanks!
LGTM, except maybe the following change to the commit msg: This change makes the URL be easier to be used => This change makes the URL easier to use But that may not warrant a new patch submission, though, as the committer may do it himself... Thanks
Vincent Legoll <vincent.legoll@gmail.com> writes: > LGTM, except maybe the following change to the > commit msg: > > This change makes the URL be easier to be used > => > This change makes the URL easier to use > > But that may not warrant a new patch submission, > though, as the committer may do it himself... Whoops, I committed this without seeing this comment, oh well! Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.
Hello, On Tue, Apr 7, 2020 at 10:00 PM Marius Bakke <mbakke@fastmail.com> wrote: > Vincent Legoll <vincent.legoll@gmail.com> writes: > > LGTM, except maybe the following change to the > > commit msg: > > > > This change makes the URL be easier to be used > > => > > This change makes the URL easier to use > > > > But that may not warrant a new patch submission, > > though, as the committer may do it himself... > > Whoops, I committed this without seeing this comment, oh well! Not really a problem ;-) It was just in case...
Marius Bakke <mbakke@fastmail.com> writes:
> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.
I reverted this temporarily to avoid having to request updated
translations for Guix 1.1.0.
It will have to wait until after the 1.1.0 release.
On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote: > Vincent Legoll <vincent.legoll@gmail.com> writes: > > LGTM, except maybe the following change to the > > commit msg: > > > > This change makes the URL be easier to be used > > => > > This change makes the URL easier to use > > > > But that may not warrant a new patch submission, > > though, as the committer may do it himself... > > Whoops, I committed this without seeing this comment, oh well! > > Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d. No worries, I actually used Vincent's suggested words in the rebase, which is the patch you applied.
Tom Zander <tomz@freedommail.ch> writes: > On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote: >> Vincent Legoll <vincent.legoll@gmail.com> writes: >> > LGTM, except maybe the following change to the >> > commit msg: >> > >> > This change makes the URL be easier to be used >> > => >> > This change makes the URL easier to use >> > >> > But that may not warrant a new patch submission, >> > though, as the committer may do it himself... >> >> Whoops, I committed this without seeing this comment, oh well! >> >> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d. > > No worries, I actually used Vincent's suggested words in the rebase, which is > the patch you applied. Oh heh, patch overload I guess! Note that the patch was temporarily reverted (I forgot to CC you in the previous message to this issue): https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e Feel free to ping this bug once 1.1.0 is out to get it re-applied. :-)
Marius Bakke <mbakke@fastmail.com> writes: > Note that the patch was temporarily reverted (I forgot to CC you in the > previous message to this issue): > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e > > Feel free to ping this bug once 1.1.0 is out to get it re-applied. :-) Finally applied in 8fa4ac5be4d5f8a1e62635842b16486832ff49f1 after a friendly ping on #guix:matrix.org :-)
From ab690e91f177e0e3efa557fc9ac72ebbc89cb0ad Mon Sep 17 00:00:00 2001 From: TomZ <tomz@freedommail.ch> Date: Sat, 14 Mar 2020 14:36:28 +0100 Subject: [PATCH] Allow double-click select of URL in status The status during an install prints download-targets. This adds a space between the URL and the '...' string trailing it so on a terminal you can just double click on the URL to select it. --- guix/status.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/status.scm b/guix/status.scm index cbea4151f2..a39d91e0dc 100644 --- a/guix/status.scm +++ b/guix/status.scm @@ -517,7 +517,7 @@ addition to build events." (newline port))) (('download-started item uri _ ...) (erase-current-line*) - (format port (info (G_ "downloading from ~a...")) uri) + (format port (info (G_ "downloading from ~a ...")) uri) (newline port)) (('download-progress item uri (= string->number size) -- 2.25.1