diff mbox series

[bug#72835,qt-team,09/38] gnu: qtmultimedia: Update to 6.7.2.

Message ID 425494b2be0fb189bbe37d7a7d68fbc0f7519479.1724775511.git.zhengjunjie@iscas.ac.cn
State New
Headers show
Series update qt6 to 6.7.2 | expand

Commit Message

Z572 Aug. 27, 2024, 4:23 p.m. UTC 
* gnu/packages/qt.scm (qtmultimedia): Update to 6.7.2.

Change-Id: I80606a9cb88a554578943d871401f4661bb29158
---
 gnu/packages/qt.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Maxim Cournoyer Sept. 13, 2024, 3:20 p.m. UTC | #1 
Hi Zheng,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

> * gnu/packages/qt.scm (qtmultimedia): Update to 6.7.2.
>
> Change-Id: I80606a9cb88a554578943d871401f4661bb29158
> ---
>  gnu/packages/qt.scm | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index cf68107d70..5b2450e41f 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -1877,13 +1877,13 @@ (define-public qtshadertools
>  (define-public qtmultimedia
>    (package
>      (name "qtmultimedia")
> -    (version "6.6.3")
> +    (version "6.7.2")
>      (source (origin
>                (method url-fetch)
>                (uri (qt-url name version))
>                (sha256
>                 (base32
> -                "1ciswpv8p71j9hwwdhfr5pmsrnizlaijp0dnyc99lk5is8qgh05y"))
> +                "1lsiarvag8lr4a1apa466xz56b1znjncy8wz5hyiv6nbb88kby4f"))
>                (modules '((guix build utils)))
>                (snippet
>                 '(begin
> @@ -1914,9 +1914,12 @@ (define-public qtmultimedia
>                ;; RHI backend. Using CPU conversion." (see:
>                ;; https://bugreports.qt.io/browse/QTBUG-123749).
>                (substitute* "tests/auto/unit/multimedia/CMakeLists.txt"
> -                (("add_subdirectory\\(qvideoframecolormanagement\\)") ""))))
> +                (("add_subdirectory\\(qvideoframecolormanagement\\)") "")
> +                ;; test timeout

That's a nitpick, but please do write complete sentences for standalone
comments, e.g. ";; The 'qmediaplayer_gstreamer' test times out."

Thanks for the updates!
Z572 Sept. 18, 2024, 2:09 a.m. UTC | #2 
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi Zheng,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>
>> * gnu/packages/qt.scm (qtmultimedia): Update to 6.7.2.
>>
>> Change-Id: I80606a9cb88a554578943d871401f4661bb29158
>> ---
>>  gnu/packages/qt.scm | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
>> index cf68107d70..5b2450e41f 100644
>> --- a/gnu/packages/qt.scm
>> +++ b/gnu/packages/qt.scm
>> @@ -1877,13 +1877,13 @@ (define-public qtshadertools
>>  (define-public qtmultimedia
>>    (package
>>      (name "qtmultimedia")
>> -    (version "6.6.3")
>> +    (version "6.7.2")
>>      (source (origin
>>                (method url-fetch)
>>                (uri (qt-url name version))
>>                (sha256
>>                 (base32
>> -                "1ciswpv8p71j9hwwdhfr5pmsrnizlaijp0dnyc99lk5is8qgh05y"))
>> +                "1lsiarvag8lr4a1apa466xz56b1znjncy8wz5hyiv6nbb88kby4f"))
>>                (modules '((guix build utils)))
>>                (snippet
>>                 '(begin
>> @@ -1914,9 +1914,12 @@ (define-public qtmultimedia
>>                ;; RHI backend. Using CPU conversion." (see:
>>                ;; https://bugreports.qt.io/browse/QTBUG-123749).
>>                (substitute* "tests/auto/unit/multimedia/CMakeLists.txt"
>> -                (("add_subdirectory\\(qvideoframecolormanagement\\)") ""))))
>> +                (("add_subdirectory\\(qvideoframecolormanagement\\)") "")
>> +                ;; test timeout
>
> That's a nitpick, but please do write complete sentences for standalone
> comments, e.g. ";; The 'qmediaplayer_gstreamer' test times out."

done.

>
> Thanks for the updates!
diff mbox series

Patch

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index cf68107d70..5b2450e41f 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1877,13 +1877,13 @@  (define-public qtshadertools
 (define-public qtmultimedia
   (package
     (name "qtmultimedia")
-    (version "6.6.3")
+    (version "6.7.2")
     (source (origin
               (method url-fetch)
               (uri (qt-url name version))
               (sha256
                (base32
-                "1ciswpv8p71j9hwwdhfr5pmsrnizlaijp0dnyc99lk5is8qgh05y"))
+                "1lsiarvag8lr4a1apa466xz56b1znjncy8wz5hyiv6nbb88kby4f"))
               (modules '((guix build utils)))
               (snippet
                '(begin
@@ -1914,9 +1914,12 @@  (define-public qtmultimedia
               ;; RHI backend. Using CPU conversion." (see:
               ;; https://bugreports.qt.io/browse/QTBUG-123749).
               (substitute* "tests/auto/unit/multimedia/CMakeLists.txt"
-                (("add_subdirectory\\(qvideoframecolormanagement\\)") ""))))
+                (("add_subdirectory\\(qvideoframecolormanagement\\)") "")
+                ;; test timeout
+                (("add_subdirectory\\(qmediaplayer_gstreamer\\)") ""))))
           (add-before 'check 'prepare-for-tests
             (lambda _
+              (setenv "HOME" (getcwd))
               (setenv "QT_QPA_PLATFORM" "offscreen")))
           (add-after 'install 'delete-installed-tests
             (lambda _