| Message ID | 4197e42a7d4b050eec4b2615afe66174697e3693.1746696396.git.csantosb@inventati.org |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D857027BC4A; Thu, 8 May 2025 10:28:23 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id DABED27BC49 for <patchwork@mira.cbaines.net>; Thu, 8 May 2025 10:28:21 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1uCxY1-0001L7-81; Thu, 08 May 2025 05:28:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uCxXx-0001En-6x for guix-patches@gnu.org; Thu, 08 May 2025 05:28:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uCxXv-0006wk-GE for guix-patches@gnu.org; Thu, 08 May 2025 05:28:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=KQl2V/c5U3Y9zOa5XbHcp66j+t5nyt0h547V/LwArSI=; b=QYg71nc6ez9B93WRHehTvk2/bejYYcJZecIGynJ4FM4liEJ+LX+nItf9U5C2mO5yQ675vtZnTGj0MaZBrINhrJzKuhedLT5HFOWvUWl/R+gJ8JY5it2drlgQwS0NGit8Uchn49K5g1wBJfCtZaWevlyj2Xv+LOe1ExmS93fqNDeSct06XWaTMdt/cUj5hndHVwLDmUk/Ik3K0JjxrGr71jwY5rc5jzqyUbABpuC3AG/qjyV9YcT/sMQtwYB1rlqEtCj6OeR+8WBSnYt6yBVzzqXNCpQnPy7w0LnJYVR4FeuZBLKVrKyjSoFLao5HcOO1PzUl2nMni8l2FEShhXTUAg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1uCxXu-0002xZ-2g; Thu, 08 May 2025 05:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#78313] [PATCH electronics-team v2] gnu: Add python-pydigitalwavetools. Resent-From: Cayetano Santos <csantosb@inventati.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: csantosb@inventati.org, ekaitz@elenq.tech, gabriel@erlikon.ch, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Thu, 08 May 2025 09:28:01 +0000 Resent-Message-ID: <handler.78313.B.174669645211319@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78313 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 78297@debbugs.gnu.org Cc: 78313@debbugs.gnu.org, Cayetano Santos <csantosb@inventati.org>, Ekaitz Zarraga <ekaitz@elenq.tech>, Gabriel Wicki <gabriel@erlikon.ch>, Maxim Cournoyer <maxim.cournoyer@gmail.com> X-Debbugs-Original-Cc: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> X-Debbugs-Original-Xcc: Cayetano Santos <csantosb@inventati.org>, Ekaitz Zarraga <ekaitz@elenq.tech>, Gabriel Wicki <gabriel@erlikon.ch>, Maxim Cournoyer <maxim.cournoyer@gmail.com> Received: via spool by submit@debbugs.gnu.org id=B.174669645211319 (code B ref -1); Thu, 08 May 2025 09:28:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 May 2025 09:27:32 +0000 Received: from localhost ([127.0.0.1]:54180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1uCxXP-0002wV-Mf for submit@debbugs.gnu.org; Thu, 08 May 2025 05:27:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59116) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <csantosb@inventati.org>) id 1uCxXO-0002w7-9y for submit@debbugs.gnu.org; Thu, 08 May 2025 05:27:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@inventati.org>) id 1uCxXI-0008P0-T3 for guix-patches@gnu.org; Thu, 08 May 2025 05:27:24 -0400 Received: from devianza.investici.org ([2c0f:f930:0:4::108]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <csantosb@inventati.org>) id 1uCxXG-0006go-UL for guix-patches@gnu.org; Thu, 08 May 2025 05:27:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1746696439; bh=KQl2V/c5U3Y9zOa5XbHcp66j+t5nyt0h547V/LwArSI=; h=From:To:Cc:Subject:Date:From; b=qBSIbtSlFiKnAGh3eI72hRmgsW8qezUaJu+M70C/Yhzav3z6RoBS2bgnrWlQVGd0s 0QmhdbZCtjJLYDfO3KAabMPWe5Lp6WwkdlVI1/rGEngTIfouO4Jg0xoUy9NQ6mnyc3 KMadcJH1ZM9DKAREetQ3Gd3sqMBjxL3fO7xaGomY= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4ZtRc71pYdz6vMh; Thu, 8 May 2025 09:27:19 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZtRc70Fr1z6vMK; Thu, 8 May 2025 09:27:18 +0000 (UTC) Date: Thu, 8 May 2025 11:26:36 +0200 Message-ID: <4197e42a7d4b050eec4b2615afe66174697e3693.1746696396.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2c0f:f930:0:4::108; envelope-from=csantosb@inventati.org; helo=devianza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Cayetano Santos <csantosb@inventati.org> X-ACL-Warn: , Cayetano Santos via Guix-patches <guix-patches@gnu.org> From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
[bug#78313,electronics-team,v2] gnu: Add python-pydigitalwavetools.
|
|
Commit Message
Cayetano Santos
May 8, 2025, 9:26 a.m. UTC
From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org>
* gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
---
gnu/packages/electronics.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
base-commit: 01ca654387c64265b310f2887d884cd7ec7c4f0a
--
2.49.0
Comments
Hi Cayetano, Cayetano Santos <csantosb@inventati.org> writes: > From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> > > * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable. [...] > + (home-page "https://github.com/Nic30/pyDigitalWaveTools/") > + (synopsis "Library to manipulate digital wave files.") > + (description > + "Pydigitalwavetools is a Python library to parse, write and format > +@acronym{VCD, Value Champ Dump} and other digital wave files.") > + (license license:expat))) Are you sure about VCD being 'Value Champ Dump' and not Video CD as I thought? The later seemed more sensical to me, this being about some digital audio files :-). You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'. The synopsis should not end with a '.'; please run './pre-inst-env guix lint python-pydigitalwavetools' to catch these things. Could you send a v3?
>lun. 12 mai 2025 at 21:34, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote: > Hi Cayetano, > > Cayetano Santos <csantosb@inventati.org> writes: > >> From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> >> >> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable. > > [...] > >> + (home-page "https://github.com/Nic30/pyDigitalWaveTools/") >> + (synopsis "Library to manipulate digital wave files.") >> + (description >> + "Pydigitalwavetools is a Python library to parse, write and format >> +@acronym{VCD, Value Champ Dump} and other digital wave files.") >> + (license license:expat))) > > Are you sure about VCD being 'Value Champ Dump' and not Video CD as I > thought? The later seemed more sensical to me, this being about some > digital audio files :-). Yes. Where exactly do you see any reference to audio in here ? See, for example https://github.com/Nic30/pyDigitalWaveTools/?tab=readme-ov-file#related-open-source This is what VCD is all about: https://pyvcd.readthedocs.io/en/latest/vcd.gtkw.html > You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'. Yes, just because this has nothing to do with WAV audio format. Is this comment still relevant for v3 ? > The synopsis should not end with a '.'; please run './pre-inst-env guix > lint python-pydigitalwavetools' to catch these things. You’re right, my bad ! C.
Hi Cayetano, Cayetano Santos <csantosb@inventati.org> writes: >>lun. 12 mai 2025 at 21:34, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote: > >> Hi Cayetano, >> >> Cayetano Santos <csantosb@inventati.org> writes: >> >>> From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org> >>> >>> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable. >> >> [...] >> >>> + (home-page "https://github.com/Nic30/pyDigitalWaveTools/") >>> + (synopsis "Library to manipulate digital wave files.") >>> + (description >>> + "Pydigitalwavetools is a Python library to parse, write and format >>> +@acronym{VCD, Value Champ Dump} and other digital wave files.") >>> + (license license:expat))) >> >> Are you sure about VCD being 'Value Champ Dump' and not Video CD as I >> thought? The later seemed more sensical to me, this being about some >> digital audio files :-). > > Yes. Where exactly do you see any reference to audio in here ? I simply assumed it was, with all the Wave references in the tool name and description (I assumed it had to do with the WAV audio format). > See, for example > > https://github.com/Nic30/pyDigitalWaveTools/?tab=readme-ov-file#related-open-source Thanks. I see they define VCD as 'Value Change Dump' though, not 'Value Champ Dump'. After reading [0], I now understand that VCDs are "a standardized ASCII format used to store simulation data from Verilog and other hardware description languages". Perhaps that could be added to the description; as it was useful to provide proper context to me. We should assume people reading these package descriptions know nothing about the local domain jargon. [0] https://www.chipverify.com/verilog/verilog-vcd > This is what VCD is all about: > > https://pyvcd.readthedocs.io/en/latest/vcd.gtkw.html > >> You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'. > > Yes, just because this has nothing to do with WAV audio format. Is this > comment still relevant for v3 ? I see. Not relevant then.
diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm index da37a9fb33..0cff76786b 100644 --- a/gnu/packages/electronics.scm +++ b/gnu/packages/electronics.scm @@ -610,6 +610,31 @@ (define-public python-edalize some tool-specific options are set.") (license license:bsd-2))) +(define-public python-pydigitalwavetools + (package + (name "python-pydigitalwavetools") + (version "1.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Nic30/pyDigitalWaveTools/") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis")))) + (build-system pyproject-build-system) + (native-inputs + (list python-pytest + python-setuptools + python-wheel)) + (home-page "https://github.com/Nic30/pyDigitalWaveTools/") + (synopsis "Library to manipulate digital wave files.") + (description + "Pydigitalwavetools is a Python library to parse, write and format +@acronym{VCD, Value Champ Dump} and other digital wave files.") + (license license:expat))) + (define-public python-surf (package (name "python-surf")