diff mbox series

[bug#71580,v2] doc: Add message for common error about make check-system

Message ID 3e0cb737e55694fee8d7e3c515845e4c4cc20c76.1718672549.git.richard@freakingpenguin.com
State New
Headers show
Series [bug#71580,v2] doc: Add message for common error about make check-system | expand

Commit Message

Richard Sent June 18, 2024, 1:02 a.m. UTC 
* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds were
run with different work trees. See https://issues.guix.gnu.org/47573.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
---
Adjusted the phrasing. If we think it's best to hold on merging this
until we determine how common of an occurrence this is or (better yet)
resolve the issue entirely, there's no complaints by me. I'll leave
that decision up to you all. :)

 doc/contributing.texi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)


base-commit: b993f4735d41e690dbafb8ee2e17fce996a8cf20

Comments

Maxim Cournoyer June 18, 2024, 12:13 p.m. UTC | #1 
Richard Sent <richard@freakingpenguin.com> writes:

> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
> may need to be run before running make check-system when previous builds were
> run with different work trees. See https://issues.guix.gnu.org/47573.
>
> Change-Id: I4b68d3a05f1425505816db969284487d725840d6

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
pelzflorian June 19, 2024, 8:48 a.m. UTC | #2 
I cannot push; my computer broke; but this patch should not be stuck because of me.  However, it is not clear why `make clean-go' helps.  I tried to switch branches, but cannot reproduce the issue and do not get this kind of error message.

Regards,
Florian
Maxim Cournoyer June 24, 2024, 4:09 a.m. UTC | #3 
Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Richard Sent <richard@freakingpenguin.com> writes:
>
>> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
>> may need to be run before running make check-system when previous builds were
>> run with different work trees. See https://issues.guix.gnu.org/47573.
>>
>> Change-Id: I4b68d3a05f1425505816db969284487d725840d6
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Applied locally.  Will push shortly.
diff mbox series

Patch

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..6f0acc8c1f 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@  Running the Test Suite
 substitutes are available for their dependencies (@pxref{Substitutes}).
 Some of them require a lot of storage space to hold VM images.
 
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistencies in the work tree from previous builds.  To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
 Again in case of test failures, please send @email{bug-guix@@gnu.org}
 all the details.