[bug#66689,gnome-team,v4,05/17] gnu: appstream-glib: Update style.
Commit Message
* gnu/packages/glib.scm (appstream-glib) [native-inputs]: Drop labels, sort.
[propagated-inputs]: Drop labels.
[inputs]: Drop labels, sort.
[arguments]: Convert to list of G-Expressions.
[#:phases 'patch-tests]: Remove trailing #t.
[description]: Break long line.
Change-Id: I504df11ec6fc5b9d9fe70e4e32e7910f93eeb81e
---
gnu/packages/glib.scm | 64 ++++++++++++++++++++++---------------------
1 file changed, 33 insertions(+), 31 deletions(-)
Comments
Am Freitag, dem 27.10.2023 um 18:42 +0200 schrieb Vivien Kraus:
> * gnu/packages/glib.scm (appstream-glib) [native-inputs]: Drop
> labels, sort.
> [propagated-inputs]: Drop labels.
> [inputs]: Drop labels, sort.
Should be
[inputs]: Drop labels. Sort alphabetically.
You have that horizontal space :)
> [arguments]: Convert to list of G-Expressions.
> [#:phases 'patch-tests]: Remove trailing #t.
> [description]: Break long line.
>
> Change-Id: I504df11ec6fc5b9d9fe70e4e32e7910f93eeb81e
> ---
Otherwise SGTM, but we still have the CI waiting thing going on.
Cheers
@@ -1305,42 +1305,44 @@ (define-public appstream-glib
"15lbrmyx94cf6p6svq02yiskh31xidq092c711pqs16mml06a9bi"))))
(build-system meson-build-system)
(native-inputs
- `(("gettext" ,gettext-minimal)
- ("gsettings" ,gsettings-desktop-schemas) ; for ‘org.gnome.system.proxy’
- ("glib:bin" ,glib "bin") ; for glib-compile-resources
- ("pkg-config" ,pkg-config)))
+ (list gettext-minimal
+ `(,glib "bin") ;for glib-compile-resources
+ gsettings-desktop-schemas ;for ‘org.gnome.system.proxy’
+ pkg-config))
(propagated-inputs
- `(("gcab" ,gcab) ; for .pc file
- ("gdk-pixbuf" ,gdk-pixbuf) ; for .pc file
- ("libuuid" ,util-linux "lib"))) ; for .pc file
+ (list gcab ;for .pc file
+ gdk-pixbuf ;same
+ `(,util-linux "lib"))) ;libuuid, for .pc file
(inputs
- `(("glib" ,glib)
- ("gperf" ,gperf)
- ("gtk+" ,gtk+)
- ("json-glib" ,json-glib)
- ("libarchive" ,libarchive)
- ("curl" ,curl)))
+ (list curl
+ gperf
+ gtk+
+ json-glib
+ libarchive
+ glib))
(arguments
- `(#:configure-flags
- (list "-Ddep11=false"
- "-Dintrospection=false" ; avoid g-ir-scanner dependency
- "-Drpm=false"
- "-Dstemmer=false")
- #:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'patch-tests
- (lambda _
- (substitute* "libappstream-glib/as-self-test.c"
- (("g_test_add_func.*as_test_store_local_appdata_func);") ""))
- #t))
- (add-before 'check 'set-home
- (lambda _
- ;; Some tests want write access there.
- (setenv "HOME" "/tmp"))))))
+ (list
+ #:configure-flags
+ #~(list "-Ddep11=false"
+ "-Dintrospection=false" ; avoid g-ir-scanner dependency
+ "-Drpm=false"
+ "-Dstemmer=false")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-tests
+ (lambda _
+ (substitute* "libappstream-glib/as-self-test.c"
+ (("g_test_add_func.*as_test_store_local_appdata_func);") ""))))
+ (add-before 'check 'set-home
+ (lambda _
+ ;; Some tests want write access there.
+ (setenv "HOME" "/tmp"))))))
(home-page "https://github.com/hughsie/appstream-glib")
(synopsis "Library for reading and writing AppStream metadata")
- (description "This library provides objects and helper methods to help
-reading and writing @uref{https://www.freedesktop.org/wiki/Distributions/AppStream,AppStream}
+ (description
+ "This library provides objects and helper methods to help
+reading and writing
+@uref{https://www.freedesktop.org/wiki/Distributions/AppStream,AppStream}
metadata.")
(license license:lgpl2.1+)))