From patchwork Sun Nov 21 17:41:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liliana Marie Prikler X-Patchwork-Id: 34725 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B6BD227BBE3; Sun, 21 Nov 2021 17:51:21 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7D8A527BBE1 for ; Sun, 21 Nov 2021 17:51:21 +0000 (GMT) Received: from localhost ([::1]:45794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moqzn-0002Ff-UF for patchwork@mira.cbaines.net; Sun, 21 Nov 2021 12:51:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqzX-0002FV-SE for guix-patches@gnu.org; Sun, 21 Nov 2021 12:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moqzV-0005VL-Vn for guix-patches@gnu.org; Sun, 21 Nov 2021 12:51:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moqzV-00026f-Sg for guix-patches@gnu.org; Sun, 21 Nov 2021 12:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Nov 2021 17:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52022@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16375170488074 (code B ref -1); Sun, 21 Nov 2021 17:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2021 17:50:48 +0000 Received: from localhost ([127.0.0.1]:45954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moqzI-00026A-HV for submit@debbugs.gnu.org; Sun, 21 Nov 2021 12:50:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:47132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moqzH-000263-Ic for submit@debbugs.gnu.org; Sun, 21 Nov 2021 12:50:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqzH-000210-B8 for guix-patches@gnu.org; Sun, 21 Nov 2021 12:50:47 -0500 Received: from [2a00:1450:4864:20::334] (port=42742 helo=mail-wm1-x334.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moqzF-0005UQ-8Z for guix-patches@gnu.org; Sun, 21 Nov 2021 12:50:47 -0500 Received: by mail-wm1-x334.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so11725842wmd.1 for ; Sun, 21 Nov 2021 09:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:to:content-transfer-encoding:message-id :mime-version; bh=AYiDzX+J2rATuEghH0ZztUrNQmW5LVWvE2DL4cOjnxw=; b=TtERnQlKPI5+VuW7VnbeD48269ww4Pvtb/suFIaAKd9vnOM7Ufow0M0/TtmvsfDKqd 8subbHN653JinLeeV8EvEjORZCM3BE+uzKm3fhT979oDKuwYEb+ZcBexJ+HOWv+yBTg9 M37nMO1bb1/C/2o6Xy5XT8soBDt2SiyHMz2CmtDI8iREep+gkMLuLexigUpy3moCATua vS10Hzr4ytNItSLXjkWJ3oM+3hj3SpG8P6CjnUFfsJUcUzXWdi+EApy9CcDIM46dx7eL TqtOESjYiJ0B8rlbGqeaBCb2BC1LBeISSjXvIK/2qJr87vMZUM2ccHa+KCroLgJJnn2I ldIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:to:content-transfer-encoding :message-id:mime-version; bh=AYiDzX+J2rATuEghH0ZztUrNQmW5LVWvE2DL4cOjnxw=; b=3KB8clBP1kJ4pZN5Kc+ud1Ct9ljTgCm40Ek2PtIBwQ8iG/tV8PIJkq8Yhu5XfNoU1n gl152B98HrbajyPCbjonBWtjaVSAIpR0OC61Duf1yxipoGGrTsjDCZNYf7/YYYeYV2mU Ub7lNVltQmfgN68vo+QxJArh10nlg3JIfOSRcqXuJ6L+zpOMsxPQ8cjVgYj3HMfaFLUn qQOU5VPNgnp+44aRUBJJ7+aAY8V0T6ri7IMx3GhuNsqvAEI2ReUMK3568/KEbNiR5WhS DTJk1zPIF2KSUu7NgyJNbx0m/bXgl9xtKBJGtiUEFb+Sb8/8Cznn9S88ZkNyZCMic699 y8TQ== X-Gm-Message-State: AOAM532OTtWOp7bwK8PgLIFKCSNLn9okHZH6He9jHjB/CINiZqxM+n28 sM2sKcuPfW8glDfaes2pOS8hSnUPeIA= X-Google-Smtp-Source: ABdhPJxhbpipHFapHhUmOd+w+T4I46OUI3f+kTl/P5fB+tLUPOb7z2tvJm9LP7bV3b/Xzutn1BWwkw== X-Received: by 2002:a7b:c2a1:: with SMTP id c1mr21467627wmk.112.1637517043293; Sun, 21 Nov 2021 09:50:43 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l4sm6352443wrv.94.2021.11.21.09.50.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Nov 2021 09:50:42 -0800 (PST) From: Liliana Marie Prikler Date: Sun, 21 Nov 2021 18:41:28 +0100 Message-ID: <3521e930d03c2eb55ee37074565d4218a28c73ad.camel@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::334 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=liliana.prikler@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches When using this gst-plugins/selection without setting configure-flags, the existing flags are simply inherited. This leads to an issue with unquote-splicing when looking at quoted lists, e.g. as used by gst-plugins-bad. * gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-flags]: Only splice user-provided configure-flags, simply unquote those from existing packages. Reported-by: unmatched-paren, nckx (IRC) --- gnu/packages/gstreamer.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 2927055240..f7d0808b98 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -924,13 +924,15 @@ (define-public gst-plugins/selection (package/inherit pkg (arguments (substitute-keyword-arguments (package-arguments pkg) - ((#:configure-flags flags `(,@(or configure-flags '()))) + ((#:configure-flags flags ''()) `(append (list ,@(map (lambda (plugin) (string-append "-D" plugin "=enabled")) plugins)) - (list ,@(or configure-flags flags)))) + ,(if configure-flags + `(list ,@configure-flags) + flags))) ((#:phases phases) `(modify-phases ,phases (add-after 'unpack 'disable-auto-plugins