mbox

[bug#36146,0/4] Add various Emacs packages

Message ID 33ae2269-19b1-4122-845e-dacc6533f72d@www.fastmail.com
Headers show

Message

Alex Griffin June 9, 2019, 2:07 p.m. UTC
This patch series adds emacs-elfeed-org, emacs-restart-emacs, emacs-mixed-pitch, and emacs-solaire-mode.

Comments

Oleg Pykhalov June 10, 2019, 9:02 p.m. UTC | #1
Hello Alex,

Thank you for this patch series.

"Alex Griffin" <a@ajgrf.com> writes:

> This patch series adds emacs-elfeed-org, emacs-restart-emacs,
> emacs-mixed-pitch, and emacs-solaire-mode.

melpa.org URLs are not stable: files get modified in place.  For that
reason, we usually refer directly to upstream VCS repositories.  Could
you modify the patch accordingly?

Also running tests for ‘emacs-elfeed-org’ would be a great improvement.

‘emacs-mixed-pitch’ probably has a typo in synopsis - “Mix variable-”.

Oleg.
Alex Griffin June 10, 2019, 11:58 p.m. UTC | #2
On Mon, Jun 10, 2019, at 9:03 PM, Oleg Pykhalov wrote:
> melpa.org URLs are not stable: files get modified in place.  For that
> reason, we usually refer directly to upstream VCS repositories.  Could
> you modify the patch accordingly?

I didn't know that, I'll get right on it.

> Also running tests for ‘emacs-elfeed-org’ would be a great improvement.

Elfeed-org uses Cask for testing, just like a great many other Emacs packages. As far as I can tell, though, it hasn't been packaged for Guix yet.

> ‘emacs-mixed-pitch’ probably has a typo in synopsis - “Mix variable-”.

No typo. A phrase like "variable- and mixed-pitch" is correct and commonly understood to be short for "variable-pitch and mixed-pitch".