diff mbox series

[bug#66832] build-system: clojure: Use the standard error regarding cross builds.

Message ID 3217ef7510266e353bae0e9f44c7d4a73517c4c9.1698655414.git.mail@cbaines.net
State New
Headers show
Series [bug#66832] build-system: clojure: Use the standard error regarding cross builds. | expand

Commit Message

Christopher Baines Oct. 30, 2023, 8:43 a.m. UTC 
Rather than raising an error in the build system.

* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.

Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
 guix/build-system/clojure.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9

Comments

Ludovic Courtès Nov. 15, 2023, 5:19 p.m. UTC | #1 
Christopher Baines <mail@cbaines.net> skribis:

> Rather than raising an error in the build system.
>
> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
> than calling error.
>
> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e

LGTM!
Christopher Baines Nov. 20, 2023, 3:10 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> Rather than raising an error in the build system.
>>
>> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
>> than calling error.
>>
>> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
>
> LGTM!

Great, I've pushed this to master as
98ae8076435c74f90ad8ad30557963d2caa273c2.

Chris
diff mbox series

Patch

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@  (define* (lower name
                             #:clojure #:jdk #:zip)))
 
     (if target
-        (error "No cross-compilation for clojure-build-system yet: LOWER"
-               target) ; FIXME
+        #f                              ; FIXME: No cross-compilation for
+                                        ; clojure-build-system yet
         (bag (name name)
              (system system)
              (host-inputs `(,@(if source