Message ID | 26ccc41a0b59e854f261e65cfee65803e78746f7.camel@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BC23127BBEB; Thu, 15 Dec 2022 23:35:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B426A27BBE9 for <patchwork@mira.cbaines.net>; Thu, 15 Dec 2022 23:35:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1p5xkm-0007ri-MM; Thu, 15 Dec 2022 18:35:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1p5xkk-0007r4-Qb for guix-patches@gnu.org; Thu, 15 Dec 2022 18:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1p5xkk-0000IG-Fk for guix-patches@gnu.org; Thu, 15 Dec 2022 18:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1p5xkk-0005N6-As for guix-patches@gnu.org; Thu, 15 Dec 2022 18:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60108] [PATCH] gnu: musescore: Fix build. Resent-From: Liliana Marie Prikler <liliana.prikler@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Dec 2022 23:35:02 +0000 Resent-Message-ID: <handler.60108.B.167114728820623@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60108 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60108@debbugs.gnu.org Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167114728820623 (code B ref -1); Thu, 15 Dec 2022 23:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Dec 2022 23:34:48 +0000 Received: from localhost ([127.0.0.1]:45586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1p5xkW-0005MZ-3c for submit@debbugs.gnu.org; Thu, 15 Dec 2022 18:34:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:50252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@gmail.com>) id 1p5xkS-0005MR-Tp for submit@debbugs.gnu.org; Thu, 15 Dec 2022 18:34:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <liliana.prikler@gmail.com>) id 1p5xkS-0007lZ-O9 for guix-patches@gnu.org; Thu, 15 Dec 2022 18:34:44 -0500 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <liliana.prikler@gmail.com>) id 1p5xkQ-0000Fj-W8 for guix-patches@gnu.org; Thu, 15 Dec 2022 18:34:44 -0500 Received: by mail-ed1-x543.google.com with SMTP id a16so1396284edb.9 for <guix-patches@gnu.org>; Thu, 15 Dec 2022 15:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:content-transfer-encoding:cc:to:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=deKouVntJhkXFBBveQWjeI+2qAAKg8aUSU5Q7xVYfSU=; b=XYRLbBIAdoR2xv7UYcktdqHZK5kQ8tz3meK7Vqpw2RN06B1Te0e8wkmNenskXUIMPm szeTxYy0a/hHo9pXPu8fkPC2e4FLRmKb4UF1F1wT8j8BMScfMdf437dDo1We0bXj1faG hI5eZsiYT24YPMvolvhID2HOSwZaSKjsBUs/KR9BDcbHBdhzrNYmHwSTWn4iI98Nbu6R kKG3ChLVQ17IAlNmUL6xdRdQ9Z72Mu0lvPBsVmMvZNjSRG7IuiyHl6upGVYD0/gSNuiB GqPkBKxbsnBb1fOmqBrAat4ov9htYDtjyZxSq+Y39QU7Jakfb69RcVFxaTgGvIxaWnxj MIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:content-transfer-encoding:cc:to:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=deKouVntJhkXFBBveQWjeI+2qAAKg8aUSU5Q7xVYfSU=; b=bWriLBYxAbXQceo4mqKZ3ZsIPvDoIJvs7eanNpSVw8+CR+rX0+y4bqikd6moxfDtix dnXVgmOYy15swqsJKHAWwo6rBOscSMqbu9rzhEk4ba9KYaKwP9/W4ShP01Acr+48JDia a7aPRtfOnWwpm/R3eXIsTk5h/M2h2ImuGx2aFFPWjRVzccqXP8staiiPdXae2xiMs21b htR5V776y302tqmS7GEXvnaYAmn2vDLoZYB1A2+bOiaIwB+xen4wgjvjS9EzQhaiUYYH zXMOvchiO4bNFFwSRE+ll5//dbX49T/OugnmIxY2H04d47JJPCi2zOSTNgEIXJga/iyB VoGA== X-Gm-Message-State: ANoB5plNPQYSNNXKb2zszBD6Laqf81Raa3T5k0K78XwU1aKHYR0ZtUqJ AjhchfDLHDZ5J6sRzz72yIc/xJrXvjI= X-Google-Smtp-Source: AA0mqf6MjGbfc6gSfJJf/7E2E2n/E28fuBI80XKXnxtD2eEQy2msDqh2hkDgT4rkSAlfpOL3vArscg== X-Received: by 2002:a05:6402:1711:b0:46c:ec97:b453 with SMTP id y17-20020a056402171100b0046cec97b453mr24695953edu.12.1671147280929; Thu, 15 Dec 2022 15:34:40 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i3-20020a05640200c300b0046bf4935323sm245018edu.30.2022.12.15.15.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 15:34:40 -0800 (PST) From: Liliana Marie Prikler <liliana.prikler@gmail.com> Date: Fri, 16 Dec 2022 00:31:00 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID: <26ccc41a0b59e854f261e65cfee65803e78746f7.camel@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::543; envelope-from=liliana.prikler@gmail.com; helo=mail-ed1-x543.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#60108] gnu: musescore: Fix build.
|
|
Commit Message
Liliana Marie Prikler
Dec. 15, 2022, 11:31 p.m. UTC
* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and associated install actions. [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”. --- gnu/packages/music.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Comments
Hello, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and > associated install actions. > [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”. FWIW, qa.guix.gnu.org says it looks good to it. Regards,
I tried this patch, but unfortunately MuseScore crashes on startup, saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1: module "QtQuick.Dialogs" is not installed I checked the source, and QtQuick.Dialogs is indeed imported in a bunch of QML files. I don’t know much about qt, so I’m not sure how to proceed. I tried to copy the package for qtquick-controls to qtquick-dialogs, but guix can’t find any source for that. Best regards, Vivien
Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit : > I tried this patch, but unfortunately MuseScore crashes on startup, > saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1: > module "QtQuick.Dialogs" is not installed Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the issue :)
Hello, Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes: > Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit : >> I tried this patch, but unfortunately MuseScore crashes on startup, >> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1: >> module "QtQuick.Dialogs" is not installed > > Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the > issue :) Would you mind sending a patch including this, so that we can apply it and close the issue? Regards,
Le lundi 19 décembre 2022 à 16:40 +0100, Nicolas Goaziou a écrit : > Would you mind sending a patch including this, so that we can apply > it > and close the issue? I think I messed things up and the original "From:" header is now in the commit message, sorry. Can you fix it on your end? I’m not sure I know how to keep the patch author information while still being able to send it. Vivien
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 614eb57791..0d7fb21701 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4787,14 +4787,19 @@ (define-public musescore (base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr")) (modules '((guix build utils))) (snippet - ;; Remove unused libraries. '(begin + ;; Remove unused libraries... (for-each delete-file-recursively - '("thirdparty/freetype")))))) + '("thirdparty/freetype")) + ;; ... and precompiled binaries. + (delete-file-recursively "src/diagnostics/crashpad_handler") + (substitute* "src/diagnostics/CMakeLists.txt" + (("install") "#install")))))) (build-system qt-build-system) (arguments `(#:configure-flags `("-DDOWNLOAD_SOUNDFONT=OFF" + "-DBUILD_DIAGNOSTICS=OFF" "-DMUSESCORE_BUILD_CONFIG=release" "-DUSE_SYSTEM_FREETYPE=ON") ;; There are tests, but no simple target to run. The command used to