From patchwork Sat Nov 18 06:49:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hilton Chain X-Patchwork-Id: 56599 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 04DD327BBE9; Sat, 18 Nov 2023 06:51:39 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6376F27BBE2 for ; Sat, 18 Nov 2023 06:51:38 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4FAY-0002CT-Aq; Sat, 18 Nov 2023 01:51:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4FAU-0002BV-EO for guix-patches@gnu.org; Sat, 18 Nov 2023 01:51:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4FAT-00036P-Un for guix-patches@gnu.org; Sat, 18 Nov 2023 01:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4FAU-0003ol-1o; Sat, 18 Nov 2023 01:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66718] [PATCH v2 1/6] gnu: mbedtls-for-hiawatha: Use inherited source. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: hako@ultrarare.space, guix-patches@gnu.org Resent-Date: Sat, 18 Nov 2023 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66718 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66718@debbugs.gnu.org Cc: Hilton Chain , Hilton Chain X-Debbugs-Original-Xcc: Hilton Chain Received: via spool by 66718-submit@debbugs.gnu.org id=B66718.170029023114568 (code B ref 66718); Sat, 18 Nov 2023 06:51:02 +0000 Received: (at 66718) by debbugs.gnu.org; 18 Nov 2023 06:50:31 +0000 Received: from localhost ([127.0.0.1]:47639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4F9y-0003mu-KH for submit@debbugs.gnu.org; Sat, 18 Nov 2023 01:50:30 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:40580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4F9v-0003mk-Sm for 66718@debbugs.gnu.org; Sat, 18 Nov 2023 01:50:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1700290021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZWPIN24UGpevlzNDJZPF3puhBEEbkwyVGZxllKctyKI=; b=xVphbK/CJilUmc27mfKVQD6P48fA8G0LceomMLzvqo1Sz3aY2PRkIERlrK0xg2jbcm/L3V dUAyKLGq9OQ2nWJbEkAc6TOhTymjjgGJ2Lsfd78DxnwcmihIOYv19WCvNEUnARJiCdy7kx 56nfO/qaD8JcRhs6tv2cSmQtLBlxZ18kVU1dhED/2930mDPpeWyOi9PgQRFrUVp2BEjRsz kfDeS5ZPuW7HZBgte0GiHPioT+vWjSl/Ke3Q9l7Mr+n33kcZFQ4GpT83PWwS1jQAtprl/A agGSYrEOtdhYgmIkBMwnQtWKvxaapY/q4IyycN+rELWm4yXggiV9/YyDOsBWpw== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Date: Sat, 18 Nov 2023 14:49:13 +0800 Message-ID: <25db53767b5c4d1af4e2f1e8a7b86a27678a0779.1700289538.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Spamd-Bar: --- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches X-Patchwork-Original-From: Hilton Chain via Guix-patches via From: Hilton Chain Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/tls.scm (mbedtls-for-hiawatha): Use inherited source. [arguments]<#:phases>: Keep "-Wformat-signedness". Change-Id: I562ae6533b518a853b9b59f8fb69c0135364277f --- gnu/packages/tls.scm | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm index 6a0aaf7f14..37650f632d 100644 --- a/gnu/packages/tls.scm +++ b/gnu/packages/tls.scm @@ -989,8 +989,6 @@ (define-public perl-crypt-openssl-random (define-public mbedtls-apache (package (name "mbedtls-apache") - ;; XXX Check whether ‘-Wformat-signedness’ still breaks mbedtls-for-hiawatha - ;; when updating. (version "2.28.0") (source (origin @@ -1027,26 +1025,6 @@ (define-public mbedtls-for-hiawatha (hidden-package (package (inherit mbedtls-apache) - (name "mbedtls-apache") - (version "2.26.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/ARMmbed/mbedtls") - (commit (string-append "mbedtls-" version)))) - (sha256 - (base32 "0scwpmrgvg6q7rvqkc352d2fqlsx0aylcbyibcp1f1rsn8iiif2m")) - (file-name (git-file-name name version)) - (modules '((guix build utils))) - (snippet - '(begin - ;; Can be removed with the next version. - ;; Reduce level of format truncation warnings due to false positives. - ;; https://github.com/ARMmbed/mbedtls/commit/2065a8d8af27c6cb1e40c9462b5933336dca7434 - (substitute* "CMakeLists.txt" - (("Wformat-truncation=2") "Wformat-truncation")) - #t)))) (arguments (substitute-keyword-arguments (package-arguments mbedtls-apache) ((#:phases phases) @@ -1057,9 +1035,6 @@ (define-public mbedtls-for-hiawatha (invoke "scripts/config.pl" "set" feature)) (list "MBEDTLS_THREADING_C" "MBEDTLS_THREADING_PTHREAD")) - ;; XXX The above enables code that breaks with -Werror… - (substitute* "CMakeLists.txt" - ((" -Wformat-signedness") "")) #t))))))))) (define-public dehydrated