[bug#78066,v2,5/5] gnu: fail2ban: Improve style.

Message ID 20250427090915.11846-6-ngraves@ngraves.fr
State New
Headers
Series Update fail2ban. |

Commit Message

Nicolas Graves April 27, 2025, 9:08 a.m. UTC
  * gnu/packages/admin.scm (fail2ban)[arguments]<phases>: Rewrite phase
'disable-some-tests.
---
 gnu/packages/admin.scm | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)
  

Patch

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 25bce63aaf..777d0abb47 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -6299,23 +6299,19 @@  (define-public fail2ban
                  "'usr/share/doc/fail2ban'"))))
           (add-after 'unpack 'disable-some-tests
             (lambda _
-              (define (make-suite str)
-                (string-append "tests.addTest\\(loadTests\\(" str "\\)\\)"))
+              (define (make-suite-regex tests)
+                (string-append "tests.addTest\\(loadTests\\(("
+                               (string-join tests "|")
+                               ")\\)\\)"))
               ;; disable tests performing unacceptable side-effects
               (substitute* "fail2ban/tests/utils.py"
-                (((make-suite "actiontestcase.CommandActionTest"))
-                 "")
-                (((make-suite "misctestcase.SetupTest"))
-                 "")
-                (((make-suite "filtertestcase.DNSUtilsNetworkTests"))
-                 "")
-                (((make-suite "filtertestcase.IgnoreIPDNS"))
-                 "")
-                (((make-suite "filtertestcase.GetFailures"))
-                 "")
-                (((make-suite "fail2banclienttestcase.Fail2banServerTest"))
-                 "")
-                (((make-suite "servertestcase.ServerConfigReaderTests"))
+                (((make-suite-regex (list "actiontestcase.CommandActionTest"
+                                          "misctestcase.SetupTest"
+                                          "filtertestcase.DNSUtilsNetworkTests"
+                                          "filtertestcase.IgnoreIPDNS"
+                                          "filtertestcase.GetFailures"
+                                          "fail2banclienttestcase.Fail2banServerTest"
+                                          "servertestcase.ServerConfigReaderTests")))
                  ""))))
           (add-before 'install 'fix-default-config
             (lambda _