[bug#77605] gnu: font-carlito: Update to 0.0.0-1.3a810ca

Message ID 20250407095657.27768-1-hunt31999@gmail.com
State New
Headers
Series [bug#77605] gnu: font-carlito: Update to 0.0.0-1.3a810ca |

Commit Message

Kurome April 7, 2025, 9:56 a.m. UTC
  Change-Id: I886dde5b75454f717645f13befbe5f966bcb914b
---
 gnu/packages/fonts.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Hilton Chain April 7, 2025, 10:53 a.m. UTC | #1
Hi Kurome,

Debbugs doesn't automatically forward mails, reviewers won't get patches unless
they search explicitly.

Since fonts are reviewed by the localization team, you need to notify this team
(see Sending a Patch Series and Teams in GNU Guix Reference Manual).

On Mon, 07 Apr 2025 17:56:28 +0800,
Kurome wrote:
>
> Change-Id: I886dde5b75454f717645f13befbe5f966bcb914b


Please add changelog in the commit message (see Change Logs in GNU Coding
Standards, and git history for inspiration).


> ---
>  gnu/packages/fonts.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 75b1bee6e2..941f59b672 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -476,8 +476,8 @@ (define-public font-lato
>      (license license:silofl1.1)))
>
>  (define-public font-carlito
> -  (let ((commit "64cab86c9b602088697294736b86f2831f3f44be")
> -        (revision "0"))
> +  (let ((commit "3a810cab78ebd6e2e4eed42af9e8453c4f9b850a")
> +        (revision "1"))
>      (package
>        (name "font-carlito")
>        (version (git-version "0.0.0" revision commit))
> @@ -489,7 +489,7 @@ (define-public font-carlito
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 "02wy8vs5m4whm5apl3p6cpz0qa9jwjj9qi219zjspiszha2ivssz"))))
> +          (base32 "1qf3zdpbmx3ylamka82nqxjpm3qjfm0nca2yzzsxmvg7krjyz12k"))))
>        (build-system font-build-system)
>        (home-page "https://github.com/googlefonts/carlito")
>        (synopsis "Free alternative to Calibri")
> --
> 2.49.0


I see you have created multiple issues for fonts change, can you send revised
patches after reading above resources?

Thanks
  
Kurome April 7, 2025, 11:43 a.m. UTC | #2
Sorry for that. I will do that.
  

Patch

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 75b1bee6e2..941f59b672 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -476,8 +476,8 @@  (define-public font-lato
     (license license:silofl1.1)))
 
 (define-public font-carlito
-  (let ((commit "64cab86c9b602088697294736b86f2831f3f44be")
-        (revision "0"))
+  (let ((commit "3a810cab78ebd6e2e4eed42af9e8453c4f9b850a")
+        (revision "1"))
     (package
       (name "font-carlito")
       (version (git-version "0.0.0" revision commit))
@@ -489,7 +489,7 @@  (define-public font-carlito
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "02wy8vs5m4whm5apl3p6cpz0qa9jwjj9qi219zjspiszha2ivssz"))))
+          (base32 "1qf3zdpbmx3ylamka82nqxjpm3qjfm0nca2yzzsxmvg7krjyz12k"))))
       (build-system font-build-system)
       (home-page "https://github.com/googlefonts/carlito")
       (synopsis "Free alternative to Calibri")