From patchwork Fri Jan 31 08:19:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Graves X-Patchwork-Id: 37957 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EDAC127BBEA; Fri, 31 Jan 2025 08:23:23 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 57A2127BBE2 for ; Fri, 31 Jan 2025 08:23:23 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tdmIt-00085H-Ie; Fri, 31 Jan 2025 03:23:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdmHx-0007fq-0L for guix-patches@gnu.org; Fri, 31 Jan 2025 03:22:11 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tdmHw-0002N9-GS for guix-patches@gnu.org; Fri, 31 Jan 2025 03:22:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=UJOCKZuik+35LrzaHm1w5TnQE2ooUzD9OvD2kgZzeJQ=; b=N2BJJvbVOwtHXmdUbQ3WTXPOhlhTwpiOMW8DYgRTul6A8JlH0yTb9StcVMKBAKrQ5fxWF6xatgEv4UASNKkSWhjfYDlBMlU9i2b7Pro63ARMSNyI+v0AmGLW2E6sERQpewWdzMJ0KkH9+GA3DpIsre2Jz3D6hBIwBRW0JQXdZU+wjhA6of8hKtoH6gZMo8H8c26lOenrSGeNZK7AnG40t+DbZkLSzTFU870pBz5+p4HnV9rXTBsr+HPZbeZM+fIXwysqEi5ZOw+c1d89znaBejzcDDV1T61U+csUpMi7mJJLgueUI5/jz0unk3/7R+DMxClGJzjWy+5iDF0UMd4Qqw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tdmHw-0003RO-AB for guix-patches@gnu.org; Fri, 31 Jan 2025 03:22:08 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75737] [PATCH v3 21/52] gnu: ruby-railties: Update package. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 Jan 2025 08:22:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75737 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75737@debbugs.gnu.org Cc: Nicolas Graves , sharlatanus@gmail.com Received: via spool by 75737-submit@debbugs.gnu.org id=B75737.173831169212832 (code B ref 75737); Fri, 31 Jan 2025 08:22:08 +0000 Received: (at 75737) by debbugs.gnu.org; 31 Jan 2025 08:21:32 +0000 Received: from localhost ([127.0.0.1]:49702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdmHL-0003Ko-N1 for submit@debbugs.gnu.org; Fri, 31 Jan 2025 03:21:32 -0500 Received: from 7.mo583.mail-out.ovh.net ([178.32.124.100]:55527) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdmGs-0003EU-25 for 75737@debbugs.gnu.org; Fri, 31 Jan 2025 03:21:03 -0500 Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.140.75]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4YkpkN3Sgrz14ZW for <75737@debbugs.gnu.org>; Fri, 31 Jan 2025 08:21:00 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-7xj9w (unknown [10.111.174.115]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 083441FE47; Fri, 31 Jan 2025 08:20:59 +0000 (UTC) Received: from ngraves.fr ([37.59.142.105]) by ghost-submission-5b5ff79f4f-7xj9w with ESMTPSA id SMZjK+uHnGf4GgAARpobRw (envelope-from ); Fri, 31 Jan 2025 08:20:59 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-105G00646c3b3cb-6bb8-48a6-8729-87a7739f14d1, 6210C27661D5E5767C478A00054AC6B17F916FEA) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 82.210.73.18 Date: Fri, 31 Jan 2025 09:19:49 +0100 Message-ID: <20250131082029.26291-21-ngraves@ngraves.fr> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250131082029.26291-1-ngraves@ngraves.fr> References: <20250131082029.26291-1-ngraves@ngraves.fr> MIME-Version: 1.0 X-Ovh-Tracer-Id: 9794203290758013666 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekvdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepuddvjedrtddrtddruddpkedvrddvuddtrdejfedrudekpdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejheejfeejseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeefmgdpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=UJOCKZuik+35LrzaHm1w5TnQE2ooUzD9OvD2kgZzeJQ=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1738311660; v=1; b=j1RTTMAc9MRHQd9fV8Am456mZu/Z2xB8uW8LCp2TmqL3grFp2V4HbAdtnCVu6htQQpOOoK7L 0qZHSPSDxkB1n4/1xandfSDxsmMc0iK5TbOjYR1EJYL8g6nsuGMdxRFAuiJxNA7VTSJoioBOM7r NNKZkhFRsIqcU5E6SRx52Ncb2pi/RO9PvZY15u6mnZiJClmfl3caSQ8rHtcC/OROqSBzOv2GsUD M42jNw9AvtlN2wAeKo8RGx+WNKiGE+arK2tNF4cX99KAgLznEGsFvRkOlYEtz65WdbhnIcwcKCn zknr+VFvjW6bxnmYACT2amChi3wUTem5ogPi5znBD9ZJw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches X-Patchwork-Original-From: Nicolas Graves via Guix-patches via From: Nicolas Graves Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/rails.scm (ruby-railties): [arguments]<#:phases>: Update phase 'disable-problematic-tests with new failures. Cleanup old failures. [native-inputs]: Remove ruby-webrick. [propagated-inputs]: Add ruby-rackup-1 and ruby-webrick. --- gnu/packages/rails.scm | 84 +++++++++++++++++++++++++----------------- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm index 35f1a2bbc0..086b2374c2 100644 --- a/gnu/packages/rails.scm +++ b/gnu/packages/rails.scm @@ -1144,16 +1144,8 @@ (define (touch file-name) (with-directory-excursion "test" ;; This test requires 'rails' and Bundler. (delete-file "application/server_test.rb") - ;; These tests are incompatible with MiniTest 5.17 (see: - ;; https://github.com/rails/rails/issues/47657). - (skip-tests "generators_test.rb" - "test_invoke_with_config_values" - "test_simple_invoke" - "test_should_give_higher_preference_to_rails_generators" - "test_nested_fallbacks_for_generators" - "test_fallbacks_for_generators_on_invoke" - "test_invoke_with_default_values" - "test_invoke_with_nested_namespaces") + ;; These depends on firefox or chrome. + (delete-file "application/system_test_case_test.rb") ;; These tests requires the assets which we lack. (delete-file "application/assets_test.rb") (delete-file "railties/generators_test.rb") @@ -1162,12 +1154,31 @@ (define (touch file-name) ;; shebang and fails. "test_shebang_when_is_the_same_as_default_use_env") (skip-tests "generators/app_generator_test.rb" - ;; This test requires networking. + ;; These tests requires networking. + "test_app_update_create_new_framework_defaults" + "test_app_update_does_not_change_config_target_version" + "test_app_update_does_not_change_app_name_when_app_name_\ +is_hyphenated_name" + "test_app_update_does_not_create_rack_cors" + "test_app_update_does_not_generate_bootsnap_contents_\ +when_skip_bootsnap_is_given" + "test_app_update_does_not_remove_rack_cors_if_already_present" + "test_app_update_does_not_generate_manifest_config_\ +when_propshaft_is_used" + "test_app_update_does_not_generate_action_cable_\ +contents_when_skip_action_cable_is_given" + "test_app_update_preserves_propshaft" + "test_app_update_preserves_skip_action_mailbox" + "test_app_update_preserves_skip_action_text" + "test_app_update_preserves_skip_system_test" + "test_app_update_preserves_skip_test" + "test_application_name_is_detected_if_it_exists_and_app_folder_renamed" "test_template_from_url" ;; This test requires Bundler. "test_generation_use_original_bundle_environment" - ;; This test requires assets. + ;; These tests require assets. "test_css_option_with_cssbundling_gem" + "test_css_option_with_asset_pipeline_sass" ;; These tests require the rails/command ;; namespace provided by the 'ruby-rails' ;; package, which depends on this one. @@ -1186,10 +1197,11 @@ (define (touch file-name) "test_generate_application_job_when_does_not_exist_in_mountable_engine" "test_run_default" ;; This test expects a /usr/bin/env shebang. - "test_shebang") - ;; The following generator tests require assets. - (skip-tests "generators/plugin_test_runner_test.rb" - "test_run_default") + "test_shebang" + ;; This test requires Bundler. + "test_plugin_passes_generated_test") + ;; The following tests require Gemfile or .bundle in their setup. + (delete-file "generators/plugin_test_runner_test.rb") (skip-tests "generators/scaffold_controller_generator_test.rb" "test_controller_tests_pass_by_default_inside_full_engine" @@ -1203,9 +1215,8 @@ (define (touch file-name) "test_scaffold_tests_pass_by_default_inside_full_engine" "test_scaffold_tests_pass_by_default_inside_namespaced_\ mountable_engine") - (skip-tests "generators/test_runner_in_engine_test.rb" - "test_run_default" - "test_rerun_snippet_is_relative_path") + ;; Tests in this file require Bundler. + (delete-file "generators/test_runner_in_engine_test.rb") ;; The actions_test tests depend on assets or the rails gem. (delete-file "generators/actions_test.rb") (skip-tests "engine/commands_test.rb" @@ -1221,9 +1232,16 @@ (define (touch file-name) "test_generated_scaffold_works_with_rails_test" "test_load_fixtures_when_running_test_suites" "test_run_in_parallel_with_unmarshable_exception" - "test_run_in_parallel_with_unknown_object") + "test_run_in_parallel_with_unknown_object" + "test_system_tests_are_run_through_rake_test_when_given_in_TEST" + "test_reset_sessions_before_rollback_on_system_tests" + "test_reset_sessions_on_failed_system_test_screenshot" + "test_parallel_testing_when_schema_is_not_up_to_date" + "test_failed_system_test_screenshot_should_be_\ +taken_before_other_teardown") (skip-tests "application/test_test.rb" + "schema for all the models is loaded when tests are run in eager load context" "automatically synchronizes test schema after rollback" "hooks for plugins" "sql structure migrations when adding column to existing table" @@ -1237,9 +1255,9 @@ (define (touch file-name) (delete-file "application/rake/dbs_test.rb") (delete-file "application/rake/migrations_test.rb") (delete-file "application/rake/multi_dbs_test.rb") - (skip-tests "engine/test_test.rb" - "automatically synchronize test schema") (skip-tests "isolation/abstract_unit.rb" "use_postgresql") + ;; Requires rails gem. + (delete-file "engine/test_test.rb") (skip-tests "railties/engine_test.rb" "active_storage:install task works within engine" "active_storage:update task works within engine" @@ -1252,21 +1270,20 @@ (define (touch file-name) "setting priority for engines with config.railties_order") ;; This test requires a database server or networking. (delete-file "application/bin_setup_test.rb") - (skip-tests "application/middleware/cache_test.rb" - ;; This test produces "miss, store" instead of - ;; "fresh". - "test_cache_works_with_expires" - ;; This one produces "miss" instead of "stale, - ;; valid, store". - "test_cache_works_with_etags" - ;; Likewise. - "test_cache_works_with_last_modified") (skip-tests "application/initializers/frameworks_test.rb" ;; These tests are either broken, or rely on ;; database availability "expire schema cache dump if the version can't be checked because the database is unhealthy" "does not expire schema cache dump if check_schema_cache_dump_version is false and the database unhealthy" - "does not expire schema cache dump if check_schema_cache_dump_version is false"))))) + "does not expire schema cache dump if check_schema_cache_dump_version is false") + (skip-tests "commands/credentials_test.rb" + "edit command does not display save confirmation message if interrupted") + (skip-tests "commands/encrypted_test.rb" + "edit command does not display save confirmation message if interrupted") + (skip-tests "commands/routes_test.rb" + "rails routes with expanded option") + (skip-tests "commands/server_test.rb" + "test_served_url_when_server_prints_it"))))) (add-before 'check 'set-paths (lambda _ (setenv "PATH" (string-append (getenv "PATH") ":" @@ -1296,14 +1313,15 @@ (define (touch file-name) ruby-pg ruby-selenium-webdriver ruby-sprockets-rails - ruby-webrick sqlite)) (propagated-inputs (list ruby-actionpack ruby-activesupport ruby-method-source + ruby-rackup-1 ruby-rake ruby-thor + ruby-webrick ruby-zeitwerk)) (synopsis "Rails internals, including application bootup and generators") (description "@code{railties} provides the core Rails internals including