From patchwork Wed Nov 13 09:17:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Graves X-Patchwork-Id: 70338 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 14FCD27BBE9; Wed, 13 Nov 2024 09:18:33 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8D48227BBE2 for ; Wed, 13 Nov 2024 09:18:30 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tB9Vm-0007pe-9Y; Wed, 13 Nov 2024 04:18:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tB9Vk-0007p8-16 for guix-patches@gnu.org; Wed, 13 Nov 2024 04:18:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tB9Vj-00028X-PX for guix-patches@gnu.org; Wed, 13 Nov 2024 04:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=4BGtR92qdI98KbFXZhs/nzR5Jiv0U+gh4JnYzCuDqTo=; b=ap5koQHfIQ+ZisLoDohbfb2mCCtjS0+wUQgSumlWuA9ZoMd1zbPCbZVHOlrIIXS5jk5zvvonXa/I1ZcD3oO4uBxPsGVG5j/5Gb1UdyAeBtaw4UZl7gOvuvqD+WzU1ZUE1REIxsR+Vyr06+7UcUPqiI/7TOHgCiaPtfgdVYqW4XWF0+To1zsUxHtKFtw+HT7DqARBZPifoSbNKldynoAIauuA6GMemOKn0ZwcMBDANjUN6hYGTwZOdKE0BhEl6wfPns9kS8GrDsgXJPXZ6b8W23WNJZZGvgx+bx5XWLz9eyvbxeMQrHSN7mUV9Eq2iUuO4qg8xHhJ4pZc1t29X6TQOg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tB9Vi-0004Oi-Jj for guix-patches@gnu.org; Wed, 13 Nov 2024 04:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74058] [PATCH v5 1/2] gnu: postgresql-configuration: Unset default postgresql. References: <20241028105741.12834-1-ngraves@ngraves.fr> In-Reply-To: <20241028105741.12834-1-ngraves@ngraves.fr> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Nov 2024 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74058 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74058@debbugs.gnu.org Cc: Nicolas Graves Received: via spool by 74058-submit@debbugs.gnu.org id=B74058.173148945916868 (code B ref 74058); Wed, 13 Nov 2024 09:18:02 +0000 Received: (at 74058) by debbugs.gnu.org; 13 Nov 2024 09:17:39 +0000 Received: from localhost ([127.0.0.1]:40741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tB9VK-0004Nz-Pt for submit@debbugs.gnu.org; Wed, 13 Nov 2024 04:17:39 -0500 Received: from 17.mo583.mail-out.ovh.net ([46.105.56.132]:34879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tB9VH-0004Np-96 for 74058@debbugs.gnu.org; Wed, 13 Nov 2024 04:17:37 -0500 Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.148.65]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4XpHk54XbQz1C6F for <74058@debbugs.gnu.org>; Wed, 13 Nov 2024 09:17:33 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-g87qd (unknown [10.111.182.17]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id E99B61FEB6; Wed, 13 Nov 2024 09:17:32 +0000 (UTC) Received: from ngraves.fr ([37.59.142.99]) by ghost-submission-5b5ff79f4f-g87qd with ESMTPSA id AzE3JKxuNGdrXQAAaUnMRg (envelope-from ); Wed, 13 Nov 2024 09:17:32 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-99G003a4d32530-79b3-48b4-ad2d-5d7e1f193c23, E46EE4CFA6AA1EB3B0ED220F39F6A53F8FAC1481) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 90.92.117.144 Date: Wed, 13 Nov 2024 10:17:23 +0100 Message-ID: <20241113091729.24715-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Ovh-Tracer-Id: 7975030515866919650 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrvddtgddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeekffegteffgfffjeegjedvfffgtddvueeutefgfeeuvdejgedvgeejjeevueeuveenucfkphepuddvjedrtddrtddruddpledtrdelvddruddujedrudeggedpfeejrdehledrudegvddrleelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejgedtheekseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeefmgdpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=4BGtR92qdI98KbFXZhs/nzR5Jiv0U+gh4JnYzCuDqTo=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1731489453; v=1; b=IAhvoJoL7Vrfk3Am5NNAqwivGR4DG8UTQaFzTKFlRpUCqB56HDPp12f8SbguuLO+/CHnd41g FBLN4DDV3vo5MGJ6yAFWPHxXbjuT7Tn7ztl5n4LQX6Jmd7IHPuA3sFKm00H28awKfMe/DPDRZZL hMpZht//Vr2DtZr2WwEeSqgj3cZhMsFUOsPjFvMKiwTB/R5vm3B3moji1hfsYT9BFW7N+iK1rU9 BHN4MDgKGxTb7PlkNzHxao3lxkwemd4xTJXnkGd0Hu/oIxS1qBqrA0o+62MW/ILH1nZkKSTp2v4 eogC1lGd9nI1FXTN6qawsUtdP2hQdPVJ2LLlXBNTuKK6w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches X-Patchwork-Original-From: Nicolas Graves via Guix-patches via From: Nicolas Graves Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/services/databases.scm (postgresql-configuration)[postgresql]: Unset default. (postgresql-service): Revert default to postgresql-10 (rationale: We can remove this service at the same time than postgresql-10, in something like 6 months to a year). --- gnu/services/databases.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index 0933eb5e79..001f96830e 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -167,8 +167,11 @@ (define contents (define-record-type* postgresql-configuration make-postgresql-configuration postgresql-configuration? - (postgresql postgresql-configuration-postgresql ;file-like - (default postgresql)) + ;; Setting no default ensures that the user sets its current postgresql + ;; explicitely. Since major upgrades currently require a manual migration + ;; of the database, this way the user is responsible for upgrading properly. + ;; MAYBE TODO: Write an action to automatically upgrade in Guix. + (postgresql postgresql-configuration-postgresql) ;file-like (port postgresql-configuration-port (default 5432)) (locale postgresql-configuration-locale @@ -346,7 +349,7 @@ (define postgresql-service-type (default-value (postgresql-configuration)) (description "Run the PostgreSQL database server."))) -(define-deprecated (postgresql-service #:key (postgresql postgresql) +(define-deprecated (postgresql-service #:key (postgresql postgresql-10) (port 5432) (locale "en_US.utf8") (config-file (postgresql-config-file))