From patchwork Mon Oct 28 11:13:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Graves X-Patchwork-Id: 69590 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D6E5A27BBE9; Mon, 28 Oct 2024 11:21:37 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1E2C627BBE2 for ; Mon, 28 Oct 2024 11:21:36 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5NoO-0003Si-6Q; Mon, 28 Oct 2024 07:21:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5NoN-0003SZ-32 for guix-patches@gnu.org; Mon, 28 Oct 2024 07:21:27 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5NoM-0004s2-RC for guix-patches@gnu.org; Mon, 28 Oct 2024 07:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=aDklrjzmLwPtio4Eydo9FRO+xug6xzki2yuAeqASQWs=; b=n8UvLYi4nR9y/WcCObuHN4sFm1J0GHt6k5271zg+Ht+5K+5D4nl98sUUe0WnmlhgA2vYEqFUI90mLlOpYcJf7W0fORoFL9XrZ62/qLnbV2k7GtVDh3osmqPYa9RV77LASbQbcp9+OzZx4PaOVjA589TNGUeWsR8NvriIjP+lEiL9FdWB/0H09LrF0QUt0y1qXwYU1Ab72ApABeG5HKHKwbwHq7Bh1WpsqSIOfIG54sWk1yT9pv0WxWZCsYSC6qRhF3+RpMcCU/4yzPd8pNtXqFJDBOIxQgkfUwwQ/v+txeZOSaJt/l7dqwkg6eFA5ERSCXMYgwYg/URRLrOuRzVrhA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5Now-0002ih-Px for guix-patches@gnu.org; Mon, 28 Oct 2024 07:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74058] [PATCH 1/2] gnu: postgresql-configuration: Set default postgresql to #f. References: <20241028105741.12834-1-ngraves@ngraves.fr> In-Reply-To: <20241028105741.12834-1-ngraves@ngraves.fr> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Oct 2024 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74058 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74058@debbugs.gnu.org Cc: Nicolas Graves Received: via spool by 74058-submit@debbugs.gnu.org id=B74058.173011446810347 (code B ref 74058); Mon, 28 Oct 2024 11:22:02 +0000 Received: (at 74058) by debbugs.gnu.org; 28 Oct 2024 11:21:08 +0000 Received: from localhost ([127.0.0.1]:52742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5No3-0002gk-PJ for submit@debbugs.gnu.org; Mon, 28 Oct 2024 07:21:08 -0400 Received: from 9.mo581.mail-out.ovh.net ([46.105.60.248]:47171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5No1-0002ga-Ft for 74058@debbugs.gnu.org; Mon, 28 Oct 2024 07:21:06 -0400 Received: from director1.ghost.mail-out.ovh.net (unknown [10.108.2.55]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4XcWCH6m5mz1Mh9 for <74058@debbugs.gnu.org>; Mon, 28 Oct 2024 11:20:27 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-llldq (unknown [10.110.96.131]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 1F1C11FFD7; Mon, 28 Oct 2024 11:14:03 +0000 (UTC) Received: from ngraves.fr ([37.59.142.97]) by ghost-submission-5b5ff79f4f-llldq with ESMTPSA id GQCtAPtxH2f9SAAAjYQwFA (envelope-from ); Mon, 28 Oct 2024 11:14:03 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-97G0024046836c-8710-42ba-89d6-535d35668c98, 2EBFFEBE9A2CEA4974D3D0C7E73B7B071B2C9EDA) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 89.85.243.20 Date: Mon, 28 Oct 2024 12:13:29 +0100 Message-ID: <20241028111340.17913-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Ovh-Tracer-Id: 8214284247020135138 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvdejlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeekffegteffgfffjeegjedvfffgtddvueeutefgfeeuvdejgedvgeejjeevueeuveenucfkphepuddvjedrtddrtddruddpkeelrdekhedrvdegfedrvddtpdefjedrheelrddugedvrdeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjeegtdehkeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekuddpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=aDklrjzmLwPtio4Eydo9FRO+xug6xzki2yuAeqASQWs=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1730114428; v=1; b=bULHRHGswQFsR5w+1Fcko58lbDkKST2eCqvWjB8oaney6aMAOKWupE8Xdz592OXxeD+SAcOH nC1z/7BRBzCYwopGqNs9Z2A32a4j9V4BMvckd9MNAdf0w9DRH/h3UucOoNvuh0Fhxpumun4mVc4 +EmfIQK7A9poCghZYcqTPQfSnBLgrsSs+7LJADwN+7lqPqrewWAJYWdl0kGHIdHP6oCiARYgQjV Tvb2punAJyFrIzqmUg4RrIy15h6Nx7zVFnWyIn3UAWWlbc5XarajBtMZDdFWdtqhFHFUUtVQUDv 62/uqsZ1UjRwwSR+WvXPsBepoO8NgCvamv0zMvKEXkdqg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches X-Patchwork-Original-From: Nicolas Graves via Guix-patches via From: Nicolas Graves Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/services/databases.scm (postgresql-configuration)[postgresql]: Set default to #f. (postgresql-services): Revert default to postgresql-10 (rationale: We can remove this service at the same time than postgresql-10, in something like 6 months to a year). --- gnu/services/databases.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index 0933eb5e79..f8ae085339 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -167,8 +167,12 @@ (define contents (define-record-type* postgresql-configuration make-postgresql-configuration postgresql-configuration? - (postgresql postgresql-configuration-postgresql ;file-like - (default postgresql)) + ;; Setting it to #f ensures that the user sets its current postgresql + ;; explicitely. Since major upgrades currently require a manual migration + ;; of the database, this way the user is responsible for upgrading properly. + ;; MAYBE TODO: Write an action to automatically upgrade in Guix. + (postgresql postgresql-configuration-postgresql ;file-like or #f + (default #f)) (port postgresql-configuration-port (default 5432)) (locale postgresql-configuration-locale @@ -346,7 +350,7 @@ (define postgresql-service-type (default-value (postgresql-configuration)) (description "Run the PostgreSQL database server."))) -(define-deprecated (postgresql-service #:key (postgresql postgresql) +(define-deprecated (postgresql-service #:key (postgresql postgresql-10) (port 5432) (locale "en_US.utf8") (config-file (postgresql-config-file))