diff mbox series

[bug#70190,v2] gnu: speech-dispatcher: Update to 0.11.5.

Message ID 20240406090856.733386-1-guix-devel-0brg6b@rdmp.org
State New
Headers show
Series [bug#70190,v2] gnu: speech-dispatcher: Update to 0.11.5. | expand

Commit Message

Dale Mellor April 6, 2024, 9:08 a.m. UTC 
From: Sébastien Lerique <sl@eauchat.org>

* gnu/packages/speech.scm (speech-dispatcher): Update to 0.11.5.
[source]: Switch to git-fetch.
[native-inputs]: Add autoconf, automake, libtool.
[inputs]: Add python-xdg.

Review:
   * the change is minimal, patch applies cleanly
     * the upstream source has changed to a GIT repository; checked
       authenticity against upstream home page https://freebsoft.org/speechd
     * the license is complicated, but does not appear to have changed from
       previous release
   * guix lint is clean
   * installed and tested by running 'spd-say "hello"' at the command-line

Reviewed-by: Dale Mellor <guix-devel-0brg6b@rdmp.org>
Change-Id: If323f17bac54da427be1a09d847de50842717a01
---
 gnu/packages/speech.scm | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

Comments

Ludovic Courtès April 11, 2024, 10:32 a.m. UTC | #1 
Hi,

Dale Mellor <guix-devel-0brg6b@rdmp.org> skribis:

> From: Sébastien Lerique <sl@eauchat.org>
>
> * gnu/packages/speech.scm (speech-dispatcher): Update to 0.11.5.
> [source]: Switch to git-fetch.
> [native-inputs]: Add autoconf, automake, libtool.
> [inputs]: Add python-xdg.
>
> Review:
>    * the change is minimal, patch applies cleanly
>      * the upstream source has changed to a GIT repository; checked
>        authenticity against upstream home page https://freebsoft.org/speechd
>      * the license is complicated, but does not appear to have changed from
>        previous release
>    * guix lint is clean
>    * installed and tested by running 'spd-say "hello"' at the command-line
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6b@rdmp.org>
> Change-Id: If323f17bac54da427be1a09d847de50842717a01

Applied.  Thanks Sébastien & Dale!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/packages/speech.scm b/gnu/packages/speech.scm
index 9939d2f165..36b67ccd93 100644
--- a/gnu/packages/speech.scm
+++ b/gnu/packages/speech.scm
@@ -8,6 +8,7 @@ 
 ;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2021 qblade <qblade@protonmail.com>
+;;; Copyright © 2024 Sébastien Lerique <sl@eauchat.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -51,6 +52,7 @@  (define-module (gnu packages speech)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils))
@@ -236,15 +238,16 @@  (define-public mitlm
 (define-public speech-dispatcher
   (package
     (name "speech-dispatcher")
-    (version "0.11.4")
+    (version "0.11.5")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/brailcom/speechd/releases"
-                                  "/download/" version "/speech-dispatcher-"
-                                  version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/brailcom/speechd")
+                    (commit version)))
+              (file-name (git-file-name name version))
               (sha256
                (base32
-                "1fb6ypnr8r3905b68bbplg1qcaw3f6br2yzxkk4bb79dnwdj42cc"))))
+                "0z2rb1yi06v145sr2h69rxbxzrsfrk198cw6bgpf8wj2njfh3555"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags '("--disable-static"
@@ -253,7 +256,12 @@  (define-public speech-dispatcher
                            "--with-voxin=no" "--with-ibmtts=no"
                            "--with-kali=no" "--with-baratinoo=no")))
     (native-inputs
-     (list gettext-minimal pkg-config texinfo))
+     (list autoconf
+           automake
+           gettext-minimal
+           libtool
+           pkg-config
+           texinfo))
     (inputs
      (list dotconf
            espeak-ng
@@ -261,7 +269,8 @@  (define-public speech-dispatcher
            libltdl
            libsndfile
            pulseaudio
-           python))
+           python
+           python-xdg))
     (synopsis "Common interface to speech synthesizers")
     (description "The Speech Dispatcher project provides a high-level
 device independent layer for access to speech synthesis through a simple,