diff mbox series

[bug#65233,1/2] gnu: librecast: Update to 0.7.0.

Message ID 20230822203120.295325-1-vagrant@debian.org
State New
Headers show
Series [bug#65233,1/2] gnu: librecast: Update to 0.7.0. | expand

Commit Message

Vagrant Cascadian Aug. 22, 2023, 8:31 p.m. UTC
From: Vagrant Cascadian <vagrant@debian.org>

* gnu/packages/networking.scm (librecast): Update to 0.7.0.
[arguments]: Drop 'remove-network-tests phase.
---
 gnu/packages/networking.scm | 25 +++----------------------
 1 file changed, 3 insertions(+), 22 deletions(-)


base-commit: db02fcde386892b3a054d64403a4a5bfa1b7fce8

Comments

Vagrant Cascadian Aug. 23, 2023, 10:02 p.m. UTC | #1
retitle 65233 lcsync and librecast updates
thanks

Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
removing "WIP" from the title; these are worthy of merging, I hope. :)

live well,
  vagrant
Christopher Baines Aug. 29, 2023, 12:56 p.m. UTC | #2
Vagrant Cascadian <vagrant@debian.org> writes:

> Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
> removing "WIP" from the title; these are worthy of merging, I hope. :)

This looks good to me, I've pushed it to master as
5f672aaa0ca7e2c5775c8950fa1627ac419e557e.

Thanks,

Chris
Vagrant Cascadian Aug. 29, 2023, 5:40 p.m. UTC | #3
On 2023-08-29, Christopher Baines wrote:
> Vagrant Cascadian <vagrant@debian.org> writes:
>
>> Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
>> removing "WIP" from the title; these are worthy of merging, I hope. :)
>
> This looks good to me, I've pushed it to master as
> 5f672aaa0ca7e2c5775c8950fa1627ac419e557e.

Thanks!

It looks like you ended up merging the old librecast 0.7-RC3 patch,
rather than the 0.7.0 patch I submitted later. I apparently forgot to
mark it as a v2 patch, which maybe tripped you up.

Would it be ok if I pushed the newer version or would you be able to?

live well,
  vagrant
Vagrant Cascadian Aug. 29, 2023, 6:04 p.m. UTC | #4
On 2023-08-29, Vagrant Cascadian wrote:
> On 2023-08-29, Christopher Baines wrote:
>> Vagrant Cascadian <vagrant@debian.org> writes:
>>
>>> Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
>>> removing "WIP" from the title; these are worthy of merging, I hope. :)
>>
>> This looks good to me, I've pushed it to master as
>> 5f672aaa0ca7e2c5775c8950fa1627ac419e557e.
>
> Thanks!
>
> It looks like you ended up merging the old librecast 0.7-RC3 patch,
> rather than the 0.7.0 patch I submitted later. I apparently forgot to
> mark it as a v2 patch, which maybe tripped you up.
>
> Would it be ok if I pushed the newer version or would you be able to?

I just went ahead and pushed c61c499c59109f6094384ee205c98034d759b600 as
a follow-up to update librecast to 0.7.0.

live well,
  vagrant
Christopher Baines Aug. 31, 2023, 12:30 p.m. UTC | #5
Vagrant Cascadian <vagrant@debian.org> writes:

> [[PGP Signed Part:Signature made by expired key DC518FC87F9716AA Vagrant Cascadian <vagrant@aikidev.net>]]
> On 2023-08-29, Vagrant Cascadian wrote:
>> On 2023-08-29, Christopher Baines wrote:
>>> Vagrant Cascadian <vagrant@debian.org> writes:
>>>
>>>> Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
>>>> removing "WIP" from the title; these are worthy of merging, I hope. :)
>>>
>>> This looks good to me, I've pushed it to master as
>>> 5f672aaa0ca7e2c5775c8950fa1627ac419e557e.
>>
>> Thanks!
>>
>> It looks like you ended up merging the old librecast 0.7-RC3 patch,
>> rather than the 0.7.0 patch I submitted later. I apparently forgot to
>> mark it as a v2 patch, which maybe tripped you up.
>>
>> Would it be ok if I pushed the newer version or would you be able to?
>
> I just went ahead and pushed c61c499c59109f6094384ee205c98034d759b600 as
> a follow-up to update librecast to 0.7.0.

Apologies for this, I didn't check that I'd got the right patches before
pushing. The slightly longer story is that I cherry picked these from
the guix-patches repository [1], but a bug in QA meant that it hadn't
been updating the branches, so I cherry picked the earlier version of
the patch.

1: https://git.guix-patches.cbaines.net/guix-patches/
Vagrant Cascadian Aug. 31, 2023, 9:52 p.m. UTC | #6
On 2023-08-31, Christopher Baines wrote:
> Vagrant Cascadian <vagrant@debian.org> writes:
>
>> [[PGP Signed Part:Signature made by expired key DC518FC87F9716AA Vagrant Cascadian <vagrant@aikidev.net>]]
>> On 2023-08-29, Vagrant Cascadian wrote:
>>> On 2023-08-29, Christopher Baines wrote:
>>>> Vagrant Cascadian <vagrant@debian.org> writes:
>>>>
>>>>> Both lcsync 0.2.1 and librecast 0.7.0 have upstream releases now, thus
>>>>> removing "WIP" from the title; these are worthy of merging, I hope. :)
>>>>
>>>> This looks good to me, I've pushed it to master as
>>>> 5f672aaa0ca7e2c5775c8950fa1627ac419e557e.
>>>
>>> Thanks!
>>>
>>> It looks like you ended up merging the old librecast 0.7-RC3 patch,
>>> rather than the 0.7.0 patch I submitted later. I apparently forgot to
>>> mark it as a v2 patch, which maybe tripped you up.
>>>
>>> Would it be ok if I pushed the newer version or would you be able to?
>>
>> I just went ahead and pushed c61c499c59109f6094384ee205c98034d759b600 as
>> a follow-up to update librecast to 0.7.0.
>
> Apologies for this, I didn't check that I'd got the right patches before
> pushing.

No worries, it was easy enough to fix. :)

> The slightly longer story is that I cherry picked these from
> the guix-patches repository [1], but a bug in QA meant that it hadn't
> been updating the branches, so I cherry picked the earlier version of
> the patch.
>
> 1: https://git.guix-patches.cbaines.net/guix-patches/

This is so tremendously useful, even with a few glitches now and then! I
only recently learned about it!

live well,
  vagrant
diff mbox series

Patch

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 04461fec2d..2b2e2bd4a5 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -487,7 +487,7 @@  (define-public libnice
 (define-public librecast
   (package
     (name "librecast")
-    (version "0.6.1")
+    (version "0.7.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -496,7 +496,7 @@  (define-public librecast
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1kixnm7pn8345wp0klhnpw5x992cqbqx3bhc01j8xhqf6irlzdm3"))))
+                "0y0km0fv39m3i227pyg7fcr7d94gbji51fkcywqyrjgmk4j1hp1n"))))
     (build-system gnu-build-system)
     (arguments
      `(#:parallel-tests? #f
@@ -505,26 +505,7 @@  (define-public librecast
                                             (cc-for-target))
                             (string-append "PREFIX="
                                            (assoc-ref %outputs "out"))))
-       #:test-target "test"
-       #:phases (modify-phases %standard-phases
-                  (add-before 'check 'remove-network-tests
-                    (lambda _
-                      ;; these tests require networking
-                      (delete-file "./test/0000-0010.c")
-                      (delete-file "./test/0000-0012.c")
-                      (delete-file "./test/0000-0013.c")
-                      (delete-file "./test/0000-0014.c")
-                      (delete-file "./test/0000-0015.c")
-                      (delete-file "./test/0000-0016.c")
-                      (delete-file "./test/0000-0018.c")
-                      (delete-file "./test/0000-0019.c")
-                      (delete-file "./test/0000-0021.c")
-                      (delete-file "./test/0000-0028.c")
-                      (delete-file "./test/0000-0036.c")
-                      (delete-file "./test/0000-0037.c")
-                      (delete-file "./test/0000-0038.c")
-                      (delete-file "./test/0000-0039.c")
-                      (delete-file "./test/0000-0040.c"))))))
+       #:test-target "test"))
     (inputs (list libsodium lcrq))
     (synopsis "IPv6 multicast library")
     (description "Librecast is a C library which supports IPv6 multicast