@@ -1561,38 +1561,36 @@ false."
(chdir directory)
(environ environment-variables)
- ;; Redirect stdin.
- (catch-system-error (close-fdes 0))
- ;; Make sure file descriptor zero is used, so we don't end up reusing
- ;; it for something unrelated, which can confuse some packages.
- (dup2 (if input-port
- (fileno input-port)
- (open-fdes "/dev/null" O_RDONLY))
- 0)
-
- (when (or log-port log-file)
- (catch #t
- (lambda ()
- ;; Redirect stdout and stderr to use LOG-FILE.
- (catch-system-error (close-fdes 1))
- (catch-system-error (close-fdes 2))
- (dup2 (if log-file
- (open-fdes log-file (logior O_CREAT O_WRONLY O_APPEND)
- #o640)
- (fileno log-port))
- 1)
- (dup2 1 2))
-
- (lambda (key . args)
- (when log-file
- (format (current-error-port)
- "failed to open log-file ~s:~%" log-file))
- (print-exception (current-error-port) #f key args)
- (primitive-exit 1))))
-
- ;; Make EXTRA-PORTS available starting from file descriptor 3.
- ;; This clears their FD_CLOEXEC flag.
- (reconfigure-fds extra-ports 3)
+ (let* ( ;; Make sure file descriptor zero is used, so we don't end up reusing
+ ;; it for something unrelated, which can confuse some packages.
+ (stdin (or input-port (open-fdes "/dev/null"
+ (logior O_RDONLY
+ O_CLOEXEC))))
+ (stdout (catch #t
+ (lambda ()
+ (or log-port
+ (and log-file
+ (open-fdes log-file
+ (logior O_CREAT O_WRONLY O_APPEND
+ O_CLOEXEC)
+ #o640))
+ 1))
+ (lambda (key . args)
+ (when log-file
+ (format (current-error-port)
+ "failed to open log-file ~s:~%" log-file))
+ (print-exception (current-error-port) #f key args)
+ (primitive-exit 1))))
+ (stderr (if (or log-port log-file)
+ stdout
+ 2))
+ (all-fds (+ 3 (length extra-ports))))
+ ;; Make EXTRA-PORTS available starting from file descriptor 3.
+ ;; This clears their FD_CLOEXEC flag.
+ (reconfigure-fds (cons* stdin
+ stdout
+ stderr
+ extra-ports)))
;; setgid must be done *before* setuid, otherwise the user will
;; likely no longer have permissions to setgid.