diff mbox series

[bug#63802,mumi,1/3] client: Do not pass --add-header to git send-email.

Message ID 20230530121447.26236-1-arunisaac@systemreboot.net
State New
Headers show
Series Use consolidated X-Debbugs-Cc header | expand

Commit Message

Arun Isaac May 30, 2023, 12:14 p.m. UTC 
git send-email accepts --add-header only when passed a git
format-patch style revision list.

* mumi/client.scm (send-email): Do not pass --add-header to
git-send-email.
* tests/client.scm ("send patch to existing issue and Cc other
participants"): Do not expect --add-header.
---
 mumi/client.scm  | 5 +----
 tests/client.scm | 6 +-----
 2 files changed, 2 insertions(+), 9 deletions(-)

Comments

Maxim Cournoyer June 5, 2023, 2:21 a.m. UTC | #1 
Hi Arun!

Arun Isaac <arunisaac@systemreboot.net> writes:

> git send-email accepts --add-header only when passed a git
> format-patch style revision list.

LGTM.  The idea is that this is now handled by a configured git
'add-header-cmd' such as Guix' etc/teams.scm, correct?
diff mbox series

Patch

diff --git a/mumi/client.scm b/mumi/client.scm
index b575daa..5befd42 100644
--- a/mumi/client.scm
+++ b/mumi/client.scm
@@ -287,10 +287,7 @@  ISSUE-NUMBER."
         (git-send-email (string-append (number->string issue-number)
                                        "@"
                                        (client-config 'debbugs-host))
-                        patches
-                        (map (cut string-append "--add-header=X-Debbugs-Cc: " <>)
-                             (assq-ref (reply-email-headers issue-number)
-                                       'cc))))
+                        patches))
       (match patches
         ;; If it's a single patch, send it to the patch email address
         ;; and be done with it
diff --git a/tests/client.scm b/tests/client.scm
index 5729521..5352b08 100644
--- a/tests/client.scm
+++ b/tests/client.scm
@@ -126,11 +126,7 @@  called with."
                   (list "foo.patch")))))))
 
 (test-equal "send patch to existing issue and Cc other participants"
-  '(("git" "send-email"
-     "--to=12345@example.com"
-     "--add-header=X-Debbugs-Cc: John Doe <jdoe@machine.example>"
-     "--add-header=X-Debbugs-Cc: Mary Smith <mary@example.net>"
-     "foo.patch"))
+  '(("git" "send-email" "--to=12345@example.com" "foo.patch"))
   (map (match-lambda
          ((command _) command))
        (trace-calls (var@@ (mumi client) call-with-input-pipe*)