From patchwork Fri Apr 7 14:07:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 49013 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C170F17418; Fri, 7 Apr 2023 15:08:37 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0FFF6173B3 for ; Fri, 7 Apr 2023 15:08:37 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkml8-0004UX-Lg; Fri, 07 Apr 2023 10:08:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkml1-0004Ty-6k for guix-patches@gnu.org; Fri, 07 Apr 2023 10:08:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkml0-0003Gz-Kk for guix-patches@gnu.org; Fri, 07 Apr 2023 10:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkml0-0003Yr-GL for guix-patches@gnu.org; Fri, 07 Apr 2023 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62712] [PATCH 2/2] svn-download: Default to non-recursive checkouts. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62712@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 62712-submit@debbugs.gnu.org id=B62712.168087646613634 (code B ref 62712); Fri, 07 Apr 2023 14:08:02 +0000 Received: (at 62712) by debbugs.gnu.org; 7 Apr 2023 14:07:46 +0000 Received: from localhost ([127.0.0.1]:56962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmkj-0003Xn-9Z for submit@debbugs.gnu.org; Fri, 07 Apr 2023 10:07:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmkf-0003XB-6T for 62712@debbugs.gnu.org; Fri, 07 Apr 2023 10:07:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmkZ-00037z-8z; Fri, 07 Apr 2023 10:07:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=fUY1+jF23tYDwLFi/D0X6E83A3whPOeh3wgyEYE75Go=; b=RsvgazC/ySvgEWdPkff9 4+SNftnOUJ15uwFnK98JquH0tp7SNtqJqi11HjvjkYRM6LF9xpwTdQ9cHJbowfMBiRwAzbuUlVKb2 xpqKRjwxFZFPaF3zqIYwuGgIoezdaj6rKLfoEDmfzG+a+lh9jR9tk6XCVl5xa6BI4w7SIDx3BlTkI nFBtCg6PIkkTMHvzAMusIkMt0zwvwbiUfj3b5yZgOVvDsByf8Bmv6it5CbMg5pTGh8kSGXWFBVQtN qwtHTyfJlMTGxlF/LrM/03H2LAMdzAD28TQf7Fr+o4G5jx/Gexs1tixYCYg0FpaMjRsxyKs95Gw3Y kji5ILlikMTOxw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmkY-0006Xq-Rb; Fri, 07 Apr 2023 10:07:35 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 7 Apr 2023 16:07:24 +0200 Message-Id: <20230407140724.8815-2-ludo@gnu.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230407140724.8815-1-ludo@gnu.org> References: <20230407140724.8815-1-ludo@gnu.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches From: Ludovic Courtès As it turns out, all packages that fetch code from Subversion expect it to be non-recursive by default. Clarify that. Reported by Timothy Sample . * guix/svn-download.scm ()[recursive?]: Default to #f. ()[recursive?]: Likewise. --- guix/svn-download.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/guix/svn-download.scm b/guix/svn-download.scm index e0a26b73ee..769571b5f6 100644 --- a/guix/svn-download.scm +++ b/guix/svn-download.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014-2016, 2019, 2021-2022 Ludovic Courtès +;;; Copyright © 2014-2016, 2019, 2021-2023 Ludovic Courtès ;;; Copyright © 2014 Sree Harsha Totakura ;;; Copyright © 2017, 2019, 2021 Ricardo Wurmus ;;; @@ -63,7 +63,7 @@ (define-record-type* svn-reference? (url svn-reference-url) ; string (revision svn-reference-revision) ; number - (recursive? svn-reference-recursive? (default #t)) + (recursive? svn-reference-recursive? (default #f)) (user-name svn-reference-user-name (default #f)) (password svn-reference-password (default #f))) @@ -132,7 +132,7 @@ (define-record-type* (url svn-multi-reference-url) ; string (revision svn-multi-reference-revision) ; number (locations svn-multi-reference-locations) ; list of strings - (recursive? svn-multi-reference-recursive? (default #t)) + (recursive? svn-multi-reference-recursive? (default #f)) (user-name svn-multi-reference-user-name (default #f)) (password svn-multi-reference-password (default #f)))