From patchwork Fri Mar 31 18:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jgart X-Patchwork-Id: 48865 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 70F6F172F3; Fri, 31 Mar 2023 19:26:19 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D9660172E7 for ; Fri, 31 Mar 2023 19:26:17 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piJRt-00081f-AV; Fri, 31 Mar 2023 14:26:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piJRr-00081I-1Y for guix-patches@gnu.org; Fri, 31 Mar 2023 14:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piJRq-0006X0-CU for guix-patches@gnu.org; Fri, 31 Mar 2023 14:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piJRp-00041y-MR for guix-patches@gnu.org; Fri, 31 Mar 2023 14:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62077] [PATCH v2] gnu: Add python-slugid. References: <82177a4f-a75d-a15d-117b-6f06a9adcb33@disroot.org> In-Reply-To: <82177a4f-a75d-a15d-117b-6f06a9adcb33@disroot.org> Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 Mar 2023 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62077 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62077@debbugs.gnu.org Cc: lars@6xq.net, jgart , Adam Faiz Received: via spool by 62077-submit@debbugs.gnu.org id=B62077.168028711315432 (code B ref 62077); Fri, 31 Mar 2023 18:26:01 +0000 Received: (at 62077) by debbugs.gnu.org; 31 Mar 2023 18:25:13 +0000 Received: from localhost ([127.0.0.1]:34490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piJR2-00040q-JS for submit@debbugs.gnu.org; Fri, 31 Mar 2023 14:25:12 -0400 Received: from mx1.dismail.de ([78.46.223.134]:18495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piJQz-00040T-Da for 62077@debbugs.gnu.org; Fri, 31 Mar 2023 14:25:10 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 87e43424; Fri, 31 Mar 2023 20:25:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=G8KNBOXq0F1JKUPUETGvhRVQaLVLvLCcbNa4OxtsgIk=; b= n2Wl893Q3WrxDErKzrnX06JygIFhB4zVXNsEAYMFyGEIKZIkbpVvk9yKUHG9Q9ib fwRykGic7B0ymqGcb7ZHFVJbj7l1i6ICCzW6eJViD1+xBPXrvf4pGDDilpBD7eTf F4nd+rlG7yMGqs6cHksXsgrzBucIoJzeU1pLpDTuZKC0QFhkhBvesRkAXltwLvkM LX4wHvFLGXYR/t37Juc9Bbip+SW1vVwl7XDs/MlIIRqA283YbkA5jLGDchIfjBSo PIp7k0lwNXf67F8gnayYqh/MEAc/m2oCYaA20ls1n+loX7vU5uaAWteRx3n+ix1A A9cAyxm1Qg0F3U16kFk7Rg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 8f039c6c; Fri, 31 Mar 2023 20:25:02 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 1e36ac5e; Fri, 31 Mar 2023 20:25:02 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 75b94cf8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 31 Mar 2023 20:25:00 +0200 (CEST) Date: Fri, 31 Mar 2023 13:19:29 -0500 Message-Id: <20230331181928.6626-1-jgart@dismail.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches X-Patchwork-Original-From: jgart via Guix-patches via From: jgart Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/python-xyz.scm (python-slugid): New variable. Co-authored-by: jgart --- Hi Adam, Thanks for the patch and sorry for the delay in reviewing this. I've been busy. I've attached a version 2 of your patch with modifications. I've also added myself as a "co-author" since I've made a few changes to your patch. I modified the package to take the source from GitHub since the GitHub repository includes the tests and the PyPi version does not. We usually try to enable the tests on all of our packages when available and practical. I added a phase in the arguments field implementing that. I also added a comment mentioning that tests are run by nose via tox. In my approach here I just run nose directly and forego using tox. Hi Lars, WDYT. Can this be merged? I don't have commit access so someone else would have to merge it. all best, jgart gnu/packages/python-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index ca6c68ec7c..5c44817afa 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -16801,6 +16801,36 @@ (define-public python-rarfile is made as zipfile like as possible.") (license license:isc))) +(define-public python-slugid + (package + (name "python-slugid") + (version "2.0.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/taskcluster/slugid.py") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1h64p2jlqv6lsmw8h2j203kx3bhv72cwzpk5gdhsaamw30cp3h1i")))) + (build-system python-build-system) + (native-inputs (list python-nose)) + (arguments + (list #:phases + #~(modify-phases %standard-phases + (replace 'check + (lambda* (#:key inputs tests? #:allow-other-keys) + (when tests? + ;; The project uses tox to run the tests via nose. + (invoke "nosetests" "-v" "test.py"))))))) + (home-page "http://taskcluster.github.io/slugid.py") + (synopsis "Module for Base64 encoded UUID v4 slugs") + (description "This package provides a module for generating v4 +UUIDs and encoding them into 22 character URL-safe base64 slug +representation.") + (license license:mpl2.0))) + (define-public python-rich (package (name "python-rich")