From patchwork Mon Mar 20 17:13:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 48239 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 869D316F34; Mon, 20 Mar 2023 17:23:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B43F016F2D for ; Mon, 20 Mar 2023 17:23:11 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peJDt-0002Rw-LT; Mon, 20 Mar 2023 13:23:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peJDq-0002QV-BL for guix-patches@gnu.org; Mon, 20 Mar 2023 13:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peJDq-0003R7-35 for guix-patches@gnu.org; Mon, 20 Mar 2023 13:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peJDp-0003Vy-K3 for guix-patches@gnu.org; Mon, 20 Mar 2023 13:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62196] [PATCH 032/223] gnu: ruby-standard: Enable test suite. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62196 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62196@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 62196-submit@debbugs.gnu.org id=B62196.167933298113501 (code B ref 62196); Mon, 20 Mar 2023 17:23:01 +0000 Received: (at 62196) by debbugs.gnu.org; 20 Mar 2023 17:23:01 +0000 Received: from localhost ([127.0.0.1]:55832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peJDo-0003Vh-Nm for submit@debbugs.gnu.org; Mon, 20 Mar 2023 13:23:00 -0400 Received: from mail-yw1-f182.google.com ([209.85.128.182]:45590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peJDm-0003VS-3m for 62196@debbugs.gnu.org; Mon, 20 Mar 2023 13:22:58 -0400 Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5418d54d77bso235916947b3.12 for <62196@debbugs.gnu.org>; Mon, 20 Mar 2023 10:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679332972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N7Z+TdLX2Fx9/lkjKe5OSPH6TRxWfoOXB+e4Gl7EGxo=; b=WYJJnD8QXrmfmqKbGW5ZVnKKtRa9xVs5OtNK73iWJyWDhQg7CGgTzNhpj7fq3h+I0A nfXzy/bizzhYo5JmqREcgXLOtBBcVRZHyr5+ritx3YwXta1EDmNhOKPUtgJOjxQBG7ZJ IGOAv9fRl6Sz/72rXwoibQsZdNZO/OnLvIOADrRoBDgPUb7oToYFmwFJlhUt6bT3FAqr 0vgPkAPykKVVSBGhSLa2lqwkrnd1dI7j3dLjyVNjOXV6mI7wYbuVRe5cMjfkre4EFXx4 GIrPFuFtKgTTJoTHm9GhwNR1K6fE1oWpF9P2UPH8nbDvzdtacShoPHrv2XxwO1bcWjdX BDzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679332972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N7Z+TdLX2Fx9/lkjKe5OSPH6TRxWfoOXB+e4Gl7EGxo=; b=xKmK4UMyiLiP+OxiXLPQ0+tVA3b7Ev5DiwgCRugPr6ySZQ8ooWX1jhK642C3RbJhem /5QfWwy7ejpVtDhBsaanmBhcRKVyqhVK87OJT+mQaGzgsX/sMYrlPjkzkrHGZOSPBpbj NZyGCCKzywL9rFgrBbQiYa4gS3F7Phyg3Jz1lrfBP8tG9XjvqnTiQYLnhnOgN6lur2we 655AxXIhffJjnNiQzgFz6SxhPZQWUyfO2cOIWnocbw+0G00SLI7yiSw0xLBdLcEsg2nm eGJQOmxlQMzYmCYrXGr7VZFsG5HBRG8MkgO49fN/47/j5PXNdNMjwxOxQvXTi2BH/3aO 1tgw== X-Gm-Message-State: AO0yUKVj70UdHR1hobCNUOG0vXRS8IIRjS8AqRc/7bTcH2GFThYhuOsq PgyuP19PfUz74hRL25LTxoLeu+1YlXQ= X-Google-Smtp-Source: AK7set+ztIBHEfC1cP1iqUN28Y0yY5YYjwvwWfudrKllJaRTCI4YwxoePqAvxfycnagx7t7or71bOw== X-Received: by 2002:a05:6214:23cd:b0:56e:bdfb:f4c5 with SMTP id hr13-20020a05621423cd00b0056ebdfbf4c5mr41744928qvb.36.1679332628170; Mon, 20 Mar 2023 10:17:08 -0700 (PDT) Received: from localhost.localdomain (dsl-10-128-46.b2b2c.ca. [72.10.128.46]) by smtp.gmail.com with ESMTPSA id p17-20020a374211000000b007428e743508sm7673809qka.70.2023.03.20.10.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 10:17:07 -0700 (PDT) From: Maxim Cournoyer Date: Mon, 20 Mar 2023 13:13:24 -0400 Message-Id: <20230320171635.11184-32-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230320171635.11184-1-maxim.cournoyer@gmail.com> References: <20230320171635.11184-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/ruby.scm (ruby-standard) [arguments]: Delete #:tests? argument. Delete relax-version-requiremens phase. Add set-HOME and delete-problematic-tests phases. [propagated-inputs]: Add ruby-language-server-protocol. --- gnu/packages/ruby.scm | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 265dd6e50a..b06bdbcb6b 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -1816,17 +1816,28 @@ (define-public ruby-standard "0c0lsrvdl224s8166xrk9ibm19wbzn5l9s27cm7bjn0jr81j6agk")))) (build-system ruby-build-system) (arguments - ;; TODO: the tests are currently broken due to using a different Rubocop - ;; version. - `(#:tests? #f - #:phases + `(#:phases (modify-phases %standard-phases - (add-after 'unpack 'relax-version-requiremens + (add-after 'unpack 'set-HOME (lambda _ - (delete-file "Gemfile") - (delete-file "Gemfile.lock")))))) - (native-inputs (list ruby-gimme ruby-pry ruby-simplecov)) - (propagated-inputs (list ruby-rubocop ruby-rubocop-performance)) + ;; Some tests fail otherwise. + (setenv "HOME" "/tmp"))) + (add-after 'unpack 'delete-problematic-tests + ;; These tests fail for unknown reasons (see: + ;; https://github.com/testdouble/standard/issues/532). + (lambda _ + (for-each + delete-file + '("test/standard_test.rb" + "test/standard/cop/block_single_line_braces_test.rb"))))))) + (native-inputs + (list ruby-gimme + ruby-pry + ruby-simplecov)) + (propagated-inputs + (list ruby-language-server-protocol + ruby-rubocop + ruby-rubocop-performance)) (synopsis "Ruby Style Guide, with linter & automatic code fixer") (description "Standard is a port of StandardJS. Like StandardJS, it aims to save time in the following ways: