diff mbox series

[bug#62254] guix: Shorten URL for home page in texlive importer.

Message ID 20230318131319.272034-1-mail@nicolasgoaziou.fr
State New
Headers
Series [bug#62254] guix: Shorten URL for home page in texlive importer. |

Commit Message

Nicolas Goaziou March 18, 2023, 1:13 p.m. UTC 
* guix/import/texlive.scm (tlpdb->package): Use short URL for home page.
---
 guix/import/texlive.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)


base-commit: 3893758dac76fc30b23d4715e849e262306f268d

Comments

Ludovic Courtès March 26, 2023, 2:19 p.m. UTC | #1 
Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> * guix/import/texlive.scm (tlpdb->package): Use short URL for home page.

[...]

> +        ,@(or (and=> (assoc-ref data 'name)
> +                     (lambda (name)
> +                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
> +                                                    name)))))

Are there cases where ‘data’ might be missing ‘name’?

If not, please push!

Thanks,
Ludo’.
Nicolas Goaziou March 30, 2023, 4:22 p.m. UTC | #2 
Hello,

Ludovic Courtès <ludo@gnu.org> writes:

>> +        ,@(or (and=> (assoc-ref data 'name)
>> +                     (lambda (name)
>> +                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
>> +                                                    name)))))
>
> Are there cases where ‘data’ might be missing ‘name’?

I don't think so. And even if assoc-ref returns #false, the template
would get the default home page.

> If not, please push!

Done. Thanks for the feedback

Regards,
diff mbox series

Patch

diff --git a/guix/import/texlive.scm b/guix/import/texlive.scm
index 82014ee568..e77b2a3f9a 100644
--- a/guix/import/texlive.scm
+++ b/guix/import/texlive.scm
@@ -286,9 +286,10 @@  (define (tlpdb->package name version package-database)
                                            (string->symbol name)))
                                        inputs))))))
               '())
-        ,@(or (and=> (assoc-ref data 'catalogue-ctan)
-                     (lambda (url)
-                       `((home-page ,(string-append "https://ctan.org" url)))))
+        ,@(or (and=> (assoc-ref data 'name)
+                     (lambda (name)
+                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
+                                                    name)))))
               '((home-page "https://www.tug.org/texlive/")))
         (synopsis ,(assoc-ref data 'shortdesc))
         (description ,(beautify-description