diff mbox series

[bug#62100,v2,02/15] gnu: python-jupytext: Remove python-pre-commit.

Message ID 20230311013125.7182-2-antero@mailbox.org
State New
Headers show
Series [bug#62100,v2,01/15] gnu: pre-commit: Update to 3.1.1. | expand

Commit Message

Antero Mejr March 11, 2023, 1:31 a.m. UTC 
* gnu/packages/python-xyz.scm (python-jupytext)[native-inputs]: Remove
python-pre-commit.
[native-inputs]: Add pre-commit.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liliana Marie Prikler March 11, 2023, 7:52 a.m. UTC | #1 
Am Samstag, dem 11.03.2023 um 01:31 +0000 schrieb Antero Mejr:
> * gnu/packages/python-xyz.scm (python-jupytext)[native-inputs]:
> Remove python-pre-commit.
> [native-inputs]: Add pre-commit.
Should be "replace python-pre-commit with pre-commit".  Regarding the
first message in v1, shouldn't you be dropping this input altogether? 
(Though I suppose pre-commit being a developer tool doesn't stop people
from invoking it in their build files.)

Cheers
Antero Mejr March 11, 2023, 1:44 p.m. UTC | #2 
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 11.03.2023 um 01:31 +0000 schrieb Antero Mejr:
>> * gnu/packages/python-xyz.scm (python-jupytext)[native-inputs]:
>> Remove python-pre-commit.
>> [native-inputs]: Add pre-commit.
> Should be "replace python-pre-commit with pre-commit".  Regarding the
> first message in v1, shouldn't you be dropping this input altogether? 
> (Though I suppose pre-commit being a developer tool doesn't stop people
> from invoking it in their build files.)

Fixed that commit message in v3.

Yes, python-jupytext is an unusual case where they invoke pre-commit as
part of their tests.
diff mbox series

Patch

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f3ec02ea..4d76ab9bf6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -351,6 +351,7 @@  (define-public python-jupytext
                                                       " and not "))))))))))
     (native-inputs
      (list git-minimal
+           pre-commit
            python-autopep8
            python-black
            python-flake8
@@ -358,7 +359,6 @@  (define-public python-jupytext
            python-isort
            python-ipython-genutils
            python-jupyter-server
-           python-pre-commit
            python-pytest
            python-pyaml))
     (propagated-inputs