diff mbox series

[bug#61117] Update svtplay-dl to 4.18

Message ID 20230305112617.3babd216@tsyesika.se
State New
Headers show
Series [bug#61117] Update svtplay-dl to 4.18 | expand

Commit Message

Jessica Tallon March 5, 2023, 10:39 a.m. UTC 
Hello,

Sorry for the long delay on addressing this feedback.

Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Jessica,
>
> Please avoid propagation whenever possible; it breaks all kinds of
> nice things.
>
> Propagating A from B means that Guix will effectively ‘install’ A
> alongside B when the user installs only B.  Or how classical package
> managers bluntly handle ‘dependencies’.  Not good!
>

Thanks for the tip, I've included a patch which does it this way.

>
>> it's needed while the program is running to merge two files, not
>> while building.
>
> So 4.17 did not need or use ffmpeg this way?
>
> Otherwise, put each unrelated changes into a separate commit: one to
> improve the ffmpeg situation, and one to update svtplay-dl. You can
> send multiple related commits as one patch series to one bug number,
> though.

4.17 did indeed need ffmpeg, I've included two patches one which
resolves the ffmpeg issue and the other which updates it to 4.18.

Thanks,
Jessica.
diff mbox series

Patch

From 1b81f1786ba0cb038bf76ab74cbc90847d06206b Mon Sep 17 00:00:00 2001
Message-Id: <1b81f1786ba0cb038bf76ab74cbc90847d06206b.1678010569.git.tsyesika@tsyesika.se>
In-Reply-To: <cover.1678010569.git.tsyesika@tsyesika.se>
References: <cover.1678010569.git.tsyesika@tsyesika.se>
From: Jessica Tallon <tsyesika@tsyesika.se>
Date: Sun, 5 Mar 2023 10:56:54 +0100
Subject: [PATCH 2/2] gnu: svtplay-dl update to 4.18

* gnu/packages/video.scm (svtplay-dl) update to 4.18
---
 gnu/packages/video.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 721f7c4d4e..fbebaaff28 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -5680,7 +5680,7 @@  (define-public video-contact-sheet
 (define-public svtplay-dl
   (package
     (name "svtplay-dl")
-    (version "4.17")
+    (version "4.18")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5689,7 +5689,7 @@  (define-public svtplay-dl
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx"))))
+                "1xb2n3bwjddr86mjynbfd8m2g98gzqbj5mmsfc735q9xp14l30pf"))))
     (build-system python-build-system)
     (arguments
      (list
-- 
2.39.1